GithubHelp home page GithubHelp logo

Comments (5)

SorraTheOrc avatar SorraTheOrc commented on July 20, 2024

@hosungsmsft you might appreciate the script in PR #7. It's not wired into pre-commit yet, but it is faster than manually checking.

from moodle.

hosungsmsft avatar hosungsmsft commented on July 20, 2024

@rgardler yes, and I was looking at your PR for review, but you already merged. I didn't understand in your script why the current branch is not embedded in the variable SCRIPT_LOCATION (contrast to BASE_TEMPLATE_URL), and you are comparing the BASE_TEMPLATE_URL with the scriptLocation value? Are they bugs?

from moodle.

SorraTheOrc avatar SorraTheOrc commented on July 20, 2024

from moodle.

hosungsmsft avatar hosungsmsft commented on July 20, 2024

No worries, and you know I made an embarrassing bug myself (which I think led you to craft this), and fixing it urgently... Let me fix these bugs over the weekend, with broken links in other documentation. I'm right now fixing the Apache template blunder... :(

from moodle.

hosungsmsft avatar hosungsmsft commented on July 20, 2024

#13 fixes the script bugs mentioned above.

from moodle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.