GithubHelp home page GithubHelp logo

Comments (7)

SorraTheOrc avatar SorraTheOrc commented on June 21, 2024

For clarity step 3, the load testing step, should only occur on demand or during preparation of a release. This is an expensive and time consuming set of tests.

from moodle.

hosungsmsft avatar hosungsmsft commented on June 21, 2024

Rephrased this issue title for v1.5.1, where we focus on no. 2 of this issue (1 is done now). 3 (load testing running) is not scoped in here.

from moodle.

hosungsmsft avatar hosungsmsft commented on June 21, 2024

FYI, all the necessary information for testing the deployed site is available from az group deployment show -g $AZURE_RESOURCE_GROUP -n azuredeploy --query properties.outputs. You can add the next-level field name in the --query properties.outputs to get a specific output, or simply use jq to extract needed information from the JSON output.

from moodle.

roperto avatar roperto commented on June 21, 2024

Hi @hosungsmsft -- I've noticed you added "CI only master branch". Is there a reason behind that?

I think it would be nice to have it for all branches. It is common, for example, to create a feature branch and do all dev work on that before merging back into master, and it would be nice to have the CI running on those branches too.

See: dcceea9#diff-354f30a63fb0907d4ad57269548329e3R4

What do you think?

Cheers

from moodle.

hosungsmsft avatar hosungsmsft commented on June 21, 2024

@roperto -- Thanks for your question. My reasoning behind that restriction was that the full CI that includes the test deployment might be unnecessarily costly for non-master branches (time-wise and Azure cost-wise). I'd be totally fine if the linting part of the CI is run on every branch, and I suppose that can be programmatically controlled using some env var? What do you think? Thanks!

from moodle.

roperto avatar roperto commented on June 21, 2024

@hosungsmsft -- That is a good point, I created #90 to separate it from this thread and I will continue working on this issue. Thank you for the feedback.

from moodle.

hosungsmsft avatar hosungsmsft commented on June 21, 2024

Fixed in #91

from moodle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.