Comments (8)
Thank you for this. I'll look into it ASAP, as the rendering position has been an issue for quite a while. On which platform you experienced this problem?
from atom-clock.
I am experiencing this in Windows...
from atom-clock.
I'm fixing this right now. It seems to be a thing on OS X as well.
from atom-clock.
Removing all the CSS and adding the inline-block
class to the clock element seemed to fix it for me. I'm on OS X by the way.
atom-clock.less
:
@import "ui-variables";
.atom-clock {
// display: inline-block;
// margin-left: 1em;
// margin-right: 0.5em;
// position: relative;
// vertical-align: middle;
//
// .span {
// text-align: left;
// }
}
atom-clock-view.js
:
drawElement() {
this.element = document.createElement('div')
this.element.className = 'atom-clock inline-block'
this.element.appendChild(document.createElement('span'))
this.statusBar.addRightTile({
item: this.element,
priority: -1
})
}
See before (top) and after (bottom)
from atom-clock.
I actually did not change the code, just the style file, adding some stuff for the icon. The result seems to be pretty much the same.
@import "ui-variables";
@import "octicon-mixins";
.atom-clock {
display: inline-block;
position: relative;
.icon:before {
.icon-size(14px);
top: 1px;
margin-right: 3px;
}
}
from atom-clock.
Actually, the atom-clock
class should also have margin-left
set to @component-padding
, so that there will be space between the clock and the element to the left.
from atom-clock.
Seems to be reasonable. I still don't know whether this is the right solution, or the css style is useless.
from atom-clock.
The inline-block
class seems to add margin-left: 1.5em
so maybe the CSS could just be used to move the icon around. Up to you I guess, it seems to be what other packages are using
from atom-clock.
Related Issues (20)
- Tooltip alert for UTC time HOT 7
- Just an idea I had now with the last update... HOT 2
- README image are no longer displayed in Atom settings view HOT 2
- Failed to activate the ide-python package HOT 3
- naziv HOT 1
- Day Fraction HOT 1
- Add a hot key to have a notification HOT 1
- Uncaught Error: Cannot find module 'moment' HOT 2
- Uncaught TypeError: Cannot read property 'enable' of undefined HOT 3
- failed to activate the status-bar package when atom-clock enabled HOT 4
- Function.extractParams is deprecated. HOT 2
- Failed to load the atom-clock package HOT 2
- Incorrect local time HOT 5
- pjkmô
- Add possibility to copy time into clipboard HOT 6
- customizing HOT 5
- Suggestion HOT 4
- 'tk' locale not working
- Wrong screenshot for 12 hour
- HTMLDocument.registerElement is deprecated.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from atom-clock.