Error when building orcania in release mode using MinGW toolchain about orcania

[madebr]

I can confirm this fixes the error.

[babelouest]

It looks like a overkill warning message, but if I look at it, an answer to a similar message says to replace strncpy with a memcpy:

@@ -133,8 +148,8 @@ char * mstrcatf(char * source, const char * message, ...) {
         out = o_malloc(source_len+message_formatted_len+sizeof(char));
         vsnprintf(message_formatted, (message_formatted_len+sizeof(char)), message, argp_cpy);
         if (out != NULL) {
-          o_strncpy(out, source, source_len);
-          o_strncpy(out+source_len, message_formatted, message_formatted_len);
+          memcpy(out, source, source_len);
+          memcpy(out+source_len, message_formatted, message_formatted_len);
           out[source_len+message_formatted_len] = '\0';
         }
         o_free(message_formatted);

Can you try it?

[babelouest]

I've changed the code by replacing both memcpy with a single msprintf("%s%s", source, message_formatted), let me know if you have other compiler warnings

[madebr]

I remember a few warnings when building 32-bit ulfius on MSVC about storing 64-bit integers in size_t.
I can reproduce a few by adding -Wconversion to CMAKE_C_FLAGS.

[babelouest]

I've added the flag -Wconversion and I've seen some too, thanks