backdrop-contrib / webform

For making surveys and forms in Backdrop.

Webform

Webform is the module for making forms and surveys in Backdrop.

This module adds a webform content type to your Backdrop site. A webform can be a questionnaire, contact or request form. These can be used by visitor to make contact or to enable a more complex survey than polls provide. Submissions from a webform are saved in a database table and can optionally be mailed to e-mail addresses upon submission.

Results can be exported into Excel or other spreadsheet applications. Webform also provides some basic statistical review and has an extensive API for expanding its features.

Installation

1. Install this module using the official Backdrop CMS instructions at https://backdropcms.org/guide/modules.
2. Login as an administrator. Enable the module in the "Administer" > "Modules"
3. (Optional) Edit the settings under "Administer" > "Configuration" > "Content authoring" > "Webform settings"
4. Create a webform node at node/add/webform.

Support

Please use the issue queue for filing bugs with this module at https://github.com/backdrop-contrib/webform/issues

Webform is a popular non-utility contrib module. It is a large, rich module used by hundreds of thousands of sites. If you are using Webform, please give back to our community. We need your help triaging issues, answering support requests, writing patches, reviewing/testing patches.

Please always use the project issue tracker to report bugs, request support and/or request new features. The maintainers neither read the forums nor reply to direct e-mails for support.

Open one issue for each problem/request; don't bundle several issues into one submission. Please search the queue and read the handbook pages to avoid duplicate issues.

Background

Backdrop Webform is based on the Webform module for Drupal 7--starting at version 7.x-4.4. For additional examples of Webform configuration, the existing documentation and videos the Drupal 7 verison will likely be useful for the Backdrop version as well. Note that Webform for Drupal 8 continues the 'Webform' name and serves the same general purpose, but is a different product with different features and configuration.

Future

The Backdrop version of Webform will continue to track Webform 7.x-4.x as long as it gets updates. There are no plans to track Webform for Drupal 8, 9 or above, since the codebase is quite different. However we will consider merging requests that incorporate new features from the Drupal 8.x-5.x/6.x branches of Webform as they are submitted.

If you would like to see a new feature in Webform, open an issue in the issue queue for discussion.

License

This project is GPL v2 software. See the LICENSE.txt file in this directory for complete text.

Maintainers

• quicksketch https://github.com/quicksketch
• herbdool https://github.com/herbdool

Credits

Ported to Backdrop from Drupal 7 by biolithic https://github.com/biolithic. The Drupal 7 version originally written and maintained by a large number of contributors, including:

• quicksketch https://www.drupal.org/u/quicksketch
• fenstrat https://www.drupal.org/u/fenstrat
• danchadwick https://www.drupal.org/u/danchadwick
• torotil https://www.drupal.org/u/torotil

Special thanks

This Backdrop module is supported by the hosted survey-solution website Webform.com and Lullabot.

webform's Issues

Data-Migration from Webform 7.x-4.12 (Drupal) does not work

Migration from Drupal 7.41 to Backdrop 1.3.2, webform was not uninstalled in order to keep the data.
Webforms do not show and following errors:
Warning: array_flip() expects parameter 1 to be array, null given in webform_components() (Zeile 4323 von /home/www/backdrop/modules/webform/webform.module).
and then many times (seems to be one for every webform):
Warning: array_key_exists() expects parameter 2 to be array, null given in webform_components() (Zeile 4328 von /home/www/backdrop/modules/webform/webform.module).
and last:
Warning: Invalid argument supplied for foreach() in form_type_checkboxes_value() (Zeile 2400 von /home/www/backdrop/core/includes/form.inc).

Run config labels through t()

in webform.module should be:

case 'webform_progressbar_label_first':
      $result = t(config_get('webform.settings', 'webform_progressbar_label_first'));
      break;
    case 'webform_progressbar_label_confirmation':
      $result = t(config_get('webform.settings', 'webform_progressbar_label_confirmation'));
      break;

Missing classes

The classes now have to be registered with hook_autoload_info() but in this module they were removed from .info but not placed in that hook.

I noticed this when trying to export submissions and it couldn't find the class webform_exporter.

Fix roles in function webform_node_defaults()

Should be:
'roles' => array('anonymous', 'authenticated'),
Not:
'roles' => array('1', '2'),

Admin theme

On a site I'm working on I notice that when editing a webform the Admin theme is respected, but on the "Webform" and "Results" tab it uses the front end theme. It seems that these should use the Admin theme as well, right?

Remove unused webform_node_types variables

Updating from 1.2.1 to 1.2.2 I have got a warning

Updating from 1.2.1 to 1.2.2 I have got not 6 warnings it was before but only one warning - with Webform:

webform_roles error: not the right rid field when upgrading from Drupal

There was no update function to change the rid to be a varchar to match the database schema. It results in this issue:

Incorrect integer value: 'authenticated' for column 'rid' at row 1: INSERT INTO {webform_roles} (nid, rid) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1); Array ( [:db_insert_placeholder_0] => 648 [:db_insert_placeholder_1] => authenticated ) in webform_node_update() (line 1506 of /home/nubeli/a.nubeli.org/backdrop/modules/contrib/webform/webform.module).

Have tests meet Backdrop standard

The tests will need to be in a separate tests directory with a .info file in order to run them.

User unable to see the form.

I have just installed Webform but it is saying that a user must log-in in order to see and use the form. I have tried setting permissions so that ananonymous user can create new webform content but that hasn't made any difference. Any suggestions?

[UX] Move placement of checkbox to make webform a block

I always create a webform and dumbly go looking for it as a block...then I remember where the checkbox is to make it available as a block.

I only know where that is, because I've made many a webform in the past, but I've never thought it was worthy of "advanced settings" territory and common enough need to place elsewhere.

The Views module makes it clear whether you're making a block, a page, or both right up front. I propose to place that checkbox on the create a webform page underneath the body field.

Only a quick notion I haven't thought through too much. Thoughts?

Query topic and email options

I am trying to use the query options feature whereby the user selects a topic and webform emails the form result to a specific email address, using this admin form to set the addresses:

But the email addresses I enter do not seem to be being saved either in the webform.settings config file nor in a data table e.g. webform_emails.

I am now trying to work out what should be happening here.

Add an option for a message when page is reloaded upon submission

When I just set the webform to reload the page upon submission, I was expecting to see a "you submitted a webform, great job!" message, but I saw nothing. Maybe this is because the theme I'm using or the fact that the webform is in a block, but I think it'd be a good idea to allow users to input a message to the user, with a default fallback, in order to ensure the user knows they have submitted the form correctly.

Convert Views to JSON config so they get installed

Webform settings are not saving properly

Incorrectly in webform_admin_settings_submit() in includes/webform.admin.inc, the config is being saved at the beginning instead of at the end so it misses some changes that also need to be saved such as the disabled components.

Not including webform-admin.css

One of the webform admin displays is not working quite right for me, see below, and I find that my page is not including the relevant stylesheet webform-admin.css that has a style for webform-submission-info-text

E-mail header details — wrong From e-mail

In the message received from the form I have this header:

From: [email protected] — it is wrong!
To: [email protected]
Reply: [email protected]

I the From field is displayed the admin's e-mail but I would like it be something like [email protected] or a sender's e-mail (the same like in Reply field).

Can not understand how to do it 😄

Thank you!

Error while exporting to spreadsheet

An error occurs when exporting form results to a spreadsheet. (webform-1.x-1.x)(backdrop-1.1.2)
(PHP Version 5.3.10-1ubuntu3.19)
Any thoughts would be appreciated.

Error:
(An AJAX HTTP error occurred. HTTP Result Code: 500 Debugging information follows. Path: /t5/batch?id=3&op=do_nojs&op=do StatusText: Internal Server Error ResponseText:)

(Warning: Missing argument 2 for backdrop_tempnam(), called in /var/www/merpmerp.com/t5/modules/webform-1.x-1.x/includes/webform.report.inc on line 765 and defined in backdrop_tempnam() (line 2442 of /var/www/merpmerp.com/t5/core/includes/file.inc).
Notice: Undefined variable: prefix in backdrop_tempnam() (line 2448 of /var/www/merpmerp.com/t5/core/includes/file.inc).)

Select options using radio buttons not available.

I would like to have a field that is entered by means of radio buttons. There seems to be an issue here which I will investigate.

Ensure all variables have defaults in hook_update_XXXX and CMI when migrating from Drupal

If the variables don't exist in Drupal 7 they'll just get null overwritten the default in the CMI file. So they need defaults in addition to proper defaults being set in the CMI.

webform_update_last_removed() not correctly set in current release.

It looks like webform_update_last_removed() contains a drupal 6 upgrade number, but if this module was ported to Backdrop from Drupal 7 this should be the number of the last Drupal 7 update hook, and should be 7000+.

The most recent update hook in webform 4.x is numbered 7430, so I'd guess that's what should be in hook_update_last_removed() but I read #26 and now I'm not sure that's corect as the last hook in 4.4 is numbered 7421.

Fix function webform_options_countries

Should be:

include_once BACKDROP_ROOT . '/core/includes/locale.inc';

Links to "Token module" point to Drupal project page

In the description text for "Token values" while setting up Webform components (./webform/components/new/..), if the site doesn't have the Token module installed, the description says to install it, but the link goes to the drupal.org Token project page:

"A full listing of tokens may be listed here by installing the Token module."

These links should all point to the Backdrop version.

Get variables from system.date and system.core instead of webform.settings

For variables that should be called from system.core:

• file_temporary_path
• node_admin_theme
• user_register

and from system.date:

• formats
• user_timezone_configurable
• default_timezone

If webform_table default defaults to false then the upgrade needs to check for webform_webforms view

Upgrading from Drupal with webform and there's no check to see if the default views exist and install them if they don't.

Description - how to replace?

Hi!

To replace (move) Description to another place - should I edit the template?
Hm, why there is no a way to replace (move) it from admin Edit component ...

Thank you!

Fix missing WebformConditionals class

Class was introduced in Drupal 7 Issue 1840776 and needs to be listed in hook_autoload_info() in Backdrop.

Hook updates in install file

Nice job on getting webform migrated!

I haven't tried it yet, but noticed that there should be a 1xxx update function from Drupal to Backdrop. And can drop the 7xxx updates.

I look forward to giving it a spin.

Submission email has no formatting.

Submission email has no page breaks, the submissions are all listed inline.

Disable comments on webform content type when installing

This was done in Drupal 7 but wasn't updated in this fork to work for Backdrop storing content type config in per content type config. So instead of trying this in webform.install, which does nothing:

config_set('webform.settings', 'comment_webform', '0');

it should be:

  if (config_get('webform.settings', 'webform_install_create_content_type')) {
    $webform_type = array(
      'type' => 'webform',
      'name' => st('Webform'),
      'base' => 'node_content',
      'description' => st('Create a new form or questionnaire accessible to users. Submission results and statistics are recorded and accessible to privileged users.'),
      'custom' => TRUE,
      'modified' => TRUE,
      'locked' => FALSE,
      'settings' => array(
        'comment_enabled' => FALSE,
      ),
    );
    $webform_type = node_type_set_defaults($webform_type);
    node_type_save($webform_type);

Some variables incorrectly set as string instead of array in default config file

Not everyone is going to do a fresh install of this module and for those they'll see some glaring issues with missing defaults or variables set as strings instead of arrays in the config file. Here are the ones I found (there may be more):

webform_allowed_tags should be an array: ["a", "em", "strong", "code", "img"]
webform_node_types_primary should be an array ["webform"]
webform_progressbar_style should be ["progressbar_bar", "progressbar_pagebreak_labels", "progressbar_include_confirmation"]
webform_node_types should be ["webform"]

Merge in 7.x-4.6

Advanced fieldset in webform settings is below the submit button

This is easily fixed by updating the form so that the submit button array is within an 'action' array as per the Backdrop update docs.

Add me as a maintainer?

Looks like @quicksketch has his hands full and @biolithic doesn't want to be a maintainer. I'd be willing to be one of the maintainers if that's okay with the current maintainers.

I'll mostly focus on making sure that releases from Drupal 7 get merged in and make small fixes here and there.

Webform "Full content" View mode does not work in a block?

Hi! I am sorry if this is something of my fault but may be somebody could direct me to a right way :)

I try to show my Webform content in a block.
According to the instructions - "You may customize different view modes (other than the "Form only" mode)" - I have customized it to Full content but it does not work for me. After the block configuration is saved and the layout is saved too it switches back to the Form only mode.

I have tried to set up Full content mode for Webform block in Drupal 7 and there is no any problem - it works well.

Error when configuring Webform block's View mode as Full content

I try to configure Webform block.
If I select View mode > Full content then I get the error and the block View mode is saved as Form only.

Update webform.settings.json to use booleans: true/false instead of "TRUE" / "FALSE"

Need to get the logic right by storing the boolean rather than strings.

Prevent saving form_id, etc in config

The submit function on the settings form is saving junk like the form_id, op into the json file. Better to be specific about which variables to save.

Division by zero when exporting

I get this error when exporting submissions:

Warning: Division by zero in webform_results_batch_rows() (line 1242 of /home/nubeli/a.nubeli.org/backdrop/modules/contrib/webform/includes/webform.report.inc).

Update documentation with new project page URLs

Now that there's a project page for the module on https://backdropcms.org/project/webform let's update the URLs to go there instead of other places.

..also, the link to the Drupal forms_api.html is dead, so I'll update that to go to the Backdrop CMS docs as well.

hook_config_info missing

I was unable to export webform.settings. I think we need webform_config_info() rather than mailsystem_config_info() in webform.module.

Add docblock to update function from Drupal.

When updating from Drupal to backdrop all you see in the UI for the webform update is

webform module
    1000 - 

which can be a little scary. By adding a docblock to the update function users will know what is about to happen to their webforms!' How about something like this?

/**
 * Update webforms from Drupal to Backdrop.
 */

Broken upgrade path - update 7423/1008 runs twice

I'm upgrading from Drupal 7 (webform version 7.x-4.14) and I get the following fatal error when upgrading to Backdrop (webform version 1.x-1.2.2)

Failed: PDOException: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'c.action' in 'field list': INSERT INTO {webform_conditional_actions} (nid, rgid, action, target_type, target, argument) SELECT c.nid AS nid, c.rgid AS rgid, c.action AS action, c.target_type AS target_type, c.target AS target, '' AS argument FROM {webform_conditional} c ORDER BY nid ASC, rgid ASC; Array ( ) in webform_update_1008() (line 1081 of backdrop/modules/contrib/webform/webform.install).

Looking at my Drupal 7 schema, the action column is already on the webform_conditional_actions and not on the webform_conditional table.

It looks like webform_update_1008 is similar to webform_update_7423 in Drupal 7. If we are to have both, there will need to be some better checking to assure webform_update_1008() is not run if webform_update_7423 has already been run in Drupal 7.

Use correct variables from system.date.json as per Backdrop 1.6.1

user_timezone_configurable should be user_configurable_timezones

It doesn't need to be backwards compatible with previous versions of Backdrop since this was broken in Backdrop core before 1.6.1.

Revert reversions when ported from just before 7.x-4.5

The git repo was forked from just before 7.x-4.5 (until commit 7b61e60), but the code base seems to be from 7.x-4.4. So it seems to have inadvertently reverted the changes to a few commits applied after 7.x-4.4.

[META] Webform commits from 7.x-4.4 - 7.x-4.14

• | #xx | bd3a45c | Issue #2449501 by DanChadwick: Site name containing UTF-8 used with emails with Reply-To feature
• | #xx | 154deb3 | Issue #2451077 by skyhawk669: Cannot resend emails for results of webform using conditional email feature
• | #xx | 9e485d6 | Issue #2452771 by DanChadwick: Use views tag of 'webform' for webform built-in views
• | #xx | 26999cd | Issue #2452845 by DanChadwick: Whitespace and capitalization adjusted to standards.
• | #xx | 34ed852 | Issue #2449383 by Upchuk, DanChadwick: Select list component display incorrectly orders items; should match component order
• | #xx | 3d98770 | Issue #153017 by Dan Chadwick: Incorrect display of select component in e-mail list.
• | #xx | 9807f2a | Issue #1840776 by DanChadwick: Fixed components with a value that are hidden by conditionals should be empty.
• | #xx | e67caff | Issue #2449383 by quicksketch, DanChadwick: Select list component table output incorrectly orders items; should match component order.
• | #xx | b386416 | Issue #2456079 by DanChadwick: Hidden components should not be considered empty by conditionals.
• | #xx | cf9d5a5 | Issue #2455937 by chellman: Upgrade from 7.x-3.x fails on update 7419 - index already exists.
• | #xx | c921cc5 | Issue #2453687 by VladSavitsky, DanChadwick: Messages about reached limits should have type 'warning' not 'error'.
• | #xx | a0287ca | Issue #2457045 by david_garcia, DanChadwick: Index on submission data incompatible with MS SQL Server
• | #xx | 10f79f8 | Issue #2453393 by meickol: Notice: Undefined index: exporter in webform_results_download().
• | #xx | 37e1527 | Issue #2458025 by DanChadwick: Degenerate webform with no components on first page causes warnings
• | #xx | 6359141 | Issue #2457961 by DanChadwick: WebformConditionals->executeConditionals() fails with Webform Preview page submission.
• | #xx | 0939754 | Issue #1919872 by torotil, DanChadwick: Don't skip hook_node_view() for blocks and views.
• | #xx | 4a12983 | Issue #2339473 by DanChadwick: webform strips media module and other token-like markup.
• | #xx | 70ea012 | Issue #1840776 by DanChadwick: Out-of-sequence conditionals generate warnings and don't function.
• | #xx | 9d3b63c | Issue #2459071 by amoebanath, DanChadwick: Conditional for target on a different page broken if source component value has no value.
• | #xx | 417eddf | Issue #1913500 by marcoscano, DanChadwick: Delete Webform content type if not in use upon uninstall
• | #xx | b0fdabe | Issue #2460221 by DanChadwick: Self-reference warning for conditionals on >= page 2 gives PHP notice.
• | #xx | 502b4f1 | Issue #1815996 by DanChadwick: Multiple target components for each conditional.
• | #xx | 297d6f6 | Issue #2454277 by DanChadwick: _webform_client_form_rule_check duplicates code in WebformConditionals.
• | #xx | f22f4fe | Issue #2458897 by DanChadwick: Convert conditional show/hide to is/isn't shown.
• | #xx | 6e1c97e | Issue #1885056 by DanChadwick: Conditional actions: required / optional.
• | #xx | 67ca10c | Issue #2460401 by DanChadwick: Enabling preview page breaks required fields.
• | #xx | 5d81035 | Issue #2459523 by DanChadwick: Previewing a private selected file that wasn't explicitly uploaded gives access denied.
• | #xx | fc964b5 | Issue #2415849 by DanChadwick: Conditional actions: set values, checked, unchecked.
• | #xx | 840120a | Issue #2454277 by DanChadwick: Fixed conditionally-hidden components displayed on submission if nested with fieldset.
• | #xx | 4c32ad9 | Issue #2461459 by DanChadwick: Add missing conditional rule operators.
• | #xx | e032f83 | Issue #2339473 by DanChadwick: webform token removal interferes with other module markup.
• | #xx | 8556904 | Issue #2260091 by aschmoe: Add form_builder support for placeholder attribute.
• | #xx | 5d8e8c4 | Issue #2442917 by podarok: Minor optimization to webform_components() and code clean-up.
• | #xx | 6810206 | Issue #326738 by Optalgin, Dan Chadwick: Support tokens in the File Upload Directory field.
• | #xx | efc74ce | Issue #2139287 by developermitesh, DanChadwick: Renaming 'File' uploads with tokens.
• | #xx | e9abce7 | Issue #2352927 by DanChadwick: Create token for specific value of select multiple.
• | #xx | a9e9ff9 | Issue #326738 by Optalgin, DanChadwick: Support tokens in the File Upload Directory field with Form Builder.
• | #xx | ff928df | Issue #1456496 by quicksketch, x_GoMad, DanChadwick: Make grid component support Semantic-differential scale with right-side headers.
• | #xx | 4a638c1 | Issue #1331956 by DanChadwick: Allow select components (list, single-select, no default) to customize name of empty list option.
• | #xx | 1df2b1c | Issue #1815996 by DanChadwick: Set default empty argument for webform_conditional_actions table.
• | #xx | 861a709 | Issue #2467605 by DanChadwick: Conditional select options not updating with two select source components.
• | #xx | bd20a7e | Issue #2468117 by DanChadwick: jpeg extension not automatically accepted when jpg is allowed.
• | #xx | 755af13 | Issue #2467877 by DanChadwick: Conditional fields in collapsed fieldset not hidden by default.
• | #xx | 4480a2b | Issue #2465291 by DanChadwick, podarok: Batch download of submissions returns all submissions on each batch run and report optimization.
• | #xx | be844e0 | Issue #2450163 by DanChadwick: Filter analysis data with views.
• | #xx | 897f62a | Issue #749360 by vernond, DanChadwick: Display only the non empty fields in email submissions token.
• | #xx | 392b8fd | Issue #2468835 by DanChadwick: Extend select component to email mapping length from 128 to 400 characters.
• | #xx | aeb1c1d | Fixed select component to email mapping whitspace error.
• | #xx | 52957ac | Issue #2465291 by Liam Morland: Batch download of submissions postgres compatibility.
• | #xx | 1060c61 | Issue #2471363 by DanChadwick: Fixed Webform displays in node, even when hidden, when block is also shown.
• | #xx | f69b05b | Issue #2467239: Reference project page in README.txt for requirements.
• | #xx | f09d6bb | Issue #1873498 by DanChadwick: Email cleanup, permit long-format names, allow multiple To addressees.
• | #xx | ba8f17b | Issue #2200587 by DanChadwick: Added multiple e-mail addresses and long-fromat addresses in email components.
• | #xx | ec883cc | Issue #2470385 by Liam Morland: Extend URL token-based access control to submissions
• | #xx | 77159f6 | Issue #2471885 by Liam Morland: Coding standards: In @param, the type goes before the variable
• | #xx | 540c1f4 | Issue #2472643 by DanChadwick: Breadcrumb and node tabs missing from e-mail add, edit, clone, and delete. Clear menu cache after updating.
• | #xx | d5d1c91 | Issue #2472685: Clicking a select component in an e-mail config doesn't display mappings.
• | #xx | 54389bb | Issue #1160400 by DanChadwick: Added multiple email recipients, one message configuration option.
• | #xx | 100b00b | Issue #1873498 by DanChadwick: Fixed attempting to send to an empty email address.
• | #xx | dcbae56 | Issue #1271784 by DanChadwick: Added option to see the confirmation message within a webform block.
• | #xx | c71815a | Issue #1160400 by DanChadwick: Remove multiple/individual e-mail option upon uninstall.
• | #xx | d28c38e | Issue #1346536 by nicholas.alipaz, DanChadwick: Make submission date display formats configurable.
• | #xx | f7ce37f | Issue #1346536 by nicholas.alipaz, DanChadwick: Make submission date display formats configurable for submission date token.
• | #xx | a011550 | Issue #1763668 by DanChadwick: Add completed and modified dates to the existing submitted date timestamp.
• | #xx | 7c70af3 | Issue #1763668 by DanChadwick: Update completion date upon initial submission creation (non-draft).
• | #xx | 272c5e6 | Issue #381068 by a.hover, rudins, DanChadwick: Download submissions by date range.
• | #xx | c87bebb | Issue #2449871 by DanChadwick: Numeric display, comparison and sort of submitted data in views.
• | #xx | c9f66ec | Issue #336150 by jtwalters, paolomainardi, dcampos, Albert Volkman, simon.fryer, sergiuteaca, xamanu: Make day/month/year optional in date components.
• | #xx | bf0ab63 | Issue #2474455 by pcambra, DanChadwick: Restrict available choices for select on date components.
• | #xx | c8f1ffa | Issue #2474455 by DanChadwick, Nick Denry: Add start and end time validation to time components and restrict UI options.
• | #xx | ea33272 | Issue #2471765 by DanChadwick: Edit existing submissions with date validation relative to completion date.
• | #xx | 84e7c6d | Issue #2474773 by Liam Morland: Token [submission:access-token] should exist
• | #xx | 0c703a8 | Issue #2477595 by DanChadwick: Error posted to error log with wrong module name.
• | #xx | 9dbd7c3 | Issue #2474455 by DanChadwick: Fix regression with 12-hour time.
• | #xx | 77b2558 | Issue #2477735: Confidential submissions (aka Webform Anonymous).
• | #xx | e75e6cb | Issue #2474455 by DanChadwick: Fixed End time typo and problems with specifying or defaulting an end time.
• | #xx | 16f6459 | Issue #2478211: PHP Notice when conditional targets component on page 2+.
• | #xx | d04cbda | Issue #2478237: Missing t() substitution in conditional error message.
• | #xx | 8d45cc9 | Issue #2478243: Conditionals fail to warn of pagebreak controlled by same page source component.
• | #xx | b80b3cb | Issue #2278177 by DanChadwick: Return to the last page when restarting a new draft.
• | #xx | 358228d | Issue #2478813: Fixed Conditional rules does not work with multiple select options component.
• | #xx | bea17a2 | Issue #1783628 by agoradesign, DanChadwick: Add html5 required attribute to webform components.
• | #xx | aa57f24 | Issue #2038933 by DanChadwick: Undefined offset: 4 in _menu_translate() (line 777 of includes/menu.inc).
• | #xx | d304685 | Issue #1331956 by DanChadwick, leendertdb: Allow blank empty_option for core -None- or -Select-.
• | #xx | 8bf96fa | Issue #2333139 by DanChadwick: 'Next submission number' doesn't update with Entity Cache.
• | #xx | 5decac7 | Issue #2483251: Warning: end() expects parameter 1 to be array, null given in webform_results_export()
• | #xx | d446dd2 | Issue #2487411 by Tessa Bakker, DanChadwick: Download latest submission with no results or invalid request causes errors.
• | #xx | cb30938 | Issue #2486765: Avoid namespace conflict with webform_clear modules (hook_tokens).
• | #xx | 22a86fc | Issue #2487037 by rgristroph: Comment typo.
• | #xx | 33ee6b1 | Issue #2487748 by DanChadwick: Coder review reveals whitespace and other style imperfections.
• | #xx | e0fd8e2 | Issue #2488930 by torotil, roball, DanChadwick: Fixed interface text translatability warnings.
• | #xx | ad88042 | Issue #2491945 by Jeroen_005: Select components (list, single-select, no default) translate empty list option.
• | #xx | 85e28fe | Issue #2488930 by DanChadwick: Fixed token help should be nolabel, not no-label.
• | #xx | d28fb2c | Issue #2492629 by DanChadwick: Fixed conditional value "set to" only prints one character in tokens.
• | #xx | 835e990 | Issue #2494103 by DanChadwick: Fixed restore token use to email To and From settings for custom and select option mapping.
• | #xx | 43d7a8c | Issue #2490182 by nod_, DanChadwick, rteijeiro: Fix D8 ESLint errors (except exact equals).
• | #xx | d33fef0 | Issue #2495097 by TAT_Audaxis, DanChadwick: Added support for "required" HTML5 attribute for single checkbox.
• | #xx | ffbb66f | Issue #2498925 by sumitmadan: Typo "much" log out
• | #xx | b650577 | Issue #2503187 by fenstrat: Set webform_node_types_primary variable if webform content type is skipped on install
• | #xx | d403cd2 | Issue #2485371 by sumitmadan, DanChadwick: Added ability to disable Webform email recipients.
• | #xx | fc2e17c | Issue #2498699 by sumitmadan: A component of type Number cannot be "set to"
• | #xx | 18aa2f6 | Issue #2500705 by Chris Burge: Added data-label attribute to grid component option td elements.
• | #xx | 259e43d | Issue #2501437 by Chris Burge, DanChadwick: Views Field Handlers Should Check if Content Type is Webform Enabled.
• | #xx | 8970544 | Issue #2482659 by DanChadwick, quicksketch: Added ability to use submission tokens in markup components.
• | #xx | 5e8ab18 | Issue #2501437 by Chris Burge: Fixed Views Field Handlers permission for results link.
• | #xx | 89176dc | Issue #2510216: Tests are failing due to static caching in webform_node_types.
• | #xx | e73059f | Issue #2531842: Conditional on select with no value matches is and is-after.
• | #xx | df26971 | Issue #2530588 by agoradesign: Fixed hook_webform_submission_create function name in webform.api.php.
• | #xx | d042a7a | Issue #2528908 by DanChadwick: Webform Conditionals not showing on preview or results when testing select component with "is or is after" or "after" with numeric key.
• | #xx | 69f8ae1 | Issue #2495821 by DanChadwick: Fixed duplicate ID for file field.
• | #xx | 011af58 | Issue #2529246 by amoebanath, DanChadwick: Includes missed when loading submission, with entitycache installed.
• | #xx | 5810c01 | Issue #2532426 by DanChadwick: Conditional Set sometimes sets only first letter.
• | #xx | 3589d9c | Issue #2529246 by amoebanath: Includes missed when loading submission, with entitycache installed (revised).
• | #xx | 57c23ad | Issue #2517090 by DanChadwick: Conditionally set values should be validated.
• | #xx | 7a04143 | Issue #2532878 by dunix: Fix drush component option description and allow for using form keys in component option.
• | #xx | 5eaadea | Issue #2535066 by asct, DanChadwick: Fixed conditionals watchdog logging format incorrect.
• | #xx | 63cde39 | Issue #2533010 by rv0, DanChadwick: Support exporting with alternative line endings (e.g.: CRLF).
• | #xx | cfce42f | Issue #2535378 by DanChadwick: Fixed invalid argument in foreach in webform_format_email_address().
• | #xx | a529d53 | Issue #2536426 by DanChadwick: Position fieldset are displayed in "Select options" component edit page.
• | #xx | 3a06774 | Issue #2539954 by DanChadwick: Fixed whitespace coding standard nonconformance.
• | #xx | 4eaf1db | Issue #2541948: JavaScript webform.dateValue docblock wrong.
• | #xx | bf7d76b | Issue #2538716 by acrollet: Make original submission data available to modules implementing hook_webform_submission_update.
• | #xx | 516cf28 | Issue #2542796 by DanChadwick: Markup components on multi-page webform causes watchdog warnings.
• | #xx | 78de5a0 | Issue #2544990 by DanChadwick: Fixed PHP notices in webform_submission_create with multipage webforms.
• | #xx | d07b6f5 | Issue #284431 by bjmiller121, DanChadwick: Add option to place descriptions above fields.
• | #xx | 72826d4 | Issue #2555683 by dagmar: hook_webform_exporters and hook_webform_exporters_alter are not documented
• | #xx | 01c130d | Issue #2562703 by DanChadwick: Fixed Multistep + File Input = Duplicate Submissions.
• | #xx | 84c537e | Issue #2565063 by TAT_Audaxis: Fix fatal error when Email component is a Conditional target.
• | #xx | a9bb592 | Issue #2555119 by DanChadwick: Provide session when any submission link has passed token access.
• | #xx | eaf1436 | Issue #2568637 by DanChadwick: Fixed download of multiple select options with key of 0 shows always checked.
• | #xx | b5548f9 | Issue #2573523 by DanChadwick: Added allowing numbers starting or ending with a decimal.
• | #xx | e1c7ba3 | Issue #2573523 by DanChadwick: Added number validation reg ex comments.
• | #xx | e3867fd | Issue #2566017 by DanChadwick: Fixed wfx range-type='new' doesn't set last-downloaded sid.
• | #xx | ccab609 | Issue #2574577 by DanChadwick: Fixed no results behavior not triggered for in views of webform fields.
• | #xx | e985d25 | Issue #2563467 by DanChadwick: Fixed cannot clear a large number of submissions.
• | #xx | 581381f | Issue #2575875 by DanChadwick: Added drush command webform-clear to clear submissions.
• | #xx | 80403c1 | Issue #2575901 by DanChadwick: Fixed conditional definition validation incorrect.
• | #xx | 80dc628 | Issue #2575903 by DanChadwick: Fixed conditional form shows set-to operand when it shouldn't.
• | #xx | bbf6443 | Issue #2555853 by DanChadwick: Added warning that component must be Required if required is conditionally set.
• | #xx | 733ea82 | Issue #2560339 by DanChadwick: Fixed webform 3.x to 4.x upgrade when views is disabled.
• | #xx | 913258a | Issue #2577649 by DanChadwick and emek: Fixed values from grid component don't get included in emails when excluding empty values.
• | #xx | c4b88fc | Issue #1133958 by DanChadwick: Added the "Field Key" column to the component table.
• | #xx | cfe0976 | Issue #2578583 by DanChadwick: Fixed conditional code cleanup (no functional change).
• | #xx | 2c3e028 | Issue #2579227: Fixed setting a conditional rule to 'is empty' breaks subsequent operators.
• | #xx | 16c950c | Issue #2574577 by DanChadwick: Fixed regression in no results behaviour not triggered for Webform Value fields in views.
• | #xx | f99e634 | Issue #2581685 by DanChadwick: Fixed component delete confirmation assumes fieldset.
• | #xx | 0687e05 | Issue #2577259 by DanChadwick: Added allow tokens to be disabled.
• | #xx | 4243541 | Issue #2555051 by DanChadwick, greggles: Added sanitize private data in webform_submitted_data.
• | #xx | b4acc12 | Issue #2580221 by amoebanath: Fixed unfiltered form display still applies conditionals.
• | #xx | bc9870e | Issue #1463364 by DanChadwick: Added option to move grid title to first row header.
• | #xx | d63e2a2 | Issue #2581891 by DanChadwick: Added advanced grid (multiple choice, conditionals, non-homogeneous options).
• | #xx | b6f06b8 | Issue #2581891 by DanChadwick: Fixed unintended byte order mark in grid.inc.
• | #xx | c6c992c | Issue #2597045 by DanChadwick: Added relax 128 character limit in Conditionals "set to" command to unlimited.
• | #xx | 91617e8 | Issue #2757751 by DanChadwick, PreviousNext: Sub-conditional and/or expressions
• | #xx | 2dbf9bc | Issue #2759623 by DanChadwick: Display required and hide weight when no components are defined.
• | #xx | cedc093 | Issue #2667102 by joelstein: Don't remove #pre_render when selection components are displayed as list.
• | #xx | 6abbb9a | Issue #2713781 by dpovshed: Fixed code whitespace style issues.
• | #xx | b504338 | Issue #2675910 by burgs: Added support for new Webform views status field formatters.
• | #xx | c4e8a81 | Issue #2677786 by hamrant, nicrodgers: Fixed _webform_client_form_add_component phpdoc missing @param documentation.
• | #xx | 70e7e54 | Issue #2677720 by nicrodgers: Fixed benign duplicate array key in webform_theme.
• | #xx | a99cd00 | Issue #2677794 by nicrodgers: Fixed documentation in phpdoc for webform_page_labels().
• | #xx | b830e14 | Issue #2677798 by nicrodgers: Fixed documentation in phpdoc for webform_input_vars_check().
• | #xx | eee42c8 | Issue #2677818 by nicrodgers: Fixed typo in phpdoc for webform_count_terminals().
• | #xx | aca0e75 | Issue #2620216 by Liam Morland: Fixed _webform_render_component(), use #theme_wrappers.
• | #xx | 967ccae | Issue #2612428 by joshi.rohit100: Fixed benign duplicated weight property in select options_source.
• | #xx | 55fb172 | Issue #2653664 by jacob.embree: Fixed implement hook_update_dependencies().
• | #xx | 336df04 | Issue #2601546 by BR0kEN: Added improvement to e-mail "exclude_empty" processing.
• | #xx | d2a4e82 | Issue #2752611 by benjy: Fixed webform_results_download_rows() should take $last_sid by reference.
• | #xx | 4ff43db | Issue #2784329 by DanChadwick: Fixed defining conditionals with multiple actions.
• | #xx | fe0013a | Issue #2644830 by DanChadwick: Standardize name of field's form key to "Form key".
• | #xx | 23db027 | Issue #2784455 by Roshni Patel, 3rik5: Fixed description displays between field prefix and input for number/text components when above.
• | #xx | 9133a14 | Issue #2678704 by DanChadwick: Fixed description of disabled components to allow for change via JavaScript or dev tools.
• | #xx | d534392 | Issue #2788591: Added warning about opening CSV files with spreadsheets.
• | #xx | ec32e33 | Issue #2612844 by tom_ek, DanChadwick: Fixed non-required partial dates fail validation with no value entered.
• | #xx | 0a4658c | Issue #2768023 by kanei, DanChadwick: Fixed allow #element_validate and select options_callback to be a php callables rather than function names.
• | #xx | ed20639 | Issue #2627874 by Rade, DanChadwick: Fixed space used as thousands separator produces validation error.
• | #xx | e7a891c | Issue #2788981 by Liam Morland: Fixed documentation for _webform_submission_serial_next_value_used.
• | #xx | e71106f | Issue #2786933 by grahamC: Fixed conditionals lost during update from 3.x.
• | #xx | 388a741 | Issue #2733427 by anrikun: Fixed PHP warning: min(): Array must contain at least one element in webform_expand_grid.
• | #xx | e2a8342 | Issue #2673050 by FeyP: Fixed refresh entitycache after changing email status on email overview page.
• | #xx | 78277fd | Issue #2690815 by guilopes: Fixed integrity constraint violation when trying to save conditionals via features.
• | #xx | efc082c | Issue #2661718 by Nicolaj, DanChadwick: Fixed no server side validation of required grid components.
• | #xx | 4a287a5 | Issue #2614384 by ben.bunk: Added let Drupal determine enctype of a form.
• | #xx | 52c4fc7 | Issue #2688621 by joelstein: Added hide additional extensions field on file component if no access via form_alter.
• | #xx | 6382658 | Issue #2712611 by grahamC: Fixed re-parented components deleted with old parent.

Update readme to reflect what version of webform was ported

As far as I can tell it's 7.x-4.4 based on the subsequent commit log for issue 2447745. There have been a lot of commits since then--they've been busy fixing bugs!--so it would also be good to track the Drupal changes and merge them in

Webform commits from 7.x-3.24 to 3.25

There are two of them, one of which is a security-related one:

https://www.drupal.org/project/webform/releases/7.x-3.25

Issue #2600316 by torotil: Partially backport webform_get_submissions() refactoring [view commit]
Issue #2035329 by jweowu: Explicitly deny access to uploaded private files, if not permitting access. [view commit]

The security commit changes seem to be in our latest 1.x-1.x (can't see a commit or PR for it though ??), so PR for the other issue upcoming...

$form_state key 'complete_form' changed to include underscore

https://www.drupal.org/node/1235918. This was inherited by Backdrop, but still there in Webform.
Pushing change now.

Remove views when uninstalling