Similar to the implementations for Date, Time, DateTime.

I've been trying to figure out how to use your library for parsing iso:8601 duration and attach it to the standard Time or Chrono library. Do you have an example of such or other similar usages? All I get is the Duration enum with values, but cannot do anything else with it. Sorry, if this sounds too silly.

What do you think about exceeding the values range in a duration like: 'P90D' for 90 days.

As stated here

The standard does not prohibit date and time values in a duration representation from exceeding their "carry over points" except as noted below. Thus, "PT36H" could be used as well as "P1DT12H" for representing the same duration. But keep in mind that "PT36H" is not the same as "P1DT12H" when switching from or to Daylight saving time.

I know that you stated here

I'd be fine with picking reasonable values here (e.g. not more digits than it makes sense for the unit, that is 2 digits (range 0-60) for minutes, ...).

... to explicitly not allow exceeding values, but you can maybe add a new function e.g.: 'duration_allow_exceed(string: &str)'!?

turns out that my latest PR applying higher level parsers actually had a ~15% performance impact.
sorry about that 😢

When using iso8601 to parse dates in addition to more input, it is quite annoying that the leftover input is thrown away here.
It doesn't have to return the nom IResult, but would you mind if the library offers variants of iso8601::{date,time,datetime} that return a (leftover_input, result) tuple in the Ok case?

I've been spending entirely too much time playing with libfuzzer recently, and this crate was one of my victims.

It pretty quickly found src/helper.rs:10 – as you can imagine, as soon as you write unwrap anywhere, it'll come back to bite fuzz you ;)

• called Result::unwrap() on an Err value: ParseIntError { kind: Empty }
  with input b"164800."
• called Result::unwrap() on an Err value: ParseIntError { kind: Overflow }'
  with input b"04:05:06.1226001015632)*450"

See https://gist.github.com/killercup/8dd9ca721fc29cca5b4c8db51bba75b2 for full logs

cf. rust-fuzz/targets#59

Hello,

I've encountered the scenario where duration format for seconds is presented as follows

"PT1420.061S" which would correspond to seconds and fractional seconds (ms). It appears that when I pass this value to your library, I'm getting a 0 value across all fields, which I would assume is the default.

{
    year: 0,
    month: 0,
    day: 0,
    hour: 0,
    minute: 0,
    second: 0,
    millisecond: 0,
}

Is there is something I need to do here?

Thank you

according to RFC3339 page 13 a duration is described as follows

   dur-second        = 1*DIGIT "S"
   dur-minute        = 1*DIGIT "M" [dur-second]
   dur-hour          = 1*DIGIT "H" [dur-minute]
   dur-time          = "T" (dur-hour / dur-minute / dur-second)
   dur-day           = 1*DIGIT "D"
   dur-week          = 1*DIGIT "W"
   dur-month         = 1*DIGIT "M" [dur-day]
   dur-year          = 1*DIGIT "Y" [dur-month]
   dur-date          = (dur-day / dur-month / dur-year) [dur-time]

   duration          = "P" (dur-date / dur-time / dur-week)

hence a duration of 15min should be validly represent ad both PT15M and PT900S
currently PT900S would however fail to parse.

This issue was automatically generated. Feel free to close without ceremony if
you do not agree with re-licensing or if it is not possible for other reasons.
Respond to @cmr with any questions or concerns, or pop over to
#rust-offtopic on IRC to discuss.

You're receiving this because someone (perhaps the project maintainer)
published a crates.io package with the license as "MIT" xor "Apache-2.0" and
the repository field pointing here.

TL;DR the Rust ecosystem is largely Apache-2.0. Being available under that
license is good for interoperation. The MIT license as an add-on can be nice
for GPLv2 projects to use your code.

Why?

The MIT license requires reproducing countless copies of the same copyright
header with different names in the copyright field, for every MIT library in
use. The Apache license does not have this drawback. However, this is not the
primary motivation for me creating these issues. The Apache license also has
protections from patent trolls and an explicit contribution licensing clause.
However, the Apache license is incompatible with GPLv2. This is why Rust is
dual-licensed as MIT/Apache (the "primary" license being Apache, MIT only for
GPLv2 compat), and doing so would be wise for this project. This also makes
this crate suitable for inclusion and unrestricted sharing in the Rust
standard distribution and other projects using dual MIT/Apache, such as my
personal ulterior motive, the Robigalia project.

Some ask, "Does this really apply to binary redistributions? Does MIT really
require reproducing the whole thing?" I'm not a lawyer, and I can't give legal
advice, but some Google Android apps include open source attributions using
this interpretation. Others also agree with
it.
But, again, the copyright notice redistribution is not the primary motivation
for the dual-licensing. It's stronger protections to licensees and better
interoperation with the wider Rust ecosystem.

How?

To do this, get explicit approval from each contributor of copyrightable work
(as not all contributions qualify for copyright) and then add the following to
your README:

## License

Licensed under either of
 * Apache License, Version 2.0 ([LICENSE-APACHE](LICENSE-APACHE) or http://www.apache.org/licenses/LICENSE-2.0)
 * MIT license ([LICENSE-MIT](LICENSE-MIT) or http://opensource.org/licenses/MIT)
at your option.

### Contribution

Unless you explicitly state otherwise, any contribution intentionally submitted
for inclusion in the work by you, as defined in the Apache-2.0 license, shall be dual licensed as above, without any
additional terms or conditions.

and in your license headers, use the following boilerplate (based on that used in Rust):

// Copyright (c) 2016 iso8601 developers
//
// Licensed under the Apache License, Version 2.0
// <LICENSE-APACHE or http://www.apache.org/licenses/LICENSE-2.0> or the MIT
// license <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. All files in the project carrying such notice may not be copied,
// modified, or distributed except according to those terms.

Be sure to add the relevant LICENSE-{MIT,APACHE} files. You can copy these
from the Rust repo for a plain-text
version.

And don't forget to update the license metadata in your Cargo.toml to:

license = "MIT/Apache-2.0"

I'll be going through projects which agree to be relicensed and have approval
by the necessary contributors and doing this changes, so feel free to leave
the heavy lifting to me!

Contributor checkoff

To agree to relicensing, comment with :

I license past and future contributions under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option

Or, if you're a contributor, you can check the box in this repo next to your
name. My scripts will pick this exact phrase up and check your checkbox, but
I'll come through and manually review this issue later as well.

• @badboy
• @hoodie
• @homu

Would adding support for ISO 8601 durations be desirable for this crate? I was looking for a parser for them and thought it would make sense for this crate to support them.

I'd be happy to give implementing them a go myself if there aren't any objections. 🙂

Just stumbled upon this:

Spent a while tracking this issue down in my own code before I started suspecting my dependencies :)

I stumbled upon https://ijmacd.github.io/rfc3339-iso8601/
I never actually read the iso8601 standard (for one because it's not freely available), so technically we're definitely not iso8601-compliant.
Might be worth looking into whether we parse data from the test file.

e.g. I'm pretty sure we don't correctly handle leading T like T10:47:21+01. Nor do we allow lowercase t.

I'm not entirely sure how this would be done using nom so I thought I would ask.

• impl Display for {Date, Time, DateTime}
• write a 'read write read' fuzzer

ISO 8601 prefers using minus sign (U+2212 MINUS SIGN, −) to represent a negative offset according to Wikipedia. Hyphen minus is also allowed (U+002D HYPHEN-MINUS, -). But it seems that the parser only accepts hyphen minus.