baku89 / glisp

Glisp is a Lisp-based design tool that combines generative approaches with traditional design methods, empowering artists to discover new forms of expression.

Baku Hashiomoto 橋本 麦

glisp's Issues

Support for partial update of parameters in :drag and :inverse

By reference to @nariakiiwatani's tweet
https://twitter.com/nariakiiwatani/status/1281937067040112640

`reverse` works destructively

function reverse modifies original array since it calls Javascript's destructive reverse.
I don't know if it's Intentional behavior or not, I think it's not Lisp-ish.

reproducible code;

(def array [0 1 2])
(reverse array)
(prn array) ;; [2 1 0]

commit:cfae966 broken on firefox

does not load (window is empty) on firefox 78.0.2 (64-bit) on windows 10.

in console,

I have a question of syntax

I'd like to use loop in glisp.
Is loop currently available in glisp?

#@{:expanded true} showing off on layer expansion

Description

#@{:expanded true} tag is showing off in the code window next to the code targeted within the layer window and is happening on layer expansion.

Screenshot

Steps to reproduce

The issue was also reproduced with Safari, but the main environment was Brave : Version 1.46.144 Chromium: 108.0.5359.128 (Official Build) (arm64)

1. Open glisp
2. Select any code example
3. In the Layers window, select any layer and click on the left arrow associated to trigger expansion
4. In the Code window, the code is well highlighted but the #@{:expanded true} tag is showing off

More

I found this really great tool because of mal, thank you ! 💯

Some special form does not set the evaluated value for all of parameters properly

Just as the title says.

In Glisp implementation, every AST stores its evaluated value with the key Symbol.for('eval').
This is useful to improve the GUI binding in some cases, but some special forms just like if and do seem not to store the evaluated values properly.

Use JS Map for a hashmap primitive in Lisp implementation

For the performance and code readibility. ES6 implementation of MAL would be helpful.

paste-from-clipboard won't work on Firefox

Error message:

useAppCommands/<@webpack-internal:///./src/components/PageIndex/use-app-commands.ts:195:9
evalExp@webpack-internal:///./src/mal/eval.ts:424:37
eval@webpack-internal:///./src/mal/scope.ts:124:20
readEval@webpack-internal:///./src/mal/scope.ts:107:20
REP@webpack-internal:///./src/mal/scope.ts:100:21
handler@webpack-internal:///./node_modules/cache-loader/dist/cjs.js?!./node_modules/ts-loader/index.js?!./node_modules/cache-loader/dist/cjs.js?!./node_modules/vue-loader/lib/index.js?!./src/components/Console.vue?vue&type=script&lang=ts&:68:21
JQConsole</JQConsole.prototype._HandleEnter/continuation</<@webpack-internal:///./node_modules/jq-console/jqconsole.min.js:1:22879
JQConsole</JQConsole.prototype._HandleEnter@webpack-internal:///./node_modules/jq-console/jqconsole.min.js:1:23107
JQConsole</JQConsole.prototype._HandleKey@webpack-internal:///./node_modules/jq-console/jqconsole.min.js:1:20827
bind/<@webpack-internal:///./node_modules/jq-console/jqconsole.min.js:1:586
dispatch@webpack-internal:///./node_modules/jquery/dist/jquery.js:5428:16
add/elemData.handle@webpack-internal:///./node_modules/jquery/dist/jquery.js:5233:6

glisp with embedded elements

Hi all! I would like to know if it is possible to create an interface of inline elements in the glisp.

Idea

This is a curious question and not an implementation request, I don't know how to program and this would just be a concept, idea.

So... would it be possible to create a glisp with embedded elements?

docs: `Open in Editor` is not working.

When I click on "open in editor", it takes me to a page like this link.

example:

• https://glisp.app/docs/#/en/get-started?id=draw-a-circle
• Open in Editor: https://glisp.app/stable/?code=%28circle+%5B50+50%5D+40%29

clicked

It is probably expected to go to the glisp editor screen, but currently it is not possible.

`eval*` doesn't work properly in some cases

https://glisp.app/commit:69e6023/?code_url=https%3A%2F%2Fgist.githubusercontent.com%2Fmicuat%2Fa267b81b207787cc5aaed6a7656d3c86%2Fraw%2F07698838c485e05cf236ed3b312db2768edae342%2Fclampbug.glisp

this doesn't work

(background "aliceblue")

(defvar x 100)
(defvar m0 0)
(defvar m1 100)
(transform (translate [(clamp x m0 m1) 74.29997253417969])
  (circle [0 0] 100)
)

this works

(background "aliceblue")

(defvar x 100)
(defvar m0 0)
(defvar m1 100)
(circle [(clamp x m0 m1) 74.29997253417969] 100)

it used to work - and currently broken on both master and develop branches

Translation links in docs navbar broken

現行のドキュメントのナビゲーションバー，Translationの部分のリンクの挙動は以下のように壊れています．

• 🇺🇸 Englishをクリックする
  • https://glisp.app/docs/#/en/ -> https://glisp.app/docs/#/en/en/ -> https://glisp.app/docs/#/en/en/en/
• 🇯🇵 日本語はクリックすることが出来ません

Docsifyには詳しくないので憶測ですが，https://docsify.now.sh/custom-navbar を参照するに以下のように修正すると良いのではないでしょうか．

https://github.com/baku89/glisp/blob/master/docs/_navbar.md

- Translations
  - [🇺🇸 English](/en/)
  - [🇯🇵 日本語](/)

undo behavior for text

(text "abc" [0 0] :size 100 ) ; (1)

when the text "abc" is changed

(text "def" [0 0] :size 100 ) ; (2)

then move the text with the handle

(text "def" [64.3184 -204.2108] :size 100 ) ; (3)

rolls back to the first state (1) but (for the user's perspective) the expected behavior is to go back to (2) I think

A missing package when installing with yarn install

After git cloning this glisp repo and running 'yarn install' i get:

error An unexpected error occurred: "https://registry.npm.taobao.org/request-promise-core/download/request-promise-activePen-1.1.3.tgz?cache=0&sync_timestamp=1572807117693&other_urls=https%3A%2F%2Fregistry.npm.taobao.org%2Frequest-promise-core%2Fdownload%2Frequest-promise-core-1.1.3.tgz: Request failed "404 Not Found"".

Export dialog won't work

Just as the title says.

Country flags don't show up in README.md on Chrome Win10

Chrome Version 97.0.4692.71 (Official Build) (64-bit)

Unfortunately, it seems these flag emojis don't show up on Chrome Win 10 even on other websites.
You may want to consider using en-US and ja-JP instead for instance.

getting started typo

https://github.com/baku89/glisp/blame/master/docs/get-started.md#L11

I first thought 左上 is correct, but anyways the origin is at the center and +x is right, +y is down. I don't know what is a good way to describe this.

for example, doc in p5.js says

(0,0) can be found at the top left with the positive direction to the right horizontally and down vertically.
-- https://p5js.org/learn/coordinate-system-and-shapes.html

so I will rephrase that (origin at center) in the english doc

code of conduct

it would be nice to add one at some point.

examples

• https://github.com/processing/p5.js/blob/main/CODE_OF_CONDUCT.md
• https://github.com/openframeworks/openFrameworks/blob/patch-release/CODE_OF_CONDUCT.md

rect bug when parameters are clamped

https://glisp.app/commit:69e6023/?code_url=https%3A%2F%2Fgist.githubusercontent.com%2Fmicuat%2Ff8b1e0001efcf2115bca90dcbee93979%2Fraw%2F9d24021efc890dc514710bd0805c32cca9d69384%2Fclamprectbug.glisp

(defvar vx 100)
(defvar vy -55.20002746582031)

(def W 100)
(def H 100)
(background "aliceblue")

(style (stroke "salmon" 2)
	(rect [(clamp vx (- W) W) (clamp vy (- H) H) 341.5 279.00096130371094]))

in this case, when x y are bound by clamp, width and height still moves in an unexpected way (I guess it's trying to compensate values somehow)

Docs typo 1

https://github.com/baku89/glisp/blob/master/docs/why-lisp.md#L124 (https://glisp.app/docs/#/why-lisp)

"異常" -> "以上" ?

Display the recommended environment for mobile and non-Chrome browsers and fallback to project description page

Just as the title says.

#10

Publish to Gist failed before adding any changes to code

コードの編集をせずにPublish to Gistをした際、codeが空文字列になっていてgist APIがエラーを返します。

Gist API returns error when tried publish-gist without adding any changes to code.

VM8:1 POST https://api.github.com/gists 422 (Unprocessable Entity)
(anonymous)	@	VM8:1
eval	@	console.ts?4e39:194
eval	@	tslib.es6.js?9ab4:74
__awaiter	@	tslib.es6.js?9ab4:70
publishToGist	@	console.ts?4e39:183
eval	@	console.ts?4e39:221
evalExp	@	eval.ts?f834:573
eval	@	scope.ts?f0c7:134
readEval	@	scope.ts?f0c7:116
REP	@	scope.ts?f0c7:108
handler	@	Console.vue?d189:70
eval	@	jqconsole.min.js?b832:1
JQConsole._HandleEnter	@	jqconsole.min.js?b832:1
JQConsole._HandleKey	@	jqconsole.min.js?b832:1
eval	@	jqconsole.min.js?b832:1
dispatch	@	jquery.js?1157:5429
elemData.handle	@	jquery.js?1157:5233

glisp/src/scopes/console.ts

Line 157 in 4b9296a

const code = ConsoleScope.var('*sketch*') as string