Comments (5)
So we do some basic format checking already (though without feedback). I check if it starts with either 0x and is exactly 42 characters long or starts with ENS and is at least 4 characters long. Will need to discuss what options we have for better validation and how you want to present it to the user. For now I'll hold off on this.
from old-balance-ios.
Make a request and check if that address has tokens? spinner while network request is performed and not enable button until comes back (bonus point if we pre-save that info so user don't need to wait again)
from old-balance-ios.
yeah exactly what I was thinking (I meant to paste in my commend from Discord). We need to load the data anyway so we could load it first.
from old-balance-ios.
My discord comment:
From what I found searching it seems like we only have three options:
-
use a simple regex to verify it is a possible address, but not necessarily an actual address
-
use the upper/lowercase format for addresses that includes essentially a built in checksum (but that's not great because many addresses aren't formatted that way)
-
use an API to see if the eth wallet exists on the network (ok for our use case since we aren't sending eth so wallets will always be pre-existing, but not sure if we want to rely on another 3rd party API, though maybe we could use the existing ethporer or other eth api we get the wallet details for that, i.e. if the api returns the wallet has nothing, don't add it or something)
I'm thinking 3 is the way to go as @wolffan suggested.
from old-balance-ios.
For now, handled by #61
from old-balance-ios.
Related Issues (20)
- 💧 Hide Empty/Liquidated Maker Loans
- 🥇 Auto-rank wallets by balance
- App Crashing on Load HOT 2
- 📈 Display UMA USStocks Token Clearly
- ⚠️ Don't ask for notifications on startup
- ☠️ FIRST LAUNCH FAIL: Silently spinner of death HOT 6
- ⬇️ White space when there are no "Other balances" HOT 2
- 💯 Overflowing tokens for quadrillions HOT 2
- Check language formatting on numbers HOT 1
- Loopring tokens are missing
- ⚠️ DAI Balance not showing
- 🏹 Check BAL vs Balance Token HOT 1
- Decimals for IOTA 💩
- 👀 Overlapping cell expansion button
- ⚠️ Memory use is waaaaay too high HOT 1
- 🧮 Calculate and Show Total Balance HOT 1
- Change Maker CDP view to a new view HOT 1
- Change ERC-20 rows to cells and restructure tableview HOT 1
- Strip wallet out of clipboard
- Track wallet allowances
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from old-balance-ios.