balance-io / old-balance-ios

Balance in Swift

Balance for iOS - An interface for the open source financial system

Community

TestFlight: https://testflight.apple.com/join/02cARQQL

Discord Chat: https://discord.gg/xCtf2wN

Twitter: http://twitter.com/balance_io

Getting Started

1. Download XCode: https://developer.apple.com/xcode/
2. Install Cocoapods: https://cocoapods.org/
3. Run pod install

Contributing

The biggest 3 issues are pinned to the top: https://github.com/balance-io/balance-ios/issues

The best issues to start with are here: https://github.com/balance-io/balance-ios/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22

Master - Release versions for Apple

Develop - Working version of the app

Branches - Features being worked on

Designs

Figma: https://www.figma.com/file/bJROupXp1iGJaqGIr0cmqGVk/balance-watchlist?node-id=0%3A1

old-balance-ios's Issues

💰 Account for PETH in the formula

Currently the PETH rate is not accounted for. See example and fix below.

Here is how I think it should be:

from web3.auto import w3
from pymaker import Address
from pymaker.sai import Tub

tub = Tub(web3=w3, address=Address('0x448a5065aebb8e423f0896e6c5d525c040f59af3'))
cup = tub.cups(3228)

tag = tub.tag()  # peth/usd
per = tub.per()  # eth/peth
mat = tub.mat()  # liquidation ratio

ink = cup.ink  # collateral in peth
eth = tag * per  # collateral in eth
usd = cup.ink * tag  # collateral in usd
art = cup.art  # drawn dai

price = tag / per  # eth price in usd
rekt = (cup.art * mat)  / (cup.ink * per)  # liquidation price in usd
col = cup.ink * tag / cup.art * 100  # collateralization percent

Reference data:

cdp 3228
   tag 135.67
   per 1.0408678
   mat 1.5
   ink 41500
   eth 43196  # balance shows ink here
   usd 5630168.47  # balance shows 5 409 110 here
   dai 3432000
   col 164.04%
  rekt 119.17
 price 130.34

The fix:

• Multiply ETH collateral by per
• Multiply USD collateral by per

🏷 Naming a CDP

@banteg on Telegram’s suggestion.

👨‍💻 @whuttheeperson’s feedback on Maker Rocket Chat

Hey Ric,

New Balance wallet looks awesome.

A few thoughts.

• On the CDP dashboard mainscreen, before you expand the CDPs, It would be nice to know the ETH amount locked up as collateral, not just the USD.

• I'm not sure what the 'position' is referring to, it seems to be the ETH price divided by something I'm not sure what.

• When expanding the individual CDP, I'm not sure what the coloured bar below means. (Just realized it shows the 'toggle thing' at the end, to me it just looked like it was cut off, only noticed it when opening 3228's CDP)

• I'm not sure the 1.00 USD multiplying the Dai adds a lot of value for me, nor does the Eth price * Eth value with no USD output.

• It would obviously be amazing if you were able to interact with the CDPs somehow as in Draw or repay Dai, although that would be challenging as I imagine many people use hardware wallets for their larger amounts of assets to draw on.

• I noticed when you check out a CDP in danger like 3228 it shows the collateralization ratio (171%) in the top corner of the CDP on the CDP homescreen, yet doesn't list it for my CDP which isn't in danger. It would be nice if it listed them for each one.

• It would also be cool to have an ERC20 dashboard

Also checked out your podcast with Pomp today, nice job!

💻 API key onboarding in README

Not sure of the best practice here. Will let @einsteinx2 comment.

Figure out a better way to safely store api keys

Not using:

• Plist file with .gitignore: causes issues with Xcode workspace
• Cocoapods-keys: is a dead project, more complicated than it needs to be, has an outside application dependency, and has issues piling up

Going to go with this solution for now: https://medium.com/flawless-app-stories/secret-variables-in-xcode-and-your-ci-for-fun-and-profit-d387a50475d7

💧 Make the liquidation price clearer

https://twitter.com/LevDubinets/status/1102416362494844928

⏲ Nav bar goes weird

Not sure why

👁 Setting the order of assets

🌚 Dark Mode

I want to start thinking about this now.

🦄 Display Uniswap Liquidity Pools

The data could come from Graph Protocol:

https://github.com/graphprotocol/uniswap-subgraph

➕ETH total error in calculation

I am seeing 2 ETH * 133 = $15.65

That can't be right :)

🖲 Show Add Wallet Button when the address and name are filled out

I had to tap in the address field and then hit enter to see the Add wallet button.

© Popup when copy

When you tap the copy button I want some kind of feedback.

⚖️ CDP position and plaintext are missing

They are not visible in the card or popup. Guessing due to the API change on how the data gets synced.

🤳🏾 Visual feedback on QR code scan

It's so fast I barely see it happening.

📲 Pop up issues

When clicking on a cdp the window pops up with more detailed information. To close that window you must swipe the window down. I would allow swiping up to close the window an in particular I would also allow tapping somewhere outside the window to close it.

Another thing that I noticed is that when I open a window and tap above the window you should have a cdp in the background. If that cdp # is not the same as the one you’re currently looking at it will open that cdp.

Private DM on twitter.

↕️ Expandable ERC-20 cells

I have lots of worthless tokens and I want all sums under $10 to be hidden away.

Setup SwiftFormat for code formatting

It can be automatically integrated with CocoaPods and will ensure that the code stays clean without having to write a code formatting guide that no one will read

https://github.com/nicklockwood/SwiftFormat

ERC20s not displaying

Guessing this is API-related.

♻ Refresh data

💬 Add Intercom to the app

Talking to customers is important. Monzo did great work on this.

https://github.com/intercom/intercom-ios

⏳ Show loading spinner when fetching data

Just something to look at when it takes time.

🤷‍♂️ Showing WETH

When no WETH?

Add CocoaPods-Keys for safe apikey storage

Repo and instructions here: https://github.com/orta/cocoapods-keys

💰 Change art to ire

https://twitter.com/Maverickal_/status/1102346090974724100

🖲 Fix add wallet button

#19 broke it :)

The first time a CDP loads the amounts are truncated.

@banteg on https://t.me/makerdaoofficial

📊 No pricing for REP tokens

There is no price feed for my 1.4 REP.

🤳🏾 QR code should conform to EIP 67

@pedrouid said it should be “ethereum:0x276...”

Obviously copy and paste you strip the ethereum: part.

🏠 Prevent people adding more than 10 wallets

I just accidentally added the same wallet 100x and it broke the app.

Being able to monitor more wallets could be a paid upgrade.

💳 Actions Tab

Transactions

• Send & receive ERC-20
• Send & receive ETH
• Send & receive xDAi

Interactions

• Signed message
• Maker CDP wipe/draw
• Compound add/remove/earn
• Uniswap add/remove/earn

status-im/status-mobile#3050

👨‍💻 @banteg's feedback on MakerDAO Telegram

https://t.me/makerdaoofficial

even in this prototype form it's a super useful tool. all other features i can imagine fall under "nice to have" category. some of them are:

• naming a cdp
• simulating adding/removing collateral/debt. for example, i'm usually interested what would my liquidation price be if i draw some dai, sell it for eth and add it to the cdp. maybe this can be cleverly integrated in the risk indicator making it interactive.
• add eth or payback dai for someone else

🗑 Delete individual items in the watchlist

Swiping to delete could be nice. Get rid of specific CDPs.

👯‍♂️ Prevent a wallet being added twice

I added the wrong address twice by accident.

🔖 ENS Support

Add that before launching :)

➕Rounding down and up a bit much

If I have 0.14 ETH then it shows 1 ETH. Probably 2 decimal places for most things is fine.

Google keyboard bug

https://twitter.com/_tomhoward/status/1107156376613076992?s=21

Splash screen slightly off-centre on XR simulator

Haven't tested on other devices:

⛓ Consider Changing MKR.tools API over to Maker’s GraphQL API

Read the data from the source

Inconsistency between USD and $

We should represent currencies consistently, either with the currency code (USD) or symbol ($):

📊 Display Compound Returns

EthView.app took it from the chain directly

• Compound - directly from the smart contracts

https://twitter.com/ethview/status/1104860336966950913

https://www.reddit.com/r/MakerDAO/comments/azgvur/i_made_a_site_that_lets_you_track_your_eth_defi/

👀 Missing CDPs when I have multiple wallets

I see the data when I have one wallet added.

I add another wallet.

I see the new CDPs. I do not see the old ones.

I remove the new wallet.

I see the old CDPs.

◻️Grey out the add button when a name isn't present

🏚 Check if the 0x address is broken

Check the formatting and give feedback to the person.

💵Add wallet switcher menu

Now that I am using the aggregated view, I really want to slide between wallets.

Delete all does not work

I hit delete but when I refresh the app the CDPs come back.

Update README with new developer info and style rules

We should include info about how to get started with the project, dealing with keys, branch naming, CLA, etc plus some info on preferred code style to keep things consistent or the code will get messy real quick.

💵 $0 --> $0.00

Reformat any 0 number to 0. Make sure if the data is not available it is set to —.

It scares me when I see $0 and the reality is that the API has failed.

♻️ Loading spinner after adding wallets

After adding 5 wallets quickly and then heading back to Balance tab the app jammed up. Loading spinner there would be nice.

👆 Scroll issue over erc20s

When I scroll up and down the screen pauses before showing the ERC-20 section.

Ideally it is just one smooth scroll from top to bottom—no matter how much data is there.

https://www.icloud.com/photos/#0lFxEpwYcffMwWGEjhmB3WjgA