ballaerospace / cph5 Goto Github PK

cph5externs.h produces the following error:
error: a storage class can only be specified for objects and functions
#define CPH5_EXTERN extern
^~~~~~
../lib/cph5/common_externs/cph5externs.h:84:1: note: in expansion of macro 'CPH5_EXTERN'
CPH5_EXTERN class CPH5CompType;

This seems to compile without problems when I remove the extern declaration from the class definition.

Clean up all the warnings in the cph5 code base to make building easier and make sure the spurious warnings are not hiding deeper issues.

For the CPH5Dynamic class, the getH5sign and memberAdderIf methods are templated with specializations in the header file. This results in a multiple definitions warning when compiling in GCC 8.3.1.
Suggested fix: remove definitions from cph5dynamic.h and simply keep declaration in the class declaration. Then add the template and template specialization definitions in cph5dynamic.cpp.