GithubHelp home page GithubHelp logo

Comments (1)

banesullivan avatar banesullivan commented on July 28, 2024

What test is causing this issue?
What code in that test is problematic?

The issue was the test_create_tile_client_bad test where I catch specific errors when creating a TileServerThread instance. The __init__ of TileServerThread performed a fe value checks before initializing the actual Thread:

if not isinstance(port, int):
raise ValueError(f"Port must be an int, not {type(port)}")
if processes > 1 and not hasattr(os, "fork"):
logger.error("Your platform does not support forking. Failing to multithreading.")
processes = 1
threaded = True
if threaded and processes > 1:
threaded = False
threading.Thread.__init__(self)

On errors, the initialization would never happen on garbage collection the __del__ operator override would be called, calling:

if self.is_alive():

Which is what caused the error.

Is this serious?

Not at all

Can this be resolved?

Done. See associated commit

from localtileserver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.