baqs / pyatome Goto Github PK

Hi,

on Pypi you have stated your software under 'Apache Software License' which could be:

• Apache-1.0
• Apache-1.1
• Apache-2.0
• Apache-2.0-with-LLVM-exceptions

here on github.com you state it's MIT, the link to the license text is broken. Please select a unique license on all platforms.

I'd like to make an ebuild for your integration in my Gentoo Overlay for Home Assistant, so i'd need to know a proper license to publish.

PS: your requirements.txt is huge. Many of the listed libraries aren't used in the code anyway. And you should pin versions only when it's neccesary.

Thanks a lot.

\B.

It would be very helpful if you could tag releases as well. This would enable distributions who want to run your tests to fetch the package from GitHub instead of Pypi, where the tests are excluded.

Thanks

In client.py, the test
if 'PHPSESSID' not in req.cookies: raise PyAtomeError("Login error: Please check your username/password: %s ", str(req.text))
is no more usefull.
It shall be suppressed, as it triggers some errors.

I've made a project https://github.com/jugla/pyKeyAtome to clean the code and reformat it.
I've also clean the dependancy.

If you want , I will be very pleased to commit in your space.

Thanks in advance for your feed back.

NB : it comes along the improment, I suggest in HomeAssistant.