barbosshack / shmap Goto Github PK

I use get in a loop and I noticed that Shamp is leaking file descriptors.
Reproduction code is here:

use std::time::Duration;
use std::{process, thread};

use shmap::{Shmap, ShmapError};

fn main() -> Result<(), ShmapError> {
    let shmap = Shmap::new();
    println!("{}", process::id());

    shmap.insert("key", "value")?;
    loop {
        let value = shmap.get::<String>("key")?;
        println!("{:?}", value);
        thread::sleep(Duration::from_secs(10));
    }
}

You can then see fd growing with lsof -a +d /dev/shm -p <PID> | wc -l

I had a look at the code but as I'm not comfortable with ffi and mmap I didn't see a quick fix I could make a PR for.
I guess switching to OwnedFd or use a libc::close would do the trick.

And thanks for this crate which is very useful