barracudanetworks / archivestream-php Goto Github PK

If zlib.output_compression is turn on by default the zip file can't be download. I have debugged and found that the header can't be sent in send_http_headers function.

To make it works need to turn zlib.output_compression Off
Regards,
Trung

Hi,

With PHP 5.6 and above consider GMP resources are objects. So need to change int64_split function in Archive.php file to make it work with PHP 5.6+
function int64_split($value)
{
.....
if (is_object($value)){ // php 5.6 above
....
// $high = $this->gmp_convert(substr($hex, 0, 8), 16, 10);
$high = gmp_strval(gmp_init(substr($hex, 0, 8), 16), 10);
// $low = $this->gmp_convert(substr($hex, 8, 8), 16, 10);
$low = gmp_strval(gmp_init(substr($hex, 8, 8), 16), 10);
}
.....
}
I have tested on php 5.6 and php 7.0.4 and it works fine. If php 5.5 below can use the old code

Regards,
Trung.

Starting in PHP 8.1, I'm getting the following deprecation warning when creating a zip file:

Deprecated: Implicit conversion from float 1.8446744069414584E+19 to int loses precision in /tmp/test/vendor/barracudanetworks/archivestream-php/src/Archive.php on line 439

Thanks for your help.

This is a great script. I'm considering using it for our website which has millions of high-res images uploaded by users. This script would allow them to download their images without java-applets or multiple prompts. However, the download sometimes stops, and perhaps it would be possible to use the HTTP RANGE to resume downloads that have stopped midways? (given that all file sizes are given and no compression occurs).

Thanks :)

Hi JohnMaguire,

Is it possible do offline zip. I mean the library can be configured to write to a zip file Instead of streaming.

Thanks,
Trung.

Can someone help me out and tell me what is wrong with following code?
The .tar file being downloaded is only 14kb while the "files" folder contains a video of 800MB.

`<?php
include 'vendor/autoload.php';

// Create a new archive stream object (tar or zip depending on user agent)
$zip = \Barracuda\ArchiveStream\Archive::instance_by_useragent('example');

$directory = 'files';
$files = array_diff(scandir($directory), array('..', '.', '.DS_Store'));

foreach ($files as $file) {
	$fileSize = filesize($directory."/".$file);
	$filePath = $directory."/".$file;
	$zip->init_file_stream_transfer($filePath, $fileSize);
	$zip->stream_file_part($data);
	$zip->complete_file_stream();
}

// Finish the zip stream
$zip->finish();

?>`

Is it possible to gzip-compress tar output?

hi,
i have encrypted file,
while download multiple file, before add to zip i will decrypt the file. I have 3 file, i sucessfully created the zip, but only one file can be read other are corrupted
apache version 2.4
php 5.5
windows 10

foreach ($fileid as $key => $value) {
$file_info      = $this->CI->pd_files_mdl->getFileById( $value );
            $zip->init_file_stream_transfer($file_info->name, $file_info->unencrypted_size);
$stream = fopen($userStorage.'/'.$file_info->path,'r');
            if ( $file_info->encrypted == 1 ){
                while (!feof($stream)) {
                    $buffer = fread($stream, 1024 * 1024);
                    $data = $aesCipher->decrypt($buffer);
                                $zip->stream_file_part($data);
                  } 
                $zip->complete_file_stream();   
                        }
}

        $zip->finish();

The output stream isn't written to when using the default param. I originally thought it was an issue with using STDOUT in a non-CLI environment, but after implementing a similar fix to #48, I wasn't seeing any changes.

I added some of our logging into the send() method to see what's going on:

protected function send($data)
{
    if ($this->need_headers)
    {
        $this->send_http_headers();
    }

    \Log::message("Output stream is valid: " . (fstat($this->output_stream) !== false ? 'true' : 'false'));
    \Log::message("Writing " . strlen($data) . " bytes");

    $this->need_headers = false;

    do
    {
        $result = fwrite($this->output_stream, $data);
        \Log::message("Wrote $result bytes");
        $data = substr($data, $result);
        fflush($this->output_stream);
    } while ($data && $result !== false);
}

I received these logs:

Output stream is valid: true
Writing 4096 bytes
Wrote 4096 bytes
Output stream is valid: true
Writing 1084 bytes
Wrote 1084 bytes
Output stream is valid: true
Writing 452 bytes
Wrote 452 bytes

Unfortunately, the tar downloaded was 0 bytes.

I have problems with downloads of multiple files from same site.
When I try to open in browser 2 tabs (with pages from same site), that offer streaming download, I can download only from the first tab. When I switch to second tab and try to start new download there as well it dies. If I try to open any other page from same site in the seconds tab it dies as well, telling me the page is unreachable. It works just fine, if I try to visit the same page in another browser.
Repro on: Windows 10, Chrome, Edge

1. Is it not possible to download 2 files at the same time, using this lib, or is it some Windows only limitation?
2. Why is the whole site unreachable in the browser that is downloading? Is there something I'm missing?

Hi there,
i am using ArchiveStream to deliver a large amount of files (test set is ~20 files with 500mb each). However it seems to be quite slow (about 500 - 1000 kb/s transfered from the server while a static download reaches about 5-6 mb/s). I'm not a 100 percent sure but can this be a problem from ArchiveStream?

Second issue is that the download stops after some time (it seems to stop after time not after having downloaded a specific amount of bytes), mostly after about 5 minutes (which is near the php max_execution_time).

This is the code i am using:

$zip = \Barracuda\ArchiveStream\Archive::instance_by_useragent("example", array(
	"large_files_only" => true
));															
foreach($files as $singleFile) {
	$zip->add_file_from_path(basename($singleFile), get_path($singleFile));
}			
$zip->finish();

any help would be highly appreciated, thanks a lot :)

When attempting to unzip a Zip archive on OS X via Finder, the system's archive utliity will only produce a .zip.cpgz file (apparently a temporary file created during decompression). Likewise, using unzip from the command line will fail with the warning "zipfile claims to be last disk of a multi-part archive".

The reason seems to be that unzip on OS X (including El Capitan) has been compiled without Zip64 support (unzip -v output below from OS X 10.9.5):

UnZip 5.52 of 28 February 2005, by Info-ZIP.  Maintained by C. Spieler.  Send
bug reports using http://www.info-zip.org/zip-bug.html; see README for details.

Latest sources and executables are at ftp://ftp.info-zip.org/pub/infozip/ ;
see ftp://ftp.info-zip.org/pub/infozip/UnZip.html for other sites.

Compiled with gcc 4.2.1 Compatible Apple LLVM 5.0 (clang-500.0.68) for Unix on Aug 24 2013.

UnZip special compilation options:
    COPYRIGHT_CLEAN (PKZIP 0.9x unreducing method not supported)
    SET_DIR_ATTRIB
    TIMESTAMP
    USE_EF_UT_TIME
    USE_UNSHRINK (PKZIP/Zip 1.x unshrinking method supported)
    USE_DEFLATE64 (PKZIP 4.x Deflate64(tm) supported)
    VMS_TEXT_CONV
    [decryption, version 2.9 of 05 May 2000]`

Would it be possible to make the use of Zip64 optional? I can't claim to be even remotely familiar with the Zip specs, and looking at ZipArchive I was unable to figure out the necessary steps.

HI,
I have some problem, when i create a zip file in server that have php version 5.5 and 5.6, the zip file is invalid. i already test in windows 10 and centos 7.2.
This issue never happen in php version 5.4.

ArchiveStream version 1.0.4

Thank you

I have implemented ArchiveStream as part of an update system for my wordpress plugin because the name of the plugin folder varies from user to user. When uploading a .zip file created by the plugin manually to WP it installs fine however if you try to update the plugin via Wordpress' built in update API, it presents this error:

The package could not be installed. PCLZIP_ERR_BAD_FORMAT (-10) : Unable to find End of Central Dir Record signature

Recent versions of 7-Zip report an error for any zip file created with ArchiveStream.

$ 7z t example.zip 

7-Zip [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21
p7zip Version 16.02 (locale=hu_HU.UTF-8,Utf16=on,HugeFiles=on,64 bits,2 CPUs Intel(R) Xeon(R) CPU           E5640  @ 2.67GHz (206C2),ASM)

Scanning the drive for archives:
1 file, 936 bytes (1 KiB)

Testing archive: example.zip

ERRORS:
Headers Error


WARNINGS:
Headers Error

--
Path = example.zip
Type = zip
ERRORS:
Headers Error
WARNINGS:
Headers Error
Physical Size = 936
64-bit = +

    

Archives with Errors: 1

Warnings: 1

Open Errors: 1

example.zip was created using the following code:

<?php

require_once('src/Archive.php');
require_once('src/ZipArchive.php');

use Barracuda\ArchiveStream\ZipArchive;

$zip = new ZipArchive('example.zip');
$zip->add_file_from_path('LICENSE', 'LICENSE');
$zip->finish();

PHP output was simply redirected to ZIP file:

php example.php > example.zip

Older 7-Zip versions (for example 9.20) do not report any problems about the same file:

$ 7z t example.zip 

7-Zip 9.20  Copyright (c) 1999-2010 Igor Pavlov  2010-11-18
p7zip Version 9.20 (locale=hu_HU.UTF-8,Utf16=on,HugeFiles=on,2 CPUs)

Processing archive: example.zip

Testing     LICENSE

Everything is Ok

Size:       1144
Compressed: 938

Most of out clients use Windows. Some of them reported difficulties to extract our ZIP files. Recommended them to use 7-Zip, downloaded recent version (18.01) tested a file, got Headers Error.

I get a corrupt archive when using this code on macOS Sierra using PHP 7.1:

$zip = new \Barracuda\ArchiveStream\ZipArchive('foobar.zip');

$zip->add_file('hello.txt', 'This is the contents of hello.txt');

$zip->finish();

BetterZip reports the following:

Error: Can not open file as archive

Can't open as archive: 1
Files: 0
Size:       0
Compressed: 0

Dear,

I download the latest version, and run index.php in test folder but I got the error "The archive is corrupt" when open the downloaded archive with WinRar.

Thank you,
Hugo

Got an
ErrorException: Object of class GMP could not be converted to boolean in vendor/barracudanetworks/archivestream-php/src/Archive.php:455

if i want to download a zip file. Tar works fine.
Using PHP7.

Please consider adding a gzinflate() level option.

Hello,

I need to build tarballs from streams on my server (coming from HTTP requests or processes).
Do you think it would be possible to have a function that takes a stream as an argument instead of a filename, so I could do something like this:

$zip->add_stream(popen('echo foo'));

Hello,
Thanks for this great library. I am able to integrate this with a project that I am working on. The library creates downloadable zips perfectly when the entire zip file size is under 4GB. However, once the zip file size exceeds 4GB, the downloaded zip is not usable anymore. Unzip utilities complain that it is an corrupted zip.
Some more details of the issue:
Format used: Zip
No of files used : 10 (each file averaging about 500MB)
Total zip size: about 4.6 GB
Unzip utilities tried (and failed): Windows default, winzip and ALZip

Can you please let me know if I am missing something or this is a know limitation of the library.

The Archive constructor calls ob_end_clean():

I get why you do this but it causes problems with phpunit tests (because it uses output buffering to know what the tested code outputted):

Test code or tested code did not (only) close its own output buffers

Would it be possible to add an argument to not disable output buffering?

I am seeing the following notice:

Notice: Undefined property: Barracuda\ArchiveStream\ZipArchive::$need_headers in /tmp/test/vendor/barracudanetworks/archivestream-php/src/Archive.php on line 323

Looking at the code, it doesn't look like the $need_headers property is being declared.

Thanks for your help.

In this file at /vendor/barracudanetworks/archivestream-php/src/Archive.php line 409

I get;

Barracuda\ArchiveStream\Archive::int64_split(): Unable to convert variable to GMP - wrong type

Error. Downloaded zip file is corrupted and error reporting is appended to zip file (when i open with notepad i can see the error trace)

How can I overcome on this?

Perhaps there is already a way to do this, but I am trying to zip up files located on a remote server. How can I do that without having to download them first. Example:
$zip->add_file_from_path('videos/video.mp4', "https://dl.dropboxusercontent.com/1/view/jhdiuy2sdfs/somefiles/dd-4/45727_SampleVideo_1280x720_5mb.mp4", $file_opt);

Would be great if it treated that remote path just like a local one.

Undefined offset: 8 in ZipArchive.php

When I run the following:

$zip = \Barracuda\ArchiveStream\Archive::instance_by_useragent('example');

$zip->add_file('hello.txt', 'This is the contents of hello.txt');

$zip->finish();

I'm seeing an error:

Notice:  Undefined offset: 8 in /tmp/test/vendor/barracudanetworks/archivestream-php/src/ZipArchive.php on line 292

Looking at the code, it doesn't look like the $file_attribute variable is being added onto the $files array. Should that be an argument to add_to_cdr?

Thanks for your help.

Hello,

I would like to zip file from a remote server and to download from the browser but I have no idea how to acheive that. I saw the issue #34 but I can't make it work, I need to give credentials.
Would be awseome if it works.

composer install barracudanetworks/archivestream-php
vs
composer require barracudanetworks/archivestream-php

Also version 1.0.0 is missing at packagist https://packagist.org/packages/barracudanetworks/archivestream-php