basicbrogrammer / goblinshark2.0 Goto Github PK

@jcward10 and @ernbrn: first off, great job! Your work here looks good, and it sounds like you overcame some difficulties life threw in your way (moving.) All feedback is meant to be helpful and make this project even more awesome.

Law of Demeter

There's a concept in programming called the Law of Demeter, which I think can be a little overblown at times, but is in general a good principle. Please read the blog post linked above to get a good explanation not only of what it is, but why it matters.

This line from GamePlaysHelper should be changed to not break the Law of Demeter like a dry twig. You could make a method on GamePlay called next_rooms that returns all the next rooms you could go to, and already uses Room.find to return the actual rooms, not the numbers.

You call @game_plays.last all over the place. I would consider setting @last_game_play in the controller so that you don't have to do that and continue to make method chains.

---

Otherwise, good work! Feel free to close this issue after you both read it, or open new issues if you want to fix anything based off it.