bauerjj / sphinxsearch Goto Github PK

analyticsstick.json exposes information that should not be!

Hi,

I installed Vanilla and SphinxSearch (on OS X 10.8, with PHP 5.3) and they both work great. For the most part.

The problem is that it appears that SphinxSearch erroneously dismisses searches that don't start with roman characters.

I run a Persian forum, and naturally almost everything is in Persian. I've added Arabic and Persian character mappings (http://sphinxsearch.com/wiki/doku.php?id=charset_tables#arabic) to Sphinx's charset_table (in assets/sphinx.conf.tpl) and all Persian conversations have been indexed (I can verify it by running python api/test.py اپل and seeing the results).

But, when I search for a Persian phrase, or anything that doesn't start with [a-zA-Z0-9_+], the SphinxSearch plugin ignores the search.

Here's the /var/query.log when I search for "mac", "اپل" (it's "Apple" in Persian"), "mac اپل" and "اپل mac". Notice that for the second and fourth queries (that don't start with Roman characters), it only updates the "vss_stats" index, and doesn't do the actual searching. My guess (and I'll be shocked if it's not true!) is that somewhere in your giant PHP codebase (7884 lines of code!) you try to validate the searched phrase, but do it incorrectly and reject some searches.

I looked for it in your code, and the offending validator must be in class.searchmodel.php, but I couldn't find anything.

[Wed Aug 22 22:59:23.745 2012] 0.002 sec [ext2/0/rel 2354 (0,30)] [vanilla] [MainSearch]   @(title,body) mac
[Wed Aug 22 22:59:23.745 2012] 0.000 sec [ext2/0/rel 131 (0,20)] [vanilla] [RelatedMainThreads] @(title) mac
[Wed Aug 22 22:59:23.746 2012] 0.000 sec [ext2/1/rel 1 (1,20) @keywords_crc] [vss_stats] [Related Searches] @(keywords) mac


[Wed Aug 22 22:59:28.269 2012] 0.000 sec [ext2/1/rel 0 (1,20) @keywords_crc] [vss_stats] [Related Searches] @(keywords) اپل


[Wed Aug 22 22:59:39.341 2012] 0.003 sec [ext2/0/rel 6550 (0,30)] [vanilla] [MainSearch]   @(title,body) اپل | mac
[Wed Aug 22 22:59:39.342 2012] 0.000 sec [ext2/0/rel 212 (0,20)] [vanilla] [RelatedMainThreads] @(title) اپل | mac
[Wed Aug 22 22:59:39.343 2012] 0.000 sec [ext2/1/rel 0 (1,20) @keywords_crc] [vss_stats] [Related Searches] @(keywords) اپل | mac


[Wed Aug 22 23:24:44.116 2012] 0.000 sec [ext2/1/rel 0 (1,20) @keywords_crc] [vss_stats] [Related Searches] @(keywords) mac | اپل

I've posted it on vanillaforums.org as well, so people can follow the issue there as well: http://vanillaforums.org/discussion/21270/searches-only-phrases-starting-with-roman-characters

Yup, it is true

Need to have the cron task write a file to be picked up by dashboard

When running through the wizard, I enter the details for cron, and it gives me a blank screen with this in the logs:

PHP Fatal error:  Call to protected method Gdn_Validation::AddValidationField() from context 'SphinxSearchPlugin' in /var/www/xyz/vanilla/plugins/SphinxSearch/class.sphinxsearch.plugin.php on line 350

According to this:
https://vanillaforums.org/discussion/30699/howto-install-sphinx-search-on-ubuntu-14-04
it should be putting them in a non-writeable directory (which seems problematic), but even making it writeable doesn't help.

This is only true for users...Admins can view the related posts fine

Cannot declare class Widgets, because the name is already in use in plugins/SphinxSearch/widgets/class.widgets.php on line 3

https://github.com/bauerjj/SphinxSearchPlugin/blob/e741c2ce37616f1e823d5420a0ce9550b6d6d4a4/class.sphinxsearch.plugin.php#L105

https://github.com/bauerjj/SphinxSearchPlugin/blob/e741c2ce37616f1e823d5420a0ce9550b6d6d4a4/class.sphinxsearch.plugin.php#L116

https://github.com/bauerjj/SphinxSearchPlugin/blob/e741c2ce37616f1e823d5420a0ce9550b6d6d4a4/class.sphinxsearch.plugin.php#L127

In my new installation of the plugin (20190101), the DB structure for GDN_sph_stats is:

However, whenever I conduct a search, I'm encountering the following error:

PHP message: PHP Fatal error:  Field 'keywords_full' doesn't have a default value|Gdn_Database|Query|insert `GDN_sph_stats` 
(`keywords`, `mode`, `date_added`) 

My current workaround is to alter the DB structure to allow keywords_full to have NULL values.

It seems that in class.widgets.stats.php, keywords_full isn't included:

        foreach ($Words as $Word => $Info) {
            $Query.=$Word . ' ';
            Gdn::SQL()
                    ->Insert('sph_stats', array('keywords' => $Word, 'mode' => 1, 'date_added' => Gdn_Format::ToDateTime())); //mode == 1 means plain word
        }
        Gdn::SQL()
                ->Insert('sph_stats', array('keywords' => $Query, 'mode' => 2, 'date_added' => Gdn_Format::ToDateTime())); //mode == 2 means hwole query
    }

Should replace "q=xxx" with "Search=xxxx"

I'm trying to set up Sphinx search for my Vanilla forums. Right now I'm setting up a test instance of everything, and I've got Vanilla and MariaDB running in Docker containers. I have a Sphinx container too, but I want to set up the configuration as part of creating the Docker image.

I used the Installation Wizard, and I pasted my sphinx.conf file in there and pressed Save and Continue, and both the old and new conf are empty, except for "Paste Your Text Here" in both. I don't see any errors in the UI.

I've checked my config file, and it doesn't have the conf, although it does seem to be writeable as I can modify the settings of other Vanilla plugins without a problem (and enable the Sphinx Search plugin too).

Any ideas?

I tried finding the config in your repository, but I'm not a PHP developer, so I can't seem to figure out where it is, or what it should be.

I'm following the guide, i'm stuck on step 8 (https://open.vanillaforums.com/addon/sphinxsearch-plugin)
I have downloaded the .deb package not the Source tarball (tar.gz)
I'm on ubuntu 16.04 x64

Do you know whats the problem?

I have the following error:

root@vps****:~# /usr/bin/indexer --all --config /etc/sphinxsearch/sphinx.conf
Sphinx 2.2.11-id64-release (95ae9a6)
Copyright (c) 2001-2016, Andrew Aksyonoff
Copyright (c) 2008-2016, Sphinx Technologies Inc (http://sphinxsearch.com)
using config file '/etc/sphinxsearch/sphinx.conf'...
indexing index 'test1'...
ERROR: index 'test1': sql_query: Table 'vanilla5.documents' doesn't exist (DSN=mysql://root:***@localhost:3306/vanilla5).
total 0 docs, 0 bytes
total 0.002 sec, 0 bytes/sec, 0.00 docs/sec
indexing index 'test1stemmed'...
ERROR: index 'test1stemmed': sql_query: Table 'vanilla5.documents' doesn't exist (DSN=mysql://root:***@localhost:3306/vanilla5).
total 0 docs, 0 bytes
total 0.000 sec, 0 bytes/sec, 0.00 docs/sec
skipping non-plain index 'dist1'...
skipping non-plain index 'rt'...
total 0 reads, 0.000 sec, 0.0 kb/call avg, 0.0 msec/call avg
total 0 writes, 0.000 sec, 0.0 kb/call avg, 0.0 msec/call avg

I tried to get in running. I made some progress but i think Vanilla changed the default Search Handler. Is anyone using it on 2.2?

Forgot to delete line 590 in sphinxsearch.plugin.php:

$but = new myclass();

Forgot to rewrite the file after upgrading to master, derp

Either in the general search view or in the dashboard. This should make errors more apparent.

When Click "settings" after enabling the SphinxSearch plugin, I'm redirected to
Page Not Found
The page you were looking for could not be found.

Currently, only English tokenizing works correctly.

See: http://sphinxsearch.com/docs/1.10/conf-charset-table.html

When disabling the Related Threads widget for the new discussion page by setting the limit to 0, an ajax request is still sent and the text "Questions that may already have your answer: " is still displayed.

The "Posted by Member" field in the advanced search function seems to be totally ignored by the plugin. When I enter a member's user name, it has no bearing on the search results. I've tried all three search types (any, all, and extended) with no luck. If I search in extended mode using the operator @user it works perfectly.