Comments (7)
/cc @mihaimaruseac
To get Bazel working with {fmt} you can copy the files BUILD.bazel, WORKSPACE.bazel, .bazelrc, and .bazelversion from this folder (support/bazel) to the root folder of this project.
Is it possible to move those files to the root directory in the upstream repo? Otherwise, we still need a patch in the BCR.
from bazel-central-registry.
I closed this issue - just wanted to point out that I maintain https://github.com/fmtlib/fmt/blob/master/support/bazel/BUILD.bazel - if there are any changes in {fmt} I will try to adapt it
from bazel-central-registry.
{fmt} maintainers do not want to have those files in the root dir of {fmt}... unfortunately... (@vitaut we could get rid of the .bazelversion
and .bazelrc
files if you like - meaning only 2 files (WORKSPACE.bazel and and BUILD.bazel) need to be moved to the root dir - would this be acceptable for you?)
from bazel-central-registry.
it feels to me like an OSS project is only going to be willing to spend effort on the build system that they use themselves (e.g. adding some tests that prevent them from making changes that break the Bazel build)
so unless they are actually considering switching to Bazel the answer is to follow the typical pattern here and maintain the BUILD file independenty from the project.
from bazel-central-registry.
I don't think putting build configs for anything other than the main build system (which is CMake for {fmt}) in the top-level directory is a good idea. If limitations of the build system don't allow putting configs in a subdirectory then I suggest creating a separate repo and having {fmt} a submodule.
from bazel-central-registry.
I don't think this issue should have module wanted
on it - fmt
already exists in the registry; this issue is about upstreaming the bazel build files to the fmt
project.
from bazel-central-registry.
Ah, well I'm not even sure it makes sense to have issues on this repo which aren't resolvable by making changes to this repo. I think we ought to close it and you could have an issue on the fmt repo about accepting contributions, WDYT?
from bazel-central-registry.
Related Issues (20)
- wanted: p-ranav/argparse
- [Bug]: Why is there no `compatibility_level` (defaults to 0) for [email protected]? HOT 1
- wanted: meekrosoft/fff
- wanted: Yasm
- [Bug]: grpc 1.62.1 imports `googleapis` as bzlmod, but also does http_archive on it. HOT 1
- [Bug]: //tools:add_module prompts for compatibility level without explaining what that is HOT 2
- [Bug]: //tools:add_module doesn't tell me how to expose all build targets HOT 1
- [Bug]: //tools:add_module fails with netrc error
- [Bug]: rules_proto incorrectly marks rules_cc as a dev dependency HOT 1
- wanted: filament
- wanted: pzstd
- [Bug]: Many modules add `-lrt` as a linkopt, which only works on Linux HOT 1
- [Bug]: GET returned 403 Forbidden from bcr.bazel.build
- wanted: microsoft/onnxruntime
- wanted: grpc/grpc-kotlin
- wanted: [emscripten-core/emsdk] HOT 1
- [Bug]: Some source URLs return 404
- wanted: [libevent/libevent]
- wanted: google/j2cl rules and dependencies
- [Bug]: Cannot add google/osqp-cpp because osqp isn't built with `DLONG` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bazel-central-registry.