Comments (3)
jayconrod
commented on July 24, 2024
Reproduced. Thanks for reporting. Bazel is objecting to the same string appearing in two select expressions being added together.
PlatformStrings.Clean should not let a string appear in more than one select. Unfortunately in this case, it means we'll need to replace the single case for solaris with several solaris_goarch cases.
from bazel-gazelle.
kkiningh
commented on July 24, 2024
Awesome, thanks for fixing this so quickly!
from bazel-gazelle.
jayconrod
commented on July 24, 2024
@kkiningh Sure, sorry for the break.
As I hinted at in the PR title, this is regrettably not the first time I've rewritten PlatformStrings (the data structure that backs select expressions). It's been hard to get that right.
from bazel-gazelle.
Related Issues (20)
- `gazelle:default_visibility` directive does not set visibility of library HOT 6
- Modify build_naming_convention = "go_default_library" for only one external dependency package in my project
- `go_deps` does not allow multiple repos with the same path
- Execution failed bazel run //:gazelle,missing dot in first path element
- warnings on using embedsrcs in go_test HOT 4
- Bzlmod: allow build_extra_args in gazelle_override HOT 1
- gazelle() rule fail with custom gazelle_binary HOT 5
- label.Parse fails on label strings beginning '@@'
- Bzlmod: (feature request) support setting go_env like before HOT 2
- `bazel_gazelle_is_bazel_module` is not defined HOT 2
- The repository '@com_google_protobuf' could not be resolved HOT 1
- Support for Bzlmod in a monorepo HOT 7
- Build fails when importing protobuf from another package HOT 1
- `gazelle:go_test file` does not account for a test file calling a function in another, sibling test file HOT 6
- gazelle:default_visibility directive does not work properly HOT 2
- bug(bzlmod): go_deps overrides should fail with `path` that doesn't exist
- `findGoTool` uses the system Go when it should use the Go defined in the Bazel workspace
- feat(bzlmod): script to generate `go_deps.{}_override`s from `go_repository` rules in a `.bzl` file
- embedsrcs fails when downloading files with http_archive
- Bug: when the go code embedded a file that located in another package gazelle will ignore that file HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bazel-gazelle.