bbc / adhere-lib Goto Github PK

See 74f310b#r57064311

Thanks to @benburrill for the spot.

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Rate-Limited

These updates are currently rate-limited. Click on a checkbox below to force their creation now.

• Update dependency babel-loader to v8.3.0
• Update dependency @cucumber/cucumber to v10
• Update dependency ava to v6
• Update dependency babel-loader to v9
• Update dependency webpack-cli to v5
• 🔐 Create all rate-limited PRs at once 🔐

Edited/Blocked

These updates have been manually edited so Renovate will no longer make changes. To discard all commits and start over, click on a checkbox.

• Update dependency @cucumber/cucumber to v7.3.2

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency webpack to v5.76.0 [SECURITY]
• Update babel monorepo (@babel/core, @babel/eslint-parser, @babel/preset-env, @babel/register)
• Update dependency babel-plugin-istanbul to v6.1.1
• Update dependency eslint-plugin-import to v2.29.1
• Update dependency eslint-plugin-jsx-a11y to v6.8.0
• Update dependency eslint-plugin-react to v7.33.2
• Update dependency webpack-cli to v4.10.0
• Update dependency webpack-dev-server to v4.15.1
• Update dependency eslint to v8
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

If playing back on a connection that isn't particularly fast, there will be a delay before the audio sources start playing back. We should make a cue for a certain number of seconds before hand to set .preload = true on the media so that it is ready to go when it hits play.

We should also at this point investigate if we can use https://www.w3.org/TR/media-frags/

#t=10,20

To truncate how much gets downloaded when preloading - the behaviour likely depends upon the browser, but worth looking at.

See https://confluence.dev.bbc.co.uk/display/opensource/opensource+website

From bbc/Adhere#79 add clear instructions for how to embed in a page.

Sort out the sourcemap properly for the dev build. See https://webpack.js.org/configuration/devtool/#devtool

Make it possible and easy for downstreams to select which build they want.

• Check parsing works correctly
• Deal with different languages

This library has zero tests of any sort! It should have some...

Some objects are cached, e.g. in Parser.es6. Before parsing a new document we should clean everything up, probably.

The TTML2 animate element supports a fill attribute.

The default of "remove" means that at the end of the animation, the end value is reverted. In general we want the semantic associated with the alternative value, "freeze" to apply, where whatever the end value is gets retained.

For example:

        <div begin="0s" end="2.3s">
            <animate begin="0.0s" end="0.2s" tta:gain="1;0.4"/>
            <animate begin="2.1s" end="2.3s" tta:gain="0.4;1"/>

This varies the gain from 1 -> 0.4 between 0.0 and 0.2s, and then varies it from 0.4 -> 1 between 2.1s and 2.3s. But what happens between 0.2s and 2.1s? By default the gain value reverts to its default of 1, but we want to "freeze" it at 0.4 in this example:

        <div begin="0s" end="2.3s">
            <animate begin="0.0s" end="0.2s" fill="freeze" tta:gain="1;0.4"/>
            <animate begin="2.1s" end="2.3s" tta:gain="0.4;1"/>

Our current default behaviour is actually "freeze" but that's wrong - it should be "remove" according to the spec.

If two audio cues are simultaneously active, it will cause problems with the default audio output - On a leaf node becoming inactive, the default audio output will be switched on, which will work when one leaf node is active but if two are, it will play the default output when the second is still active. Instead we should maintain a list of active leaf nodes, so we only turn on the default when 0 leaves are active. This might be lower priority to fix because although overlapping audio cues are allowed, they're a bit of an edge case.

All audio-participating nodes, that is, all those in the ancestry of leaf nodes, are producing audio nodes for the graph. Nodes in the XML with no audio attributes do no change the audio, but are still producing gain nodes with a gain of 1 and pan nodes with a pan of 0. We should remove these superfluous audio nodes.