Comments (4)
@bzz @zurk I'm closing this in favor of bblfsh/sdk#257, since it's not Java-related.
from java-driver.
update: it is not correct Java code.
from java-driver.
The response looks valid to me. There are 3 statuses: OK
, Error
and Fatal
. Error
means that driver was able to process a part of the file, but there might be some syntax errors, thus the AST, in this case, might be incomplete. Fatal
on the other hand would mean that driver fail completely.
For user applications, I would suggest accepting AST only for OK
status codes because right now there is no guarantee on how complete an AST would be on Error
(it might be empty for some drivers).
from java-driver.
For user applications, I would suggest accepting AST only for OK status codes because right now there is no guarantee on how complete an AST would be on Error (it might be empty for some drivers).
@dennwc do you think it could be helpful then to document this suggestion somewhere in the official docs of the bblfsh project?
I find error reporting not very straightforward at all, and we already might have number of users of bblfsh clients, treat this situation in a different fashion.
from java-driver.
Related Issues (20)
- Keyword not supported: default HOT 2
- Java driver fails to parse big generated file HOT 2
- Support for private methods in interfaces (Java 9+)
- Code snippet generates a `java:MethodDeclaration` in semantic mode HOT 5
- semantic: string literal escape sequence handing HOT 3
- NumberLiteral doesn't return token HOT 4
- Support for modifers in method arguments
- Node position offset is not bytes HOT 6
- Native driver crashed
- I/O timeout
- Unexpected character
- Premature EOF
- Some method declarations are not converted
- Javadoc fragment are not exposed as Comments
- driver fails when trying to parse java file HOT 1
- Driver throws exception when writing response
- FailedPrecondition error on unhandled value
- Slow driver (compared with the Go one) HOT 10
- Noop role coverage
- Empty switch statements aren't supported HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from java-driver.