bblfsh / sonar-checks Goto Github PK

while implementing one of the rules in python we were using bblfsh_sonar_checks.util package. It throws following error -
root@ip-172-31-34-50:~/sourced/git/source-d/Python# python3 if_duplicate_rule.py
Traceback (most recent call last):
File "if_duplicate_rule.py", line 1, in
import bblfsh_sonar_checks.utils as utils
File "/usr/local/lib/python3.5/dist-packages/bblfsh_sonar_checks/init.py", line 1, in
from bblfsh_sonar_checks.utils import (
File "/usr/local/lib/python3.5/dist-packages/bblfsh_sonar_checks/utils.py", line 47
self.modifiers: List[str] = []
^
SyntaxError: invalid syntax

All the rules output what looks like JSON 🚀 but

python3 -m bblfsh_sonar_checks --language=java \
    | --enable=RSPEC-1143 \
    | ./bblfsh_sonar_checks/fixtures/java/RSPEC-1143.java \
    | jq '.RSPEC-1143'

results in parse error: Invalid numeric literal at line 1, column 14.

A bit confused by findings of RSPEC-1143.

$ python3 -m bblfsh_sonar_checks --language=java --enable=RSPEC-1143 ./bblfsh_sonar_checks/fixtures/java/RSPEC-1143.java

on modified .java

class ThrowInFinally {
    void test() {
        try {
        } finally {
            throw new RuntimeException();
            return;
        }
    }
    void test2() {
        throw new RuntimeException();
    }
}

report 3 findings, although according to RSPEC-1143 it seems like it should report only 2 messages for single jump statement inside finally block.

Full output in details

{'RSPEC-1143': [{'msg': "Don't throw or return inside a finally (line {})",
                 'pos': offset: 87
line: 5
col: 13
},
                {'msg': "Don't throw or return inside a finally (line {})",
                 'pos': offset: 129
line: 6
col: 13
},
                {'msg': "Don't throw or return inside a finally (line {})",
                 'pos': offset: 180
line: 10
col: 9
}]}

One can see https://pypi.org/project/bblfsh_sonar_checks/ 🎉 but it would be also supe-useful to publish on pypi as a part of release process, a newer versions e.g. https://github.com/bblfsh/sonar-checks/releases/tag/v0.2.0 of this library, that exposes

• run_check(check, lang, uast)
• list_checks(lang)

and has package description instead of The author of this package has not provided a project description with simple example of calling this API