bedrockstreaming / tornado Goto Github PK

To be able to use existing libraries returning "thenable" promises, we could add a method like

EventLoop::promiseFromThenable($thenablePromise): Promise

Up to each event loop implementation to deal with it.

❓ Should we restrict thenable promises to React PromiseInterface 🤔 ?

It's very useful to launch an async function, and don't care about it's result/promise. But it can have a tricky side-effect, since exceptions will be stuck in the promise and never be propagated anywhere…

We could ensure that a "non yielded" promise will rethrow all exceptions when rejected.
See similar feature in Amp.

Notes 🤔 :

• What about rejected promises? They shouldn't throw an exception at creation…
• How to explicitly indicates that we don't care about exceptions for a particular promise? Is it easy to try/catch all?

Currently, any exception thrown by an adapter is propagated to upper context outside of Tornado. It means that if you intend to catch a particular exception, it may be broken as soon as you change the used adapter.

Proposal:

• Catch underlying exceptions and translate them in "Tornado exceptions" (to be created)
• Use @throws annotation to document this behavior and improve developer experience with IDE

Currently, the HttpClientTest mock network calls by passing a GuzzleMockAdapter to the createHttpClient function. But this function should stay generic, and don't assume that underlying client uses Guzzle.

A better approach could be to replace this parameter by an array of Psr\Http\Message\ResponseInterface to return. Underlying concrete test will be in charge of instancing its own mock.

See similar functions in ReactPhp and Amp (Amp does not have a similar helper).
This will allow to cancel a promise if needed.

/**
* Creates a promise that will behave like the first settled input promise.
**/
public function EventLoop::promiseRace(Promise ...$promises): Promise;

• Dealing with promises
• Dealing with errors
• Creating your own promises
  …

See React\LoopInterface.
Will improve interoperability possibilities.
May require some new features, like promise cancellation, or signal handling.

Tests are ready to run: ./bin/phpunit

Give possibility to cancel a promise, to stop the job necessary to resolve this promise.
See what's possible in other libraries:

• https://reactphp.org/promise/#cancellablepromiseinterface
• https://amphp.org/amp/cancellation/

Seems needed for #12

Add this new function in EventLoop interface, implement it in each adapter, write tests

/**
* Returns a promise that will be resolved with `null` after at least $milliseconds.
**/
public function EventLoop::delay(int $milliseconds): Promise;

A good introduction page:

• What is Tornado
• How to install
• How to use it
  …

https://phpstan.org/r/0eaa8d12-2237-489a-9165-eb243d637329

As soon as release 😅

There is a test suite to ensure that all examples run well.
https://github.com/M6Web/Tornado/blob/master/examples/tests/ExamplesTest.php

But they always run with the same adapter, hard coded in the example…
It should be possible to choose the adapter, in order to run tests with all existing adapters.

Input parameter 🤔 ? On the fly modification of the script 😨?