beefoo / loc-jekyll-template

This is a boilerplate front-end template for LoC staff distributing open source code through Github Pages.

loc-jekyll-template

loc-jekyll-template's Issues

Add labs.loc.gov to exclusion list for external site css icon?

The following domains are excluded from having the external site icon in the theme css:

main a[href^="https://loc.gov"]::after,
main a[href^="https://www.loc.gov"]::after,
main a[href^="https://staff.loc.gov"]::after,
main a[href^="https://blogs.loc.gov"]::after,
main a[href^="https://libraryofcongress.github.io"]::after

For the AI Framework, many of the links point to the labs.loc.gov subdomain.
I propose adding the following to the style.css file, if you agree:

main a[href^="https://labs.loc.gov"]::after

As before, happy to do a PR for this, but wanted to make sure of the process before I do that.

Should 404 template use layout: loc?

While testing out this theme I'm hitting a lot of 404s, as is to be expected, but I noticed that the 404 page doesn't reflect the rest of the template layout.

Happy to make a PR for this small change if you agree, but wanted to check that the 404 template wasn't deliberately left otherwise.