Comments (7)
Since spots are located at fixed positions in the initial image, entering the edit mode disable all transform tools that you could have already set, so you can preview the image in its initial state. That's what the rtengine::TweakOperator has been created for. See line 866 of spot.cc for all tools forced to neutral. The last group on line 883 is for better performance, because the spot tool is already time consuming if there are numerous big spots. If new tools are added to RT, this list might have to be updated (probably the local editing tools should be disabled here).
Tone curves are not disabled IIRC, and that's perhaps why it looks over exposed. Keep in mind that spots should be removed in the beginning of your editing process to avoid this kind of problem, even with a temporary exposure compensation. There's no magic solution here I'm afraid.
from rawtherapee.
@Hombre57 - I believe it was you who led this change a few years ago, can you look. Thanks.
I confirm the bug found by @PDeb108
The operation of "Spot Removal" seems to be linked to the Raw file and the lenses used. In many cases everything works fine. In this case it does not work, or poorly, or can cause a system crash.
The problem was found during the challenge to test "lacam16n2" but it seems that this malfunction occurs whatever the branch, and probably dates back a long time
https://discuss.pixls.us/t/rawtherapee-processing-challenge/42647/66
Here the file Raw, and the pp3
https://drive.google.com/file/d/1w6sn1BQ8FQ7uSTd3quceJcyNU5K_nCCZ/view?usp=sharing
https://drive.google.com/file/d/16HVp5w3_Oas9qzEj_2KHYSpKClpzsTWK/view?usp=sharing
I've tried several changes that make it work less badly.
In Dcrop.cc and Improcoordinator.cc - better (I think) cleaning of variables (copying part of the ART code, which is very little different), but I don't think that's it
In refreshmap.h #define M_spot change from 16 to 22
I also change but it's only cosmetic the icon in Tollbar.cc
It seems that: crop, Lens profile, Input profile have a strong impact.
It seems also that : Haze removal and Graduated Filter have an impact.
I try to disable all "expanders" without real effect.
It works only with "neutral".
I used as a basis the current work of the "cbdlciecam" #7017 branch because as @PDeb108 uses Ciecam and certain functions which created artifacts, I preferred to start from a healthier base to eliminate possibilities (it seems that Ciecam16, Wavelets or LA are not involved... to check)
This looks like a pipeline problem, plus this type of process is not in my area of expertise
I create a new branch "spot_cbdlciecam"
Jacques
from rawtherapee.
Thank you for the explanation.
I think you are true (of course, because you know the tool for having designed it). "Keep in mind that spots should be removed in the beginning of your editing process"
I think to improve the operation we should add to Spot.cc (tweaksparams)
- pparams.locallab= LocallabParams();
- pparams.toneCurve = ToneCurveParams();
And
pparams.locallab.enabled = false;
pparams.toneCurve.hrenabled = false;
pparams.toneCurve.histmatching = false;
pparams.toneCurve.expcomp = 0.;
and perhaps others parameters.
What do you think ? and who does it?
Jacques
from rawtherapee.
Thank you for the explanation. As a user, I don't understand the technicalities you have mentioned, however, I gather, that spot-removal is a resource-intensive process and should be done before doing anything else, much like setting the white balance first. Doing it later might even cause crashes. I am yet to try it on any photos as yet. will give you a feedback
Might I suggest that the module be moved from the detail group to the exposure group to focus on the need to use it early in the work process
from rawtherapee.
@Desmis I've not installed any IDE since I changed laptop, so could you please do that change ? I wouldn't reset ToneCurveParams();
though, nor force pparams.toneCurve.expcomp
to 0, because it's the only remaining way to change the exposure to better see spots.
So the patch would look like :
pparams.locallab.enabled = false;
pparams.toneCurve.hrenabled = false; // not sure for this one, it could be useful for ExpComp w/o performance penalty
pparams.toneCurve.histmatching = false;
No need to reset the entire LocallabParams();
if you have an enabled
parameter that can do the job.
@PDeb108 Tools are sorted into tabs depending on their functionality, and tabs are organized (somewhat) by their usage count. That's why RAW is almost the last tab while being the first thing happening in the process pipeline. So I think Spot is in the right tab.
from rawtherapee.
That is perfectly logical. Thanks for the input. BTW, although I created the issue, I am not sure whether it should be closed by me or not. Someone more knowledgeable may update the status. Thank You
from rawtherapee.
Closing because the behavior is expected.
from rawtherapee.
Related Issues (20)
- History is getting spammed when Color Appearance & Lighting module is enabled Build 5.10-190 on dev branch. HOT 8
- A gamma shift issue/color change after saving to jpg HOT 1
- No DateTime (= editing date) in EXIF data of exported photo
- Please support Rust-free `librsvg` HOT 4
- Resulting JPG file is locked after Save As, Linux build 5.10-194 HOT 6
- JPG Export best-quality really chroma subsampling 4:4:4 ? HOT 1
- Film Negative - Improper assumption of mapping between raw values and transmission coefficient HOT 11
- RawTherapee 5.10 not responsive after start HOT 4
- Am I misunderstanding TP_LOCALLAB_AVOIDCOLORSHIFT_TOOLTIP? HOT 3
- Feature request: export pictures in HEIF 10bit HOT 1
- The GUI doesn't open on first install (Windows). HOT 1
- Wavelets - malfunction for the “selective range” part HOT 1
- Program resources not loaded when installed in directory with special characters HOT 7
- Build fails with libjpeg-turbo 3.0.3: Undefined symbols for architecture x86_64: "_jpeg_std_message_table" HOT 12
- Sony ILCE-6700 has invalid pixels on the right border HOT 1
- Chinese (Simplified) translation (intended for) Rawtherapee 5.8 (or 5.9?) HOT 1
- Please consider implementing a better way to preview and scroll through presets HOT 1
- Update GUI in Japanese HOT 1
- Add/Edit Exif not possible, if Exif data is not available in photo HOT 2
- Assertion '__n < this->size()' failed. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rawtherapee.