GithubHelp home page GithubHelp logo

Comments (4)

stof avatar stof commented on May 26, 2024

The step type is purely indicative. It does not impact the matching at all.

And changing that would be a BC break so it cannot be done in Behat 3.x.
Note that the step type is also indicative in Cucumber, so the existing behavior is consistent.

from behat.

uuf6429 avatar uuf6429 commented on May 26, 2024

Thanks for the reply!

From what you say, I think the only course of action is to relax the duplicate/ambiguous step check in cases where the annotations/attributes apply to the exact same step (and in which case it wouldn't be a BC break). Wdyt?

Maybe a naive way of doing it is to run array_unique when extracting all Given/Then/When annotations/attributes patterns of a given step method.

If I get some time, I'll see if I can make this happen.

from behat.

stof avatar stof commented on May 26, 2024

Well, there is strictly no benefit of adding it multiple times on the same method

from behat.

uuf6429 avatar uuf6429 commented on May 26, 2024

Well, there is strictly no benefit of adding it multiple times on the same method

That is true...in the short term at least.

In my opinion, I still don't like the ambiguity and I would rather have an @Step (if they are all treated equally) or be more strict about Given/When/Then.

The way I see it, there are two ideal cases (as already mentioned) and a middle-ground (which is where we're at), and unfortunately, even that middle-ground is not implemented as expected due to the aforementioned uniqueness problem.

from behat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.