belak / emacs-monokai-pro-theme Goto Github PK

Hi,

is there any chance that you will add all the different monokai pro flavors (Octagon, Ristretto, Spectrum, Machine, Classic) to the theme?

If you prefer, I can also add a PR for it.

I am using Emacs 28.2, with monokai-pro-classic.

When I run M-x customize, the "search" field has a white background, and the search text is invisible (white on white).

A screenshot: https://i.imgur.com/VzFnZSw.png

I use an after-load-theme-hook to set/alter some extra faces that monokai doesn't define, however it is quite difficult to use the palette that monokai defines in a nice manner, at least compared to the same customizations made to zenburn, e.g.:

(defun customize-zenburn ()
    "Customize zenburn theme"
    (if (member 'zenburn custom-enabled-themes)
        (zenburn-with-color-variables
          (custom-theme-set-faces
           'zenburn
           `(show-paren-match ((t (:background ,zenburn-bg+05 :weight bold))))
           ))))
  (add-hook 'after-load-theme-hook 'customize-zenburn)

Note that the zenburn colors names are made available via the zenburn-with-color-variables macro https://github.com/bbatsov/zenburn-emacs/blob/af63b09069d731f46c0ba38f2f578162e2dcb0d5/zenburn-theme.el#L156-L167 (and it also lets the user set zenburn-override-colors-alist if they want to adjust some of the colors)

(defun customize-monokai ()
    "Customize monokai theme"
    (if (member 'monokai-pro custom-enabled-themes)
        (custom-theme-set-faces
         'monokai-pro
         `(show-paren-match ((t (:background "#a9dc76" :weight bold))))
         )))
  (add-hook 'after-load-theme-hook 'customize-monokai)

With monokai I have to manually put the colors in rather than by reference to the names. Can you add similar capabilities to monokai please?

I've recently started getting the following error since updating to 27, and I cannot for the life of me figure out how to fix it:

Symbol’s value as variable is void: monokai-pro-spectrum-theme-colors

Same for the other flavors of the theme. A weirder thing is I tried to roll back to 26 and it still doesn't work. Is anybody else experiencing this issue? Thx

There's very poor contrast in the gutter for the current line number, to the point where it's barely visible. It's more cognitive load than necessary having to work out the current line number based on the previous/next line.

Thank you very much for this port! I'm trying to switch to Emacs from Sublime and this theme is making me feel already at home 🙂
Adding the other flavors as well would be awesome, since I was using Spectrum on Sublime.

Hi,
it seems that there is no special highlighting of yaml files. With atom-dark theme it works good. Does anyone know how one could get simple highlighting?
Thank you in advance!
Fab