GithubHelp home page GithubHelp logo

deploy_service's People

Contributors

bemurphy avatar

Watchers

 avatar

deploy_service's Issues

get a GIT_SSH config setup

We need to get GIT_SSH working with the git integration, so that we can embed a private key in an ENV variable and have the shell script write that to a temporary identity file.

git sha for a DeployRequest is misleading

The git sha is the result of the webhook notification from github. However the worker always pulls whatever is in master, so this is a race condition. We should probably store and refer to the sha of HEAD when we pull and not the the push event sha, since master is what we actually deploy.

Note it's simpler to just push master/production anyhow, because we don't want something like a queue backup on github to trigger a build of an older version than is currently deployed. HEAD is always what we want.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.