bernhardbaumrock / rockfinder2

This module is deprecated!

A message to Russian 🇷🇺 people

If you currently live in Russia, please read this message.

---

Please use RockFinder3: https://github.com/baumrock/rockfinder3

rockfinder2's Issues

CTRL + S to save changes to file

In sandbox module ace code field

Mixed case field names result in SQL error.

Example of problem:

$rf->addColumns([
  'title', // default pw field + alias
  'stockCode', // This triggers an SQL error.
]);

Cause: Processwire allows field names with mixed case, but mySQL stores table names in lower case.

Suggested Fix: in function addColumnTypes replace all instances of this line:
$table = $this->getTable($data->column);
with
$table = strtolower($this->getTable($data->column));

Also required in join function.

Tested, and appears to work in sandbox.

finder name is uniqe when loaded from file

Functions API requirement?

While testing RockFinder2 out, I noticed that it currently requires enabling the Functions API. Based on a cursory glance it seems that this might actually only be required for a single modules() call in ProcessRockFinder2.module.php.

If this is really the only instance where the Functions API is required, would you be willing to consider changing it? I'll readily admit that this is a personal preference, but I don't usually enable the Functions API unless absolutely necessary :)

gzip debug post request

tracy conflict

RockFinder2.js loads on Frontend

When using Formbuilder or LoginRegisterPro the init() method call causes the JS file to be loaded on the Frontend. The RockFinder2 JavaScript object should not be necessary on the frontend. This means the file should maybe not be loaded unless the user explicitly loads it?

Call to undefined function modules()

In ProcessRockFinder2.module.php line 173:

modules('InputfieldForm'); should be $this->modules->get('InputfieldForm');

note for myself: $config->useFunctionsAPI = true; is needed.

add autocomplete for ace field?

History of sandbox code

It would be great to have some kind of history of the sandbox code, just like in Tracy Debugger.