bertbaron / intravatar Goto Github PK

Would be a great feature if intravatar would support s3 to store the avatar images. This would make the docker not rely on a docker volume.

On most Windows installations the config.ini will by default open with notepad, which does not handle unix line endings. Therefore we better make sure that it has windows line endings when added to the zip archive

Currently only the host part of exposed links is configurable. To support reverse proxies we should allow configuration of the complete web root, including protocol and possible sub dir. For example:

webroot=https://avatars.intra.us/service

Intravatar does currently not respect the cache headers from the remote services. The reason is that it allows caching for a short period (currently 5 minutes) for its own requests so that changes will be picked up in decent time. However, if a remote service generates images that should be cached for a longer period intravatar should respect this.
The only way seems to be to cache those requests ourselves, so it will require some effort to implement this (unless we can find some proxy library that does this already). On the other hand, caching might greatly improve response time and will offload the remote services.

Images retrieved from remote service are currently simply passed trough. This means that anything else than a correct image will also be passed trough. This can lead to surprising results if the site for example returns a html page for some reason. Even worse, it is a security issue if the remote site can not be trusted.

Therefore we should always read the reply as image. This can simply be achieved by always converting the image.

When unpacking and running the application, uploads of images fails with a file not found error. The data directory (structure) should be part of the archive or it should be automatically created when needed (this should at least happen for any subdirectories)

The default logging library doesn't seem to support log rotation. To avoid ever growing disc usage we better look for a logging library that supports log rotation. A nice extra would be support for log levels also.

When a non-square image is uploaded (i.e. 260x319), and it is requested with ?s=260 it is returned with original dimensions. With any other size it is returned as a square image

I would be a nice feature to restrict the possible domains for emails to only allow emails of the company. An additional config line with comma separated values would work perfectly for us.

Thanks for the simple tool.

Moving from unconfirmed to avatars dir fails with 'The process cannot access the file because it is being used by another process.'