Comments (5)
bezoerb
commented on June 2, 2024
@addyosmani ping
from inline-critical.
bezoerb
commented on June 2, 2024
Ref Issue: addyosmani/critical#39
@bevacqua Your module looks nice and clean. I've created a similar module stylediff but i'll have to admit your code looks much nicer ;)
Can you add some test cases to your module?
from inline-critical.
addyosmani
commented on June 2, 2024
@bezoerb I pined @bevacqua to post an issue here because I had a feeling you might be interested ; ) I would be happy for us to land support for either, but if you feel more confident in this newer implementation let's go for it once tests land.
from inline-critical.
bezoerb
commented on June 2, 2024
@addyosmani thanks :)
from inline-critical.
bevacqua
commented on June 2, 2024
- added tests
- fixed bug that would remove styles that weren't inlined
@1.2.0
from inline-critical.
Related Issues (20)
- <noscript>'s to the bottom of HTML page? HOT 1
- Failed to inline when there is no link, style or script tag. HOT 1
- Incorrect handling of quotes in attributes HOT 4
- The type attribute for the style element
- Add preload strategy option HOT 1
- cave HOT 1
- Entire <head> replaced with inlined style tag HOT 1
- See if we can replace lodash with native code HOT 2
- Go templates support HOT 1
- `replaceStylesheets` question HOT 3
- 5.x performance and size HOT 4
- Move to media=print async CSS loading HOT 1
- Add CSP compliant preload option HOT 1
- Add strategy for async loading stylesheet with high priority
- Preloading strategy & uncritical css HOT 4
- Does it work with Eleventy 11ty? HOT 1
- Print stylesheet unexpectedly gets onload attribute
- document.querySelector throws error with bad selector HOT 3
- Update to loadCSS v1.2.0 HOT 1
- Can't change "media" attr in <link> HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from inline-critical.