bfla / campawesome Goto Github PK

• I should fix up the mobile site once there is significant mobile traffic

• The "max number reached" notice stays even after the campsites are reset. I'm not sure if it reappears once the reset button is used.

• Somehow "North Higgins Lake West Campground" (id = 268) got added without a corresponding vibe. This broke not only the campground page but also every browse, city, and search page that linked to it.

Right now campground rankings are not existent for many campgrounds and the City rerank script doesn't seem to work right

I just ran a search with a tribe filter. the filter continued to apply to the map markers but not to the list results.

If the user did not sign in with a Facebook account, the upper left says "[email protected]" instead of the user's email. This seems to happen when the naked url is used "getcamphero.com" instead of "www.getcamphero.com".

Lists cannot be deleted from list page and it reroutes to the "You shall not pass!" page.

• Katy could not login with email
• Problem #1: It was trying to use a root_path in Devise's after_sign_in method. I think the root path is now correctly defined but this still requires verification
• Problem #2: The omniauth_callback path was being saved as the session[:previous_url] which was causing a redirect loop. I think this is now fixed

misnamed city.description as "desciption". tried to fix it but was becoming a time suck

I should give the person feedback if the review is not processed correctly

• Deal with this once people start trying to sign in

This app definitely has some Law of Demeter issues. Scoping and callbacks are not optimal

• When the signup and signin modals are clicked, it forces the whole page to shift position.
• I think maybe they should be included at the top of the body tag or maybe at the top of the container?

I think some pages are generating N+1 requests. I should double check to make sure I'm using "includes" or custom queries in the cases where I'm fetching associated objects...

• It might be better to use an includes statement so I can get the destinations and state in just a couple queries
• but
• I tried using a scope like scope :top_destinations, joins(:destinations).where(...).limit(20)
• but it didn't work
• not worth wasting time on yet so I deferred it until later

For some reason the small photo size sometimes is sized like a thumbnail... This seems to occur if square photos are submitted. Maybe it's not forcing them to be sized properly...

• For one thing, the rating does not display in the modal. I think it's because it requires javascript and the javascript is not currently reloading when the new list html is fetched and inserted.
• I'm also not sure if the review modal works when the list is reset. Requires testing.

the Review modal doesn't display the Rateit stars correctly.

I need a better way to rank campsites and get the rank counts. The way I do it now is not so good and is buggy.

A search notice should display on the map when a search returns more than 50 campsites. Right now, though, it only works if the user uses the URL. If the user reloads a page with javascript, then it fails.

Right now, users can submit empty reviews. This is probably bad.

• if you reset the map, then for some reason you can't save campgrounds to your lists...

• Some users cannot login with Facebook.
• I think this is fixed now but I'm not certain...

• wants/beens simply don't work
• creating a list on the campsite page reroutes to inconvenient places.
• adding to a list on the search page causes an error page

• I might be violating the Law of Demeter
• destinations and cities access state properties via state
• campgrounds access city and state properties via their models
• Is this bad? idk. right now it doesn't matter.