bharatari / swyft-epsilon

A full-stack JavaScript web application for the Swyft student-run business at Phillips Exeter Academy.

Hi there 👋

swyft-epsilon's Issues

Unified coupon and token system in order processing

Order processing doesn't handle coupons and tokens in a unified manner.

Maintenance page through nginx

When the Sails server is down for maintenance, users should automatically be redirected to a maintenance page instead of seeing the 502 Bad Gateway error page.

select-menu component doesn't work on Ember 1.13.11

It worked on Ember 1.13.2, but once the app was updated to Ember 1.13.11 the component stopped functioning.

Beautify server code based on Airbnb style guide

Cherry-pick Sendgrid migration to master

The Sendgrid migration was performed on the stable branch so that it could be deployed immediately to production. This change needs to happen on the master branch as well.

Loading state for coupons on checkout

Right now if you enter a coupon you have to wait a bit before you see anything happen. For first time users, that'll just mean confusion so there needs to be some way to let the user know what's going on.

Test refactored and beautified code

The way code refactoring and beautification was approached was rather flawed. Instead of going through a gradual and more maintainable process, using a separate branch to beautify code resulted in confusion and bugs.

Going forward #5 and #6 will be finished through a more gradual and stable process, however, for now it's important to test the code that was merged into master and thoroughly check for bugs.

Finish confirmation page tests

The confirmation page testing (on the client) was held up by a bug that seems to have been fixed in Ember 2.x. The only thing holding us back from upgrading is issue #2, where the select-menu component doesn't work in later versions of Ember (and therefore needs to be changed).

Once the app is upgraded, work should continue on the client tests.

Typo in cart-utils cartItemsEqual function

There is a single '&' when there is supposed to be a '&&' in the if statement condition. I don't want to change this without properly testing it to ensure no side-effects.

Dynamic-price bug

Price doesn't update properly on view when discount goes back to null. So, if a user entered a coupon and then removed it, the price would still be the discounted price.

This seems like an issue that could be fixed with a more reliable, well-structured and maintainable one-way data flow between checkout and related components.

Deliveries don't seem to be auto-closing on production

This might be related to time zones again. The issue with creating deliveries (#14) is fine now that the server time zone is UTC, but now those deliveries don't seem to be closing properly.

Poorly written if statements in cart-utils functions

There are functions that have empty if statements while they have an else, instead of simply having just an if statement with the opposite condition.

Graphs on Admin Dashboard not showing latest deliveries

The graphs only display the 20 earliest deliveries instead of showing the 20 latest deliveries.

Change delivery status default text

Right now the delivery status screen defaults to "Irregular Operations" when there is no current delivery, this should be changed to something that makes more sense.

Test migration to Sendgrid

Test all email functionality within EmailService to ensure it works properly with the migration from Mandrill to Sendgrid.

Invalid explicit day of month definition

There was an error on dev and production being thrown during the delivery period on Wednesday that said Automatic Service Error: Error: Invalid explicit day of month definition. This looks like it's being thrown by moment.js.

Time zone bug on production

On DigitalOcean, it looks like deliveries are being created in UTC time instead of EST time. What's worse is that the detection for whether a delivery should be created is also off, so even if you fix the delivery that was created, you end up getting a duplicate at some point. I think Modulus set their server time zone to EST which is why we never had an issue there. The long-term solution would be to create a layer on top of AutomaticService that normalizes time zones no matter what time zone the server is in. A short-term solution would be to change the time zone of the DigitalOcean server to EST.

Beautify client code based on Airbnb ES6 style guide

Payment option deselects when adding a coupon or token

On checkout, if you select a payment option and then add a coupon or token, the payment option will deselect.

SSL error on Android

The Internet browser on Android isn't properly recognizing Swyft's SSL certificate and displays a warning page. Chrome used to have a problem with it, but it now seems to be working fine.