Comments (6)
I think the culprit here may be the new "wrench" menu button added in Octoprint 1.8.0 (the one that currently allows you to toggle "Show state marks"). It is implemented as a new div
above the temperature graph. It looks like TouchUI is expecting the temperature graph to be div:first-child
in that context, when it adjusts it to take up most of the screen. Now that first child is the button's row, instead, so we end up with the graph pushed down off the bottom.
from octoprint-touchui.
This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
from octoprint-touchui.
Thanks, I'll have a look and see if I can tweak the code to allow for the extra first div
from octoprint-touchui.
Yes I was thinking the same thing that the culprit was the "new wrench". I'm interested to see your results MarkForrest. I'd have a try myself but i've not enough coding know how to make those kinds of edits. Good luck.
from octoprint-touchui.
Fixing the styling for Octoprint 1.8.x is fairly easy; here is a branch that does so. (Just changes the selector to the second child, instead of the first. I also made the new wrench button overlay on top of the graph, instead of wasting precious space above it.)
The catch is that this will break the layout for older Octoprint versions before 1.8. I am not sure how to gracefully handle both versions at the same time, unfortunately. @BillyBlaze Do we need to worry about such backwards compatibility, or is upping the required Octoprint version acceptable? (Or does anyone have a good idea how to handle both layouts?)
from octoprint-touchui.
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from octoprint-touchui.
Related Issues (20)
- unable to load page on start HOT 2
- Possible memory leak in the browser HOT 2
- TouchUI opens always, regardless if desktop or mobile #280 HOT 2
- TouchUI opens always, regardless if desktop or on raspberry pi HOT 3
- Larger screens? HOT 2
- [BUG] Error evaluating function `darken`: HOT 2
- Auto Login HOT 3
- Fail HOT 2
- Temps screen doesn't show a menu to turn the temps off. HOT 3
- Error setting up autoboot for LCD scree HOT 1
- Connection Menu Does Not Render HOT 2
- heat graph HOT 10
- Still maintained? HOT 2
- Site can't be reached after browser-auto-load HOT 2
- Touch UI - No Temperature Graph HOT 6
- Install script doesnt use specified user HOT 1
- Touch Ui switched to ACTIVE via web interface - Cannot switch to inactive HOT 1
- Octopi Touch UI empty space before temp. graph HOT 1
- WARN: caused screen burn in after only 15 minutes on steamdeck HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from octoprint-touchui.