GithubHelp home page GithubHelp logo

ectmb's People

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar

ectmb's Issues

Apply ecTMB in our own data

Dear sir,
I cannot find a way to put my own data in the TMB model.
Is the input a maf file from Mutect2?
Do you have any suggestion?

ecTMB much higher in WES compared to Panel

Dear developer, thank you for your great effort. I'm facing a problem that I'm not able to find a solution. How is it possible that when I apply your algorithm to my own data I found a TMB's value higher (for example 200 vs 10) in total WES than in panel? (COnsidering that the experiment is made with Agilent Panel, so the entire WES is not full sequenced?)

Error when following Example Usage

Hi,

I was trying out this package, and came across what appears to be an error while running the Example Usage (using the example data).

> trainData = UCEC_mafs[UCEC_mafs$Tumor_Sample_Barcode %in% as.character(SampleID_train),]
> trainset = readData(trainData, exomef, covarf, mutContextf, ref)
Number of inconsistant annotation mutation: 0 out of total 0 mutation 
Bed file is not specified for samples. exomeGene for whole exome will be generated.
Total gene analyzed: 0

And then subsequently get this message:

> sample = data.frame(SampleID = SampleID_test, BED = TST170_panel, stringsAsFactors = FALSE)
> testData = UCEC_mafs[UCEC_mafs$Tumor_Sample_Barcode %in% as.character(SampleID_test),]
> testset_panel = readData(testData, exomef, covarf, mutContextf, ref, samplef = sample)
Number of inconsistant annotation mutation: 0 out of total 0 mutation 
Total 0 out of 176 samples with at least one mutation detected.
Only the ones with at least one mutation will be used.
Bed file is specified for samples
	All samples have the same bed regions
Error in `$<-.data.frame`(`*tmp*`, "Chromosome", value = "chr") : 
  replacement has 1 row, data has 0

Any idea what might be going on?

Thanks :)

Bug in fit_model

Hello,

I found a bug in the fit_model function, which only reveals itself if one tries to use some other name for the trainset variable.

Here:

ecTMB/R/stats.R

Lines 412 to 417 in abf9b37

# count number of mutation per patient for offset calculation
if(bs.type == "all"){
mutPerP = CalTMB(trainset, sampleN = as.character(trainset$samples$SampleID))
}else if(bs.type == "nonsil"){
mutPerP = CalTMB(trainset, sampleN = as.character(trainset$samples$SampleID), type = "nonsil")
}

Instead of trainset in the CalTMB function calls (both the first argument and the sampleN), the argument should be Data, so that it refers to the argument specified in the fit_model function call.

It will be great if you fix it in the next release!

Best wishes,
Aleksandra

Bug in procMaf.R

Hi!

I found a bug in procMaf.R line 253 (maf_dnp_converter function):

a= matrix(0, nrow= nrow(mutab.onp)*umaxchar[k],ncol=ncol(mutab.onp) )

With my dataset, I got an error while performing readData, which traced back to this bug.

> trainset       = readData(trainData, exomef, covarf, mutContextf, ref)
Error in matrix(0, nrow = nrow(mutab.onp) * umaxchar[k], ncol = ncol(mutab.onp)) : 
  invalid 'nrow' value (too large or NA)

It appears that within the loop, the mutab.onp variable sometimes only contains one row, which means that it is treated as a vector and hence nrow(mutab.onp) returns NULL. It looks like the previous line, 252, was supposed to correct that, but it is formulated very strangely - length(mutab.onp) will depend on the number of accessory columns and will not necessarily be 8 when there is one row only. A fix along the lines of

if ( is.null(nrow(mutab.onp) ){mutab.onp = t(as.matrix(mutab.onp))}

is suggested.

Best regards,
Aleksandra

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.