birkir / hekla Goto Github PK

Advice on react native beginners!
What are the roles of assets directory and patches directory respectively?
Thanks.

Hacker news users have reported that a specific ratio of upvotes and comments give indication of the story quality. Maybe we could introduce something similar to show in Story Screen

In 2 of themes (default (dark) and piggy (light)), link are not working.

Testted on Xiaomi Redmi Note 5 with
Andorid 9 - app version 1.0.16 build 22

Scenario: You post a comment. A placeholder comment is shown while the app makes a request to the API and waits for it to be resolved back with an ID.

When the real comment comes back from the API and is going to replace the placeholder comment, this happens:

[mobx-state-tree] Cannot modify 'late(function (){return v})[]@/items/17748940/comments', the object is protected and can only be modified by using an action.

I am guessing this isn't wrapped in an action (because of the ref.on()) and could be resolved by creating a separate action on the Item model.

https://github.com/birkir/hekla/blob/master/src/stores/models/Item.ts#L330

After changing theme to dark, pressing Metalinks don't open chrome, wether it's set to in-app or chrome itself.
How to reproduce:

1. install app from play store.
2. change theme settings to dark.
3. links don't work anymore.

Tested environments:

1. Android 9/ Google Pixel 1/ Release (via play store)
2. Android 6.0/ Genymotion custom/ Debug (github master branch)

React native yellowbox warning on debug mode:

Possible Unhandled Promise Rejection (id: 0):
Error: Invalid toolbar color '#000': Unknown color

Related PR: #12

Sometimes when you're scrolling down in the comments, someone says something that makes you want to check the link again for clarification. Then you have to scroll to the top and click the link, then close the browser and scroll back down to that comment again to continue.

To have a sticky Metalink on top when you scroll past the story header is a good idea. A simplified version of this could just be an icon to the top right corner of the Top Bar to visit the link.

The app doesn't take fullscreen height.
I can force it with my system, but it should work without that.
And in the beginning there is a popup that this is an old android sdk version and can have unexpected behavior.

Once I open the app for the first time (fresh start) the No Connection toast is shown at the bottom.
Happened on my Android, not sure if it is happening on iOS.

First of all, Great Project!
Second, this is a open-source project, would be interesting to publish it on alternatives stores about this niche like F-droid, especially because it is an open-source initiative.

(i'm not sure if here is the best place to leave a suggestion, but i din't find another place to do it in public)
Thanks.

After pushing, I'm getting this error

yarn run v1.9.2
$ jest
FAIL src/utils/tests/age.spec.ts
● Test suite failed to run

Plugin 0 specified in "/Users/leonardoferrari/rn/hekla/node_modules/babel-preset-react-native/index.js" provided an invalid property of "default" (While processing preset: "/Users/leonardoferrari/rn/hekla/node_modules/babel-preset-react-native/index.js")

  at Plugin.init (node_modules/jest-config/node_modules/babel-core/lib/transformation/plugin.js:131:13)
      at Array.map (<anonymous>)
      at Array.map (<anonymous>)

FAIL src/utils/tests/prettyNumber.spec.ts
● Test suite failed to run

Plugin 0 specified in "/Users/leonardoferrari/rn/hekla/node_modules/babel-preset-react-native/index.js" provided an invalid property of "default" (While processing preset: "/Users/leonardoferrari/rn/hekla/node_modules/babel-preset-react-native/index.js")

  at Plugin.init (node_modules/jest-config/node_modules/babel-core/lib/transformation/plugin.js:131:13)
      at Array.map (<anonymous>)
      at Array.map (<anonymous>)

Test Suites: 2 failed, 2 total
Tests: 0 total
Snapshots: 0 total
Time: 1.924s
Ran all test suites.

When opening a story, store how many descendants in AsyncStorage for future visits. Next time the story is opened, show difference since last visited in a toast at the bottom of the screen.

8 new replies since yesterday

32 new comments

#5 similar issue there is no ios or android set up and installation guide

suggestion

step 1 yarn install
separate android and ios setup
firebase for respective devices
also missing Podfile.lock and Manifest.lock on ios version

any other set up steps?

Is this working ? if yes, how ?

Thanks

When on Android if you try to share a link on the Story view, it will not work.

From what I can tell it is due to the way the RN Share API is being used, by only passing through the title and url properties. The url property only works on iOS but doesn't work on Android.

On Android I believe it is the message property that should be used.

Ideas to test and validate that the hackernews service is working as expected and won't break between code changes.

Hi, would it be possible to make the app available in Europe by any chance? Thanks

Hi there, I'm looking at hekla to evaluate the quality of Wix react-native-navigation v2. I built the app on both Android and iOS -- looks great btw.

I noticed some inconsistencies, however. On iOS the tab buttons are centered in their frame. On Android it looks like they lack a bit of top padding.

Also, when you navigate to the Settings tab and select a setting to change "General" for example, on iOS the General panel slides in from the right. On Android, the title bar slides in right, but the content appears to slide up from the bottom.

Hi there, I'm trying to run the project but I'm getting this stack error:

Is there any config I need to init to make it work?

Thanks!