bisquit / apply-partial-props

Hi there 👋

apply-partial-props's Issues

fake for storybook

Option A - provide mock object in second arg

applyHook(component)(hook, {
  // mock object
  options: ['a', 'b'],
  onKeywordChange: () => 'mock'
});

advantage

• simple implementation

drawback

• mock code is included in production

Option B - dynamically import mock object when the flag is on

// not changed
applyHook(component)(hook)

// applyHook.ts
function applyHook() {
  if (someFlag) {
    return await import('./mock');
  }
}

// mock.ts
export default {
  options: ['a', 'b'],
  onKeywordChange: () => 'mock'
}

advantage

• unless flag is on, mock data is not imported

drawback

• requires some conventions

configurable

Like this issue, it is useful to configure options.
#1

async

accept async fn

async function somePropProvider() {}

applyPartialProps(component)(somePropProvider);

applyPartialProps(component)(async () => { ... });

api design

current

// applyPartialProps(component: FC)(fn: () => Partial<ComponentProps>)
applyPartialProps(component)(hookFn)

after

// applyPartialProps(component: FC)(props: Partial<ComponentProps>)
applyPartialProps(component)(hookFn());

// can provide args
applyPartialProps(component)(hookFn(args));

// simply pass partial object
applyPartialProps(component)({ ... });

rename

In fact it is not restricted to hooks. Can accept all type () => Partial<ComponentProps<T>> .

So more common name is better..

• applyPartialProps ?