GithubHelp home page GithubHelp logo

Comments (5)

junderw avatar junderw commented on May 9, 2024

bitcoinjs.bip32 or just require('bip32')

A pull request to fix the README would be appreciated.

from bip32-utils.

Adoliin avatar Adoliin commented on May 9, 2024

A pull request to fix the README would be appreciated.

Yes sure I just did one #17
I fixed the first and second code blocks but didn't do anything to the third because it too is using an old library cb-blockr that I don't think this README should be using.

Also to test these changes of the README one must use the latest commit of this library and not the old version "0.11.1" one.
So I think we should release a new version of this library because when someone add this to their project via npm or yarn they get the old version (0.11.1) that is not compatible with the latest version of bitcoinjs-lib

from bip32-utils.

Adoliin avatar Adoliin commented on May 9, 2024

Another thing do you need help refactoring this codebase to Typescript?

Or at least add type definition to it?

from bip32-utils.

junderw avatar junderw commented on May 9, 2024

I have no plans on doing anything with this library, as I personally don't find it too useful and neither does anyone I work with/for.

If you can make a PR, I'll review it. Any changes that are too big should be discussed ahead of time before any large PRs are created.

The worst feeling is to work on a huge PR and get a concept NACK from the maintainer.

from bip32-utils.

junderw avatar junderw commented on May 9, 2024

TS and/or definitions-only seems pretty straightforward though. I'm cool with it.


This issue is done. Closing.

from bip32-utils.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.