Comments (9)
No, I don't think this module should be renamed to bip32
. I think hdnode
should be extracted and renamed to bip32
.
from bip32-utils.
@jprichardson is that just a matter of the primary export though? I still feel like derivation utilities such as those that exist here (or intend to) should definitely be bundled with the core data structure (that is HDNode
)
from bip32-utils.
bump @jprichardson
from bip32-utils.
I still feel like derivation utilities such as those that exist here (or intend to) should definitely be bundled with the core data structure (that is HDNode)
Agreed with this.
But address discovery should be integrated with bip32-wallet
or stay in bip32-utils
yes?
from bip32-utils.
But address discovery should be integrated with bip32-wallet or stay in bip32-utils yes?
This I can't decide. It is clearly mentioned in the BIP (see quote below).
... Nodes can keep a pool of N look-ahead keys cached for external chains, to watch for incoming payments. The look-ahead for internal chains can be very small, as no gaps are to be expected here. An extra look-ahead could be active for the first unused account's chains - triggering the creation of a new account when used ...
So I'm not sure where it should go, it would feel odd being combined with the core datastructure, so maybe you are right that it should go to bip32-wallet
.
from bip32-utils.
Related bitcoinjs/bip32-wallet#6
from bip32-utils.
But address discovery should be integrated with bip32-wallet or stay in bip32-utils yes?
What is provided is an algorithm that is agnostic of any network information, so in that sense it is purely related to key management.
I think it would be OK for it to remain in this module.
Thoughts?
from bip32-utils.
Also related: bitcoin/bips#293
from bip32-utils.
Closing in favour of bitcoinjs/bip32#1
from bip32-utils.
Related Issues (11)
- toJSON / fromJSON and address functions ... no compatibility
- Documentation? HOT 4
- There is a reference to bitcoin.hdNode in README but there is no such thing in bitcoinjs-lib HOT 5
- Instantiate a BIP32 class from a private key? HOT 2
- Add path derivation utility HOT 1
- possible to generate addresses from a master public key? HOT 2
- Add tests for `Account.prototype.discoverChain` HOT 1
- Unable to derivate xPub from Account HOT 6
- Unexpected token: new HOT 1
- CKD: Public parent key → public child key HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bip32-utils.