bitfinexcom / bfx-lib-server-js

bfx-lib-server-js

Module for shared server logic used by our the express server in our Single Page Applications (SPAs)

bfx-lib-server-js's Issues

getGrenacheReqWithIp improvements

When writing a server where some arguments come from the server itself (e.g. a config file), getGrenacheReqWithIp requires monkey patching the request object.

Example from moonbeam:

  _getAuthToken (req, user, cb) {
    const service = 'rest:core:user'
    const request = getGrenacheReqWithIp('getAuthToken', service)

    req.body.user = user
    request(req, {
      json: (data) => {
        if (!data.success) {
          if (data.message.startsWith('connect ECONNREFUSED') ||
            data.message.startsWith('ERR_GRAPE_LOOKUP_EMPTY')) {
            log(data)
            return cb(new Error('ERR_AUTH_BACKEND'))
          }

          return cb(new Error('ERR_AUTH'))
        }

        cb(null, data.data)
      }
    })
  }

Possible solutions:

1. allow optional arguments as parameter for getGrenacheReqWithIp
2. add another method which does not interact with the request object