bitranox / fake_winreg Goto Github PK

• I'm submitting a feature request

  • bug report
  • feature request
  • support request

• Do you want to request a feature or report a bug?
  Request a feature: Add __enter__ and __exit__ to fake_winreg.fake_winreg.PyHKEY
  This functionality exists in winreg:

with winreg.ConnectRegistry(None, winreg.HKEY_LOCAL_MACHINE) as hive_root:
    # Do stuff

• What is the current behavior?

hive_root = None
try:
    hive_root = fake_winreg.ConnectRegistry(None, fake_winreg.HKEY_LOCAL_MACHINE)
    # do stuff
finally:
    if hive_root is not None:
        hive_root.Close()

• What is the expected behavior?

with fake_winreg.ConnectRegistry(None, fake_winreg.HKEY_LOCAL_MACHINE) as hive_root:
    # Do stuff

And also:

with fake_winreg.OpenKeyEX(hive_root, "Path\To\Key") as key:
    # Do stuff

• What is the motivation / use case for changing the behavior?
  The motivation to add this functionality is to better mock the winreg module.

• Please tell us about your environment:

• Module Version : v1.5.6
• Python Version : 3.7
• OS, OS Version : Win10 x64

• Other information (e.g. detailed explanation, stack traces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow
  , gitter, etc)
  Currently, When trying to execute the above code with fake_winreg an exception is raised:

AttributeError                            Traceback (most recent call last)
<ipython-input-21-13204fe8e48d> in <module>
----> 1 with fake_winreg.ConnectRegistry(None, fake_winreg.HKEY_LOCAL_MACHINE) as hive_root:
      2     pass
      3

AttributeError: __enter__