bjrke / jsr305checkstyleplugin Goto Github PK

View Code? Open in Web Editor NEW

19.0 3.0 6.0 10.45 MB

a plugin which ensures nullness annotations on methods and constructors

License: GNU Lesser General Public License v2.1

Java 99.34% Shell 0.39% Dockerfile 0.27%

checkstyle checkstyle-plugin jsr-305 findbugs

jsr305checkstyleplugin's People

Contributors

Stargazers

Watchers

Forkers

neurolabs fabotronix letalvoj justsocialapps mbert vijayeluri

jsr305checkstyleplugin's Issues

unable to use gradle 4

for some unknown reasons the test are failing when upgrading the gradle wrapper (tested 4.1 and 4.4)
execute ./gradlew wrapper --gradle-version 4.4 twice

missing translation

see https://sourceforge.net/p/eclipse-cs/git/ci/master/tree/net.sf.eclipsecs.sample/src/net/sf/eclipsecs/sample/checks for an example

support custom annotations

it is possible to declare your own JSR305 annotation like described in

https://stackoverflow.com/questions/7658353/is-parametersarenonnullbydefault-applies-to-method-return-values-too/13429092#13429092

Checkstyle 7+ is supported as well as Java 8 but the tests fail on java 7 hosts because checkstyle 7 is incompatible to Java 7.
Find a way to not run Checkstyle 7+ compatibilty test on a Java 7 travis test.

move files from src/test/java/de/bjrke/checkstyle/jsr305/test into resources

they don't need to be compiled and therefore should be moved.
this can be useful to re enable the java 7 build process and code compatibility.

@ReturnValuesAreNonnullByDefault should allow @Nonnull on overriden Methods

The annotation @ReturnValuesAreNonnullByDefault does not cover methods that override a super class method[1]. Therefore a @Nonnull-Annotation should be allowed for the return value. Currently the warning "It is not necessary to annotate @Nonnull if you annoted the class with @ReturnValuesAreNonnullByDefault." is issued.

[1] http://findbugs.sourceforge.net/api/edu/umd/cs/findbugs/annotations/ReturnValuesAreNonnullByDefault.html

update/uninstall problems with eclipse

there is a problem, when you try to update to a newer version
I solved it by

clear all occurences of package-/plugin- and class-name in eclipses directory to purge the installation
put plugin into eclipses dropin dir
possibly no problem when plugin was in dropin dir before (need to be checked)

Doppelte Annotationen sollten auch erfasst werden

Sowas wie

@nonnull
@checkfornull
public foo() {
}

soltle das auch sehen.

use SpotBugs in test
review/update SpotBugs annotations, especially non JSR305 annotations

support package level annotation

find a way to honor annotations at package-info.java

plugin not compatible with Eclipse Checkstyle Plug-in version 8.0.0

After upgrading my eclipse checkstyle plugin to version 8.0.0 (https://sourceforge.net/projects/eclipse-cs/) I wasn't able to use checkstyle at all. It gave me following exception:

Checkstyle-Plugin: cannot initialize module TreeWalker - Unable to instantiate 'Jsr305Annotations'. class, it is also not possible to instantiate it as com.puppycrawl.tools.checkstyle.checks.annotationJsr305Annotations, com.puppycrawl.tools.checkstyle.checks.blocksJsr305Annotations, com.puppycrawl.tools.checkstyle.checks.codingJsr305Annotations, com.puppycrawl.tools.checkstyle.checks.designJsr305Annotations, com.puppycrawl.tools.checkstyle.checks.headerJsr305Annotations, com.puppycrawl.tools.checkstyle.checks.importsJsr305Annotations, com.puppycrawl.tools.checkstyle.checks.indentationJsr305Annotations, com.puppycrawl.tools.checkstyle.checks.javadocJsr305Annotations, com.puppycrawl.tools.checkstyle.checks.metricsJsr305Annotations, com.puppycrawl.tools.checkstyle.checks.modifierJsr305Annotations, com.puppycrawl.tools.checkstyle.checks.namingJsr305Annotations, com.puppycrawl.tools.checkstyle.checks.regexpJsr305Annotations, com.puppycrawl.tools.checkstyle.checks.sizesJsr305Annotations, com.puppycrawl.tools.checkstyle.checks.whitespaceJsr305Annotations, com.puppycrawl.tools.checkstyle.checksJsr305Annotations, com.puppycrawl.tools.checkstyle.filefiltersJsr305Annotations, com.puppycrawl.tools.checkstyle.filtersJsr305Annotations, com.puppycrawl.tools.checkstyleJsr305Annotations, com.github.sevntu.checkstyle.checks.annotationJsr305Annotations, com.github.sevntu.checkstyle.checks.codingJsr305Annotations, com.github.sevntu.checkstyle.checks.designJsr305Annotations, com.github.sevntu.checkstyle.checks.namingJsr305Annotations, com.github.sevntu.checkstyle.checks.sizesJsr305Annotations, com.github.sevntu.checkstyle.checksJsr305Annotations, com.github.sevntu.checkstyleJsr305Annotations, de.bjrke.checkstyle.jsr305.Jsr305Annotations, Jsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.checks.annotationJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.checks.blocksJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.checks.codingJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.checks.designJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.checks.headerJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.checks.importsJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.checks.indentationJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.checks.javadocJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.checks.metricsJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.checks.modifierJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.checks.namingJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.checks.regexpJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.checks.sizesJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.checks.whitespaceJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.checksJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.filefiltersJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyle.filtersJsr305AnnotationsCheck, com.puppycrawl.tools.checkstyleJsr305AnnotationsCheck, com.github.sevntu.checkstyle.checks.annotationJsr305AnnotationsCheck, com.github.sevntu.checkstyle.checks.codingJsr305AnnotationsCheck, com.github.sevntu.checkstyle.checks.designJsr305AnnotationsCheck, com.github.sevntu.checkstyle.checks.namingJsr305AnnotationsCheck, com.github.sevntu.checkstyle.checks.sizesJsr305AnnotationsCheck, com.github.sevntu.checkstyle.checksJsr305AnnotationsCheck, com.github.sevntu.checkstyleJsr305AnnotationsCheck, de.bjrke.checkstyle.jsr305.Jsr305AnnotationsCheck. Please recheck that class name is specified as canonical name or read how to configure short name usage http://checkstyle.sourceforge.net/config.html#Packages. Please also recheck that provided ClassLoader to Checker is configured correctly.
	at com.puppycrawl.tools.checkstyle.Checker.setupChild(Checker.java:457)
	at com.puppycrawl.tools.checkstyle.api.AutomaticBean.configure(AutomaticBean.java:171)
	at net.sf.eclipsecs.core.builder.CheckerFactory.createCheckerInternal(CheckerFactory.java:290)
	at net.sf.eclipsecs.core.builder.CheckerFactory.createChecker(CheckerFactory.java:128)
	at net.sf.eclipsecs.core.builder.Auditor.runAudit(Auditor.java:141)
	at net.sf.eclipsecs.core.builder.CheckstyleBuilder.handleBuildSelection(CheckstyleBuilder.java:301)
	at net.sf.eclipsecs.core.builder.CheckstyleBuilder.build(CheckstyleBuilder.java:172)
	at org.eclipse.core.internal.events.BuildManager$2.run(BuildManager.java:735)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:206)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:246)
	at org.eclipse.core.internal.events.BuildManager$1.run(BuildManager.java:301)
	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:304)
	at org.eclipse.core.internal.events.BuildManager.basicBuild(BuildManager.java:263)
	at org.eclipse.core.internal.events.BuildManager.build(BuildManager.java:403)
	at org.eclipse.core.internal.resources.Project$1.run(Project.java:551)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2240)
	at org.eclipse.core.internal.resources.Project.internalBuild(Project.java:529)
	at org.eclipse.core.internal.resources.Project.build(Project.java:112)
	at net.sf.eclipsecs.core.jobs.BuildProjectJob.run(BuildProjectJob.java:87)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:55)

After downgrading to version 7.6.0 it works like a charm.

Recommend Projects

React

A declarative, efficient, and flexible JavaScript library for building user interfaces.
Vue.js

🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
Typescript

TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
TensorFlow

An Open Source Machine Learning Framework for Everyone
Django

The Web framework for perfectionists with deadlines.
Laravel

A PHP framework for web artisans
D3

Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

javascript

JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
web

Some thing interesting about web. New door for the world.
server

A server is a program made to process requests and deliver data to clients.
Machine learning

Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Visualization

Some thing interesting about visualization, use data art
Game

Some thing interesting about game, make everyone happy.

Recommend Org

Facebook

We are working to build community through open source technology. NB: members must have two-factor auth.
Microsoft

Open source projects and samples from Microsoft.
Google

Google ❤️ Open Source for everyone.
Alibaba

Alibaba Open Source for everyone
D3

Data-Driven Documents codes.
Tencent

China tencent open source team.

Jobs

Jooble