blimmer / zsh-aws-vault Goto Github PK

Hi please remove qoutes from browser option vars specifically for firefox
If not then when firefox private windows opens up with two tabs one containing aws console and other one displaying all your file / directories in local drive @ following URL file:///Users/myusername/

"$AWS_VAULT_PL_BROWSER_LAUNCH_OPTS" should be updated with $AWS_VAULT_PL_BROWSER_LAUNCH_OPTS

How do you add the prompt to the agnoster theme? I was reading through the agnoster documentation and I was unable to figure it out.

Would you be open to merging my aws-vault completion script? I'd be glad to have that in a plugin that's more popular than mine, so that other people benefit from it as well. :)

Hello. Autocomplete for aws profiles stopped working for me for some commands. It works for avli and avsh but it doesn't work for ave and avl anymore. I'm not sure if this functionally was removed or I'm doing something wrong. May I ask for advice on this one?

Hi, thank you for this amazing project.
After updating to the latest version the new browser window is not maximized anymore.
avli <profile> - now opened a chrome window that is not maximized and the content is squeezed.

Also calling avli now makes the terminal "blink" for a few seconds.

I believe this commit introduced the problem:
7b1b5db

As well as another problem (that was there before)
The --path argument is not respected with avli, it works perfectly with avl.
avli <profile> --path=lambda -> leads to the main console page.

google-chrome --incognito $(avl -s infra-tools-dev --path="lambda") - works as expected -> starts maximized window and goes to lambda page.

Workarounds

• --path - I applied a workaround by modifying function avli() on L45 to login_url="$(avll $*)"
• blinking terminal -- I modified L82 to (${browser} --no-first-run --incognito "${login_url}" 1>/dev/null 2>/dev/null && rm -rf "${AVLI_TMP_PROFILE}")

Either my brain is pulling tricks on my, but I seem to remember I could specify the yubiky OTP profile to use on the zsh-aws-vault shortcuts like avsh.

eg, this is my .aws/config file:

[default]
region=eu-west-1

[profile hic]
mfa_serial=arn:aws:iam::xxxxxx:mfa/jeroen

[profile hic-admin]
source_profile = hic
role_arn = arn:aws:iam::xxxxxx:role/hic-admin-role
mfa_serial=arn:aws:iam::xxxxxx:mfa/jeroen

On my Yubikey, I have an OTP profile called hic-aws-user , and I verified this working correctly.

Shouldn't I be able to just type something like avsh hic-admin hic-aws-user, and It would get OTP key automatically and start the shell for the hic-admin profile?

avsh hic-admin hic-aws-user
aws-vault: error: exec: Couldn't find the executable 'hic-aws-user': exec: "hic-aws-user": executable file not found in $PATH

I really seem to have a memory of this working in the past, so either this is a false memory or I am missing something obvious?

env vars:

AWS_VAULT_BACKEND=pass
AWS_VAULT_PASS_PREFIX=aws-vault
AWS_VAULT_PL_BROWSER=''
AWS_VAULT_PL_BROWSER_LAUNCH_OPTS=''
AWS_VAULT_PL_DEFAULT_PROFILE=default
AWS_VAULT_PL_MFA=yubikey

90% of the time, my terminal prompt looks like this:

It'd be nice to allow hiding this and just show the little cloud when you're logged into your default.

I think we should also provide an environment variable that folks can override to:

• turn off the feature
• ignore another "default-ish" profile, other than default.

Thanks for making this plugin - it's been very useful as my company has transitions to aws cli mfa!

Is there a way to reauthorize myself when a session expires without closing the shell or making another subshell?