blouni / phpsvnclient Goto Github PK

This diff is a README in Markdown format.

What steps will reproduce the problem?
1. Run getDirectoryFiles
2.
3.

What is the expected output? What do you see instead?
Error on Line 786 Undefined variable: tmp

What version of the product are you using? On what operating system?

current trunk

Please provide any additional information below.

the $tmp variable does not exist. To fix it delete line 786

What steps will reproduce the problem?
Trying to access http://svn.automattic.com/wordpress/ returns invalid
result, here's the code I used:

<?php
$url = 'http://svn.automattic.com/wordpress/';
require_once('phpsvnclient.php');
$phpsvnclient = new phpsvnclient($url);
$files_now = $phpsvnclient->getDirectoryFiles('/trunk/');

echo "<pre>\n";
print_r($files_now);
echo "</pre>\n";
?>

What is the expected output? What do you see instead?
Expected:
            [type] => directory
            [last-mod] => Tue, 12 Aug 2008 23:19:07 GMT
            [path] => trunk
            [status] => HTTP/1.1 200 OK


What I get:

            [type] => /wordpress/!svn/bc/8632/trunk/
            [last-mod] => Tue, 12 Aug 2008 23:19:07 GMT
            [status] => HTTP/1.1 200 OK

What version of the product are you using? On what operating system?

I'm using the June 23 2008 version

Please provide any additional information below.

Attached is phpsvnclient.php with a fixed storeDirectoryFiles()

What steps will reproduce the problem?
1. Use as $url in example.php a berlios project (for example:
http://svn.berlios.de/svnroot/repos/dreamos/)
2. Launch example.php in browser.

The output is a blank page. 

And the error_log content of httpd is: 

[Tue Apr 06 17:11:21 2010] [error] [client 127.0.0.1] PHP Notice: 
Undefined index: RequestURI in /srv/http/SVNtoIRC/phpsvnclient.php on line 562

Would be nice to have a discussion forum on this..

I am looking for a way to get only changes between revisions/tags

so getDirectoryFiles($current_rev, $target_rev) so that I don't have to get all 
files each time.

К примеру сделать что-то вроде 
start_after_execution($path_to_script) {
include_once($path_to_script);
}

What steps will reproduce the problem?
1. Entering the complete COmmand line 


What is the expected output? What do you see instead?
Checking out the source code

What version of the product are you using? On what operating system?
Windows CollabNet

Please provide any additional information below.

Error : Unable to connect to server http://phpsvnclient.googlecode.com/

line 164 check if $tree is array or throw exception with the error number
line 287 only loop if its an array

Hi,

I've just written a modification to your class and would like to contribute
it. Is there any chance in getting SVN access or should I just attach the
modifications here?

Cheers,
Thomas

What steps will reproduce the problem?
1. Create the phpsvnclient object, pointing to a HTTPS repository, using 
correct credentials
2. Call getDirectoryFiles('/folder/') - change /folder/ to something valid.

What is the expected output? What do you see instead?
An array with the file listing was expected, but 'false' was returned instead.

What solved?
Changed the repository URL to HTTP and getDirectoryFiles() worked correctly

What version of the product are you using? On what operating system?
Revision 134 (checkout trunk folder).
Windows 7 Ultimate Edition Service Pack 1
Zend Server - Apache/2.2.25 (Win32)

Please provide any additional information below.
http://stackoverflow.com/questions/21777052/php-svn-client-solution

I was downloading a file with symbols '[' and ']' in its name. It was 
mistakenly reported as a directory, because the 'type' field had these symbols 
replaced by %XX by the SVN server, but the 'path' field did not. I suggest 
replacing the line

$this->storeDirectoryFiles['path'] = str_replace(' ', '%20', 
$this->storeDirectoryFiles['path']); //Hack to make filenames with spaces work.

with these lines

$original = array('%','$','&',',',':',';','=','?','@',' 
','<','>','#','{','}','|','^','~','[',']','`');         
$replacements = 
array('%25','%24','%26','%2c','%3a','%3b','%3d','%3f','%40','%20','%3c','%3e','%
23','%7b','%7d',
$this->storeDirectoryFiles['path'] = str_replace($original, $replacements, 
$this->storeDirectoryFiles['path']); 

What steps will reproduce the problem?
1. set up a minimalistic PHP file to checkout from an SVN server
2. run the php file


What is the expected output? What do you see instead?
Not an error

What version of the product are you using? On what operating system?
Latest according to svn checkout on Ubuntu 11.04

Please provide any additional information below.

Try this php script:
<?php
require ('phpsvnclient/phpsvnclient.php');
$oSVN = new phpsvnclient('https://subversion.server.com/trunk', 'user', 
'password');
$oSVN->checkOut();
?>

It outputs:
PHP Warning:  Invalid argument supplied for foreach() in 
/var/www/phpsvnclient/phpsvnclient.php on line 165

I added a "continue" but that only took the script so far before more warnings 
showed up:
if (!is_array($tree))continue;

The following messages are:
PHP Notice:  Uninitialized string offset: 0 in 
/var/www/phpsvnclient/phpsvnclient.php on line 560
PHP Notice:  Undefined index: RequestURI in 
/var/www/phpsvnclient/phpsvnclient.php on line 555
PHP Notice:  Uninitialized string offset: 0 in 
/var/www/phpsvnclient/phpsvnclient.php on line 560

$t = explode("/",$value); 
This command leads to error when $value is not a string but $value is not 
guaranteed to be a string.

Please encapsulate this command by a
        if (is_string($value)) {

Thus:
        if (is_string($value)) {
            $t = explode("/",$value);

            // start from the end and move backwards until we find a 
non-blank entry
            $index = count($t) - 1;
            while ($t[$index] == ""){
                $index--;
            }

            // check the last non-empty element to see if it's 
numeric. If so, it's the revision number
            if (is_numeric($t[$index])) {
                $this->_repVersion = $t[$index];
                break;
            }
        }

What steps will reproduce the problem?
1. Setup the svnphpclient
2. var_dump($svn->getFile('file with spaces');

What is the expected output? What do you see instead?
The expected output is the contents of the file.
The recieved output is bool(false)

What version of the product are you using? On what operating system?
r.50 on windows / PHP5

Here is a patch for phpsvnclient.php which cleans up the docblocks, and
generally clarifies style.

What steps will reproduce the problem?

Given the following code:
    $svn = new PL_SvnClient();
    $svn->setAuth($username, $password);
    $svn->setRepository($some_repository);
    $ver = $svn->getVersion();

The version number will always be the same as the version of the phpsvnclient 
repository.


Proposed solution (ALL of these):
1. The default value for the first parameter to the constructor should be null.
2. Set _repVersion and actVersion to null (or 0) when in setRepository()
3. Don't use _repVersion or actVersion directly. Use a wrapper that will 
refresh them if they are not set yet.

What steps will reproduce the problem?
1. Run CheckOut
2.
3.

What is the expected output? What do you see instead?
Error on Line 233 Undefined variable: outText

What version of the product are you using? On what operating system?
current trunk

Please provide any additional information below.

Fix:

on line 233:

$outText .= "<font color='blue'>Getting file: </font> " . $path;

must be:

$outText = "<font color='blue'>Getting file: </font> " . $path;

Hey,

Nice PHP class, i'm using this for an OpenAtrium project and looks like this is 
a winner :).  I'm a mac OSX user and I had a little problem with copying the 
files from my svn server to my personal directory. Maybe the PHP function 
fopen() has changed a little (i don't know) but the problem was the script was 
pointing to a directory and not to a file. I received following warning:

[03-Jul-2012 10:49:03] PHP Warning:  
fopen(/Applications/MAMP/Dropbox/htdocs/SVNmang/svn/trunk/) [<a 
href='function.fopen'>function.fopen</a>]: failed to open stream: Is a 
directory in /Applications/MAMP/Dropbox/htdocs/SVNmang/svn/phpsvnclient.php on 
line 258


I changed  this line (255) in phpsvnclient.php

//Write to file
 $hOut = @fopen($createPath.$path, 'w');
fwrite($hOut, $contents);
fclose($hOut);

What steps will reproduce the problem?
ereg and eregi are deprecated in PHP 5.3

What version of the product are you using? On what operating system?
PHP 5.3

I would like to set custom properties for files and
directories (e.g. "codeexplorer:shortdescription") in my SVN Client,
and read them using phpsvnclient.

Just found a bug - for some reason sometimes when downloading files through the 
checkout create an empty file size 0 bytes. There also will conduct an analysis 
on this issue.

What steps will reproduce the problem?
1. use getFileLogs and there is a commit without comment.
2.
3.

What is the expected output? What do you see instead?
Return the log of the files/folders.


What version of the product are you using? On what operating system?
trunk


Please provide any additional information below.
you can solve this by changing the line 634

FROM:
$array['comment'] = $entry['tagData'];

TO:
$array['comment'] = isset($entry['tagData']) ? $entry['tagData'] : '';

Since phpsvnclient itself's a PHP5 system, here is a more PHP5ey edit of
the http.php file.

What steps will reproduce the problem?
1. Assume or create a repository where there is a directory example/, and a 
revision M which makes no changes to example/, and a revision N which does make 
changes to example/, where M < N.
2. perform a getFileLogs() on example/ with initial revision M and end revision 
N.

What is the expected output? What do you see instead?
I expect the output to show all revisions with changes after revision M and up 
to and including revision N.

The actual output is missing the lowest revision R where M < R <= N

e.g.
M = 19 (no changes to example/)
R = 22 (changes to example/)
N = 26 (changes to example/)

What version of the product are you using? On what operating system?
Revision 60.

Please provide any additional information below.
The functionality implies that getFileLogs() returns a diff. The code therefore 
attempts to exclude the log of the initial revision (which is actually a diff 
to the previous revision).
The class removes the first log item, assuming it is equal to the initial 
revision. In practise the first log item is not always equal to the initial 
revision.

Purpose of code changes on this branch:
r123 - Implemented new functionality to form a diff between revisions in the
repository.

When reviewing my code changes, please focus on:
Functionality to form a diff between revisions in the
repository.

I failed to use XAMPP 1.7.3
http://www.apachefriends.org/en/xampp-windows.html, 

I find a Error in function getVersion