bluesabre / sgt-launcher Goto Github PK

View Code? Open in Web Editor NEW

4.0 4.0 1.0 394 KB

A launcher for Simon Tatham's Portable Puzzle Collection

License: GNU General Public License v3.0

Python 98.87% Roff 1.13%

sgt-launcher's Introduction

Hey there 👋, I'm Sean Davis!

🏡 bluesabre.org 🌐 Planet Bluesabre

I'm a long-time contributor to FOSS projects such as Xfce and Xubuntu. Recently, I've started hacking on elementary OS as well.

🎩 Xfce Core Developer
🎩 Xubuntu Technical Lead
🎩 Xubuntu Council

In the not-so-FOSS world, I'm a full stack web developer juggling PHP, HTML, JavaScript, and increasingly, React on iOS and Android.

More about me

🔭 I’m currently working on improving 3rd-party apps on elementary OS
🌱 I’m currently learning Vala and Flatpak packaging
💬 Ask me about contributing to Xubuntu
🎮 My favorite games are Mega Man Zero and Final Fantasy (6-10, 15, and Tactics, not in that order)
📺 I love anime and superhero movies
🙂 Pronouns: he/him

Tools of the trade

Code

Support

sgt-launcher's People

Contributors

Stargazers

Watchers

Forkers

tenacious-contributor

sgt-launcher's Issues

Python syntax issues in SgtLauncher.py

This concerns sgt-launcher version 0.2.5-0ubuntu1 in Ubuntu focal.

I see the following when installing the package:

Setting up sgt-launcher (0.2.5-0ubuntu1) ...
/usr/lib/python3.8/subprocess.py:838: RuntimeWarning: line buffering (buffering=1) isn't supported in binary mode, the default buffer size will be used
self.stdin = io.open(p2cwrite, 'wb', bufsize)
/usr/lib/python3/dist-packages/sgtlauncher/SgtLauncher.py:232: SyntaxWarning: "is" with a literal. Did you mean "=="?
if name is "launcher":
/usr/lib/python3/dist-packages/sgtlauncher/SgtLauncher.py:235: SyntaxWarning: "is" with a literal. Did you mean "=="?
if name is "loading":
/usr/lib/python3/dist-packages/sgtlauncher/SgtLauncher.py:238: SyntaxWarning: "is" with a literal. Did you mean "=="?
if name is "game":
/usr/lib/python3/dist-packages/sgtlauncher/SgtLauncher.py:250: SyntaxWarning: "is not" with a literal. Did you mean "!="?
if name is not "launcher" and os.path.isfile(icon_name):
/usr/lib/python3/dist-packages/sgtlauncher/SgtLauncher.py:260: SyntaxWarning: "is" with a literal. Did you mean "=="?
if name is "game":

The "line buffering" warning is a different issue, but the SyntaxWarning messages indicate problems with at least one of this package's Python scripts.

Launchpad Details: #LP1870633 Daniel Richard G. - 2020-04-03 22:36:05 +0000

Empty Launchers panel (Arch Linux)

On Arch Linux (here I'm using Manjaro), the *.desktop" files are named "blackbox.desktop", "bridges.desktop", etc – without any prefix. Therefore, when get_launchers() searches for applications with a "sgt-" or "puzzle-" prefix, it will not find any.

Solution: Replace these three lines in SgtLauncher.py:

    for game in self.GAMES:
        for prefix in ["sgt", "puzzle"]:
            launcher = "applications/%s-%s.desktop" % (prefix, game)

    for game in self.GAMES:
        for prefix in ["sgt-", "puzzle-", ""]:
            launcher = "applications/%s%s.desktop" % (prefix, game)

Help issue on recent Xubuntu releases (firefox snap)

Not a serious issue, but not ideal

** Expected Result

Asking for app help will show help page in browser

** Actual Result

File not found

Firefox can’t find the file at /usr/share/sgt-puzzles/help/en/galaxies.html.

** Background

As reported on IRC (https://irclogs.ubuntu.com/2023/07/06/%23xubuntu.txt)

[22:20] Hi. I like to solve an apparent bug on help of SGT puzzles. Launch SGT puzzle, then launch any game. On menu Help > Help on , it opens a browser (firefox in my case) but shows "file not found" error and the path to html file. However, html files are actually there. I can view them with lynx for instance
[22:20] I use Xubuntu.
[22:21] frasson, this is probably due to firefox being a snap, which is constrained and can't access files outside

I can confirm this on my mantic system, with the following issue noted in firefox (snap)

This is a Ubuntu specific I too believe on modern Ubuntu releases where the default browser runs contained (snap package).

(filed here as launchpad indicated bugs are tracked here)

Games not loading

Ubuntu 20.04, Plasma Workspaces
Tried launching a couple of different games, launcher remains on loading screen

Game screens are frozen, can't use

Started happening when I upgraded from Ubuntu 19.10 to Ubuntu 20.04 earlier this week.

When opening games from the launcher, the game opens with default settings, and the game screen immediately becomes frozen: cannot interact with it, create new game, change settings, etc. Only the "Help" menu and "Quit" (return to launcher) options do something. If the window is resized, the view is not refreshed, leaving parts black or transparent.

Running individual games through their individual command line programs works fine.

Launchpad Details: #LP1877188 Amir Livne Bar-on - 2020-05-06 21:13:38 +0000

Mouse clicks not recognized

I can open all the games of SGT puzzles, but once it is open there is no effect to my mouse clicks. There is no issue with opening any menu item, but neither left or right mouse clicks actually do anything.

I am running Pop!_OS, version 20.10.

Attempting to build Flatpak package; puzzle windows fail to embed and instantly close

Hi there. I'm looking to build a Flatpak package for this nice launcher to make it more easily installable everywhere, since at present it only seems to be packaged in Ubuntu. My progress on the manifest is here. Python modules are kind of a pain, then I ended up having to make a tarball distribution of the .png icons because it doesn't include them and expects you to use imagemagick to generate them.

What I am stuck on at present is that the launcher can't actually embed any applications. It starts up any given application, but it immediately closes instead of embedding. There's no useful information printed to stdout or stderr. Do you have any insight on this?

embedded windows not working

Hi, embedded windows doesn't work for me on Xubuntu 22.04.
I had to force separate windows.

can't open Galaxies from launcher

When loading sgt-lanucher from menu. and selecting "Galaxies", it just spins endlessly and never opens.

When I sgt-launcher from terminal, and select "Galaxies" i get this on the terminal (and no change on terminal

guiverc@d960-ubu2:/de2900/ubuntu_podcasts/ubu_sec$ sgt-launcher
Traceback (most recent call last):
File "/usr/lib/python3/dist-packages/sgtlauncher/SgtSocketLauncher.py", line 52, in callback
withdrawn = self.wait_for_window_withdraw()
File "/usr/lib/python3/dist-packages/sgtlauncher/SgtSocketLauncher.py", line 89, in wait_for_window_withdraw
withdrawn = is_withdrawn(self.window_id)
File "/usr/lib/python3/dist-packages/sgtlauncher/SgtSocketLauncher.py", line 178, in is_withdrawn
withdrawn = not property_reply or property_value[0] == 0
TypeError: 'NoneType' object is not subscriptable

I'm using Lubuntu currently (thus LXQt is active desktop), but xubuntu-desktop is installed too.

Launchpad Details: #LP1864270 Chris Guiver - 2020-02-22 03:10:08 +0000