bmftzq / edge-frfox Goto Github PK

For some reason, the horizontal scrolling on this theme kicks in too early.
On default Firefox, horizontal scrolling starts at ~20 open tabs.
On this theme, it already begins way too early at just 7 tabs. There is nothing to scroll anyway, so it takes up unnecessary space.
Also, it seems like the "New Tab" animations disappear when this horizontal scrolling glitch occurs. There are no animations at all.
For example, this is how it should look like, on default Firefox:

This issue is now present in the latest commit of Edge-Frfox.

For a good comparison, here's the current height of the titlebar buttons in current Edge Canary:

Originally posted by @tobyisawesome in #14 (comment)

bmFtZQ has stated in response to this issue:

The only way to fix this (that I know of) is to hide the theme's icons and rely on the ones drawn by Windows. Since those icons are located in a fixed position the buttons have to be moved, otherwise you end up with misaligned buttons/icons:

While using the System-Auto theme, It is indeed replicating Edge's Tab bar color as like in below image:

But when using Dark theme as below. The Dark theme of Firefox is applied.

The second theme is not so good. I want the first tab bar's color when I enable Dark Theme.

I am suggesting that you create a theme of the first one and list it along other themes if possible or publish a theme in AMO.

Here's a video demonstrating the bug:

https://s3.us-west-2.amazonaws.com/secure.notion-static.com/99f2ca82-fb54-4b5c-82e1-f334b89d8c3f/win7.mov?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAT73L2G45O3KS52Y5%2F20210416%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20210416T021636Z&X-Amz-Expires=86400&X-Amz-Signature=0e9c5a43380cbbec925030c47af713e223dae39162f4123b39a6c790a9c711c2&X-Amz-SignedHeaders=host&response-content-disposition=filename%20%3D%22win7.mov%22

Apologies if the link looks sketchy, videos uploaded to Notion don't have a very pretty URL.

uc.tweak.force-tab-colour - What does this tweak actually do ?

I am confused by your Wording in Readme. A detailed explanation with images would be great.

1.

  I love your Firefox theme but they have this bug when i right click in Ubuntu:

2.

  and they have this bag when i want to search something (you can see 2 magnifier icon in search box) :

3.

 and this is other bug i found in dark mode (you can see they have no border for tabs) :

If you see the video, The Box (Padding) around firefox has blended with the color of the navigation bar. I get the thing that it is similar to edge but edge has a Vertical bar separating the badge and URL.

Better to fix it.

I really like this style. The standard Firefox look is OK, but I think this is better. The icons help provide extra polish.

Now for my issue...

When I enter text in the address bar, matching URLs from my history are listed and the first one highlighted. The highlight colour is too light IMO. Can I make this a little darker?

Firefox menu is like this (old version):

While Edge is like this:

The main difference is Acrylic. Can you add it?

Thanks

This might be achieved with the new backdrop-filter: blur() css property.

If uc.tweak.win11-mica is set to true and full screen mode is entered, a transparent window border will show around the display with rounded corners as if the browser is still in windowed mode. This does not happen if full screen mode is entered when the browser window is maximized, or the Mica tweak is disabled. Also, the window control icon for minimize, restore, and close disappear when the browser is in focus

Would you consider adding mica support to the tabbar? It already seems to work with this mod, so should be possible

The Below needs to be fixed. Firefox 100, Windows 11.

Hi

Would it be possible for you to theme the auto-fill form suggestions menu with rounded corners just like the rest of your beautiful edge theme?

I know this CSS is for replicating Edge's UI in FIrefox, But Do you consider about removing the Tab Separator because other tabs will seem unified and cleaner in terms of UI or helping me in removing that for myself alone ?

When there are two icons in the left side of urlbar, the pressed backgroud will overlay the another icon and the second icon's pressed background seems not showing at the right place.

A recent update seems to have changed the class used for the tab underline created by multi-account containers. This leads to duplicate underlines and the underline persisting when the tab is active.

Previously it was .tab-bottom-line

Now it is .tab-context-line

Can any way we make an port to chromium base?

In Edge, the close tab button always visible by default. I think it will simple to implement directly or make a option in Firefox config page.

When I click on Customize Toolbar, the whole tab bar is jiggly even if you just hover over one of the extensions and while arranging things.

On windows 11, here;s how the different browsers look:

Edge:

Firefox with Edge-FrFox

This is when both browsers are in maximized state. The titlebar button box container should respect the full height of the tabs toolbar for consistency. On the same note, the window control buttons also look outdated on Windows 11.

The issue is observable in both maximized and normal state.

Edit: Closing this because the issues seem to be fixed on the rewrite

I think Mica/Translucent effect for MacOS can be acheived by using this CSS - https://github.com/zvuc/firefox-macos-native-tabbar

I would like to make a PR but I have a custom fork for my own customization. So, I don't want to mess it up.

Hi. Can you check if there is transparency or not?
Vibrancy.txt

Tweak : uc.tweak.disable-drag-space
Description in Readme : disable drag space above tabs

I don't see any space above tabs in Firefox both in Maximized and minimized windows. Which space are you referring to ?

Could you fix the color of the alt text to reflect the dark grey theme? (the popup text when I hover over links or tabs)

Currently, it appears as a dark shade of purple, I think the one FF uses by default.

Firstly this is really great and I haven't seen much community contribution in it but it's gotten to the point where it's my daily driver theme.

On to the issue: When I enable the menubar, the titlebar buttons move higher up and are cut off.

I haven't looked through the code so I don't know what the cause/solution could be, but it'd be great if it was fixed since I prefer using the menubar.

Current Edge-FrFox control buttons:

Current Microsoft Edge control buttons:

Add icons for empty menu items:

Currently, the look of edge-frfox with Mica enabled (and floating tabs disabled) only has Mica in the tab row, with the address bar row being completely opaque.

Some may want for there to also be transparency in the address bar row too, without it being limited to just the tab row.

I propose for there to be a tweak that enables for the address bar row to be a lighter shade of Mica. I don't suggest for this to replace the current functionality, but I suggest for it to be an alternative tweak to those who may want it.

Here's an example where Mica extends under the tab row, where there are two shades of Mica. This screenshot is from File Explorer on the Beta channel of the Windows Insider Program.

Hi.
I can’t find where I can disable this bluish highlight outline globally..
Is there any easy way?

And also, in that about:home page, if I untick the "shortcuts" and "recent activity" checkboxes, then the Firefox logo and Google search box are not centered vertically. .
How can I fix it?
TIA

For some reason even with the tweak enabled the private mode indicator isn't visible.

-after the latest January, 2022 Update-
If I try to enter PIN somewhere, the suggestions context menu that shows up is not themed. It is default FF theme. Can you please fix this?

The theme seems to override titlebar buttons and so they dont look centered as they are supposed to on windows 11. How to edit just the titlebar theming stuff to use the default on firefox? Also, total noob here, thanks.

Great thanks for your working, I just really like this theme and it's already my daily driver theme. When using this, I found that the label of the tab is not vertically centered which is strange.

So I found the related code in the file name "tabbar.css".

I change set the value of margin-top to zero which make the label of tab become vertically centered.

Are there some reasons that value have to be -2px? If there were, is there any other ways to make the label vertically centered?
Thanks for your working, again.

Currently, buttons placed in the tab bar have really awkward spacing from the left edge of the window. It would be nice if these lined up with buttons placed on the address bar line. Also, it would be nice if buttons in the tab bar were the same size as buttons on the address bar so they will line up.

The theme doesn't work, I expected it to work, but it didn't.
I'm running Windows 11 Build 22000.527.
How can i fix this?

Would it be possible to introduce rounded corners to the saved passwords/suggestions menu like in Edge?

The size of the search icon on the new tab is considered to be about the size of the image below. Currently the icon is fixed to the same size as the background.

Referring to Edge, the search icon is not the full background, so it can be closer.

The following CSS can be used to modify it.

  .top-site-outer .default-icon,
  .top-site-outer .search-topsite {
    background-size: 15px !important;
    height: 24px !important;
    width: 24px !important;
  }

113 row

Firefox Tracking Protection Popup is hidden in the address Bar (aka URL Bar). When Clicking the Icon and trying to interact with the Interface, It closes automatically, Sort of annoying and uneasy to use it.

As you see in the image, The new commit has breaken things on my fork. I am not sure if this is because of you or my fork.

And Mica also doesn't apply even though my settings are :

Edge Canary seems to have a faint white outline and bolded text for the selected tab. I propose for Edge-Frfox to use this current design rather than the older one it uses now.

Top screenshot is Edge Canary, and the bottom is Edge-Frfox.

Issue

When opening the right click context menu or the bookmarks in a folder on the bookmark toolbar, the text is not highlighted when hovering over the text of the folder or context menu.

Information

Operating System: Windows 10
Browser: Firefox 88

Hello, I really like this theme and I use it everyday, but since the latest Firefox Nightly version that updates to Firefox 92, the "Bookmark this page", "Page actions" button and "Protections" button are misaligned in the address bar. Video is attached to see more about this behaviour.

The Context Menu looks near perfect now with the new edge icons.
However, the font is a little larger than how it appears on edge.
Could you make the context menu font slightly smaller?

• Current Font Size:

• Font Size on Edge:

Microsoft edge has this nice animation while loading a page. The current version of this userChrome does not have this characteristic. It uses the default Firefox bouncing animation.
Could this be implemented as a slight enhancement?