bmoscon / bitarray Goto Github PK

incorrectly adding 1 to index

look up table not needed. it places a restriction on how many bits per element we can support. instead of using lookup table to find the mask, use the following to calculate on container construction:

2^(bits_per_element) - 1

add support for #of bits > 16

as it is, bitcount() is calculated on every call. can be calculated once, on init, and stored to improve performance to all calls that make use of bitcount()

temp fix for #4

If a combination of # of elements, # of bits, and underlying datatype cross boundaries, the array will fail to properly contain the last element.

for example, if you set the number of bits to 10, and use 7 elements(using a uint64_t datatype), this requires 70 total bits, which is not a multiple or factor of 64, Bit array is not smart enough to use the last 4 bits of the previous uint64_t element, so if you set the last element to 1024, only the last 6 bits will be set, since it is unable to set the previous 4 bits in the previous uint64_t. For now, just disallowing bit sizes that are not factors of the datatype.