bogdanovich / ngrok-tunnel Goto Github PK

I love ngrok-tunnel. Thank you so much for making it.

Following @tinbka's advice in https://github.com/bogdanovich/ngrok-tunnel/blob/master/examples/rack-server.rb I have it setup in my puma.rb.

This issue is to ask "why" you folks specifically recommend putting it in the webserver config files, and not standard initializers? My gut tells me that you had a specific reason or gotcha, and it would potentially save many headaches if you were able to remember the factors behind your decisions.

Heyo!
Firstly, great gem :) 👏

Just started using Ngrok for the firs time in a while, and needed to use the region parameter. I ensured I was using the latest version, and checked the source code, but the region parameter was being ignored. It took me opening the gem to realise that your latest commits haven't been released yet 🤦‍♂️

Using the master branch for now, but suggest realeasing a new version of the gem 😄

Ngrok::Error: Only paid plans may bind custom subdomains.\nFailed to bind the custom subdomain 'builder-admin-panel' for an unauthenticated client.\nSign up at: https://ngrok.com/signup\n\nIf you have already signed up, make sure your authtoken is installed.\nYour authtoken is available on your dashboard: https://dashboard.ngrok.com\r\n\r\nERR_NGROK_305\r\n

~ $ chmod 777 ngrok
~ $ ./ngrok authtoken 1y54WLRLCTMPKDTr78sPD3ans2e_5yJzdAP3Y48bXhRcMaDZj
bash: ./ngrok: Bad address
~ $

Hi. I've built a gem for localtunnel (an ngrok alternative), using your gem as inspiration. So thanks!

Looking at your code, one thing I noticed is that there is a potential problem with the Ngrok::Tunnel.running? method. If something else (other than Ngrok::Tunnel.stop) kills the tunnel's process, Ngrok::Tunnel.running? will continue to return true, because the @status attribute is stale. To fix this, Ngrok::Tunnel.running? could check whether the process is actually alive via Process.waitpid. Here's an example from my gem: link.

Also, I think it may be a good idea for Ngrok::Tunnel.stop? to wait until the process is completely destroyed after calling Process.kill, since it can take a few moments. Again, here's an example from my gem: link.

Given that this repo hasn't been touched in three years, and @bogdanovich hasn't been active on github in at least a year, I'd guess that this repo is abandoned. Is anyone interested in taking over maintenance and ownership?

After updating to ngrok 3.0.3 Ngrok::Tunnel.start now errors:
ERROR: unknown shorthand flag: 'l' in -log=stdout

There is a PR in progress to make the gem compatible #22