GithubHelp home page GithubHelp logo

Comments (5)

u-rogel avatar u-rogel commented on September 24, 2024

I am new here, so not sure if I should send a PR for that or you wanna fix it on your own since it's a tiny fix.

from fcc-react-tests-module.

bonham000 avatar bonham000 commented on September 24, 2024

@cowCrazy thanks for bringing this up, I think your suggestion is a good improvement. Feel free to match a PR for this change. I think it will improve the test — however, many of the tests are not completely foolproof. For instance, this suggestion could still be broken as follows:

componentWillReceiveProps(nextProps) {
   console.log(this.props);
   // nextProps;
}

Feel free to just implement and PR the solution you suggested, however. Thanks for bringing this up!

from fcc-react-tests-module.

u-rogel avatar u-rogel commented on September 24, 2024

@bonham000 I also noticed it is not completely foolproof, if you want I can try and rise the foolproof level with something like that:

  1. For nextProps as a function parameter
  2. For nextProps in a console.log call

from fcc-react-tests-module.

bonham000 avatar bonham000 commented on September 24, 2024

@cowCrazy yes — sorry for the delay — feel free to improve the test here, but don't feel obliged.

from fcc-react-tests-module.

bonham000 avatar bonham000 commented on September 24, 2024

Resolved in above-mentioned PR!

from fcc-react-tests-module.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.