Comments (5)
I am new here, so not sure if I should send a PR for that or you wanna fix it on your own since it's a tiny fix.
from fcc-react-tests-module.
@cowCrazy thanks for bringing this up, I think your suggestion is a good improvement. Feel free to match a PR for this change. I think it will improve the test — however, many of the tests are not completely foolproof. For instance, this suggestion could still be broken as follows:
componentWillReceiveProps(nextProps) {
console.log(this.props);
// nextProps;
}
Feel free to just implement and PR the solution you suggested, however. Thanks for bringing this up!
from fcc-react-tests-module.
@bonham000 I also noticed it is not completely foolproof, if you want I can try and rise the foolproof level with something like that:
- For
nextProps
as a function parameter - For
nextProps
in aconsole.log
call
from fcc-react-tests-module.
@cowCrazy yes — sorry for the delay — feel free to improve the test here, but don't feel obliged.
from fcc-react-tests-module.
Resolved in above-mentioned PR!
from fcc-react-tests-module.
Related Issues (20)
- Exercise 43 - Seems correct to me. HOT 2
- Typo - Challenge 36: Manage Updates with Lifecycle Methods HOT 1
- Re-write React Challenge 30: Create a Controlled Form HOT 2
- React Challenge 20 seems to have an error recognizing "PropTypes" when that is included HOT 4
- React 30: Using <form> tags with onSubmit listener causes page refresh HOT 4
- React challenge alpha #35 incorrectly accepts a string as a parameter to add or remove event listener call HOT 3
- Not teaching an async or routing library. HOT 1
- Lesson 37 - Rendering and Performance in React HOT 3
- React Lesson 45: setting state based on previous state HOT 2
- React challenge 38 HOT 2
- Redux 14 challenge: Do not Mutate state HOT 5
- Redux 9 HOT 1
- Add a Test Suite for the Project Itself HOT 1
- Render to DOM node failing on all tests requiring it HOT 4
- Redux challenge 7, potentially misleading text in test description HOT 1
- Redux Challenge 10, introductory text might be unclear HOT 1
- use deepFreeze to ensure immutability for redux challenges
- React 23 : Challenge Implementing strict string match. Should probably watch the output instead! HOT 3
- React Challenges Ready to Migrate
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fcc-react-tests-module.