Comments (3)
Hmm interesting discovery @AdityaOli. The test for this case is:
assert.strictEqual(modifiedCode.includes('<h1>{name}</h1>'), true, error_3);
which presumably fails because there are new line / whitespace characters in the h1
tag. I think we could update the test to find the h1
element and verify that it's child includes "Free Code Camp"
, and separately verify that the code includes the string {name}
. This would still not be a perfect solution, but with many of these challenges the tests cases are not unbreakable but about as good as we can get it. Let me know if you're interested in trying to PR a solution for this, otherwise I will do it later when I have a chance! Thanks.
from fcc-react-tests-module.
Cool I fixed it.
from fcc-react-tests-module.
Could not find a window to work on it! 😞 . Thanks @bonham000
from fcc-react-tests-module.
Related Issues (20)
- Exercise 43 - Seems correct to me. HOT 2
- Typo - Challenge 36: Manage Updates with Lifecycle Methods HOT 1
- Re-write React Challenge 30: Create a Controlled Form HOT 2
- React Challenge 20 seems to have an error recognizing "PropTypes" when that is included HOT 4
- React 30: Using <form> tags with onSubmit listener causes page refresh HOT 4
- React challenge alpha #35 incorrectly accepts a string as a parameter to add or remove event listener call HOT 3
- Not teaching an async or routing library. HOT 1
- Lesson 37 - Rendering and Performance in React HOT 3
- React Lesson 45: setting state based on previous state HOT 2
- React challenge 38 HOT 2
- Redux 14 challenge: Do not Mutate state HOT 5
- React 36 - nextProps issue HOT 5
- Redux 9 HOT 1
- Add a Test Suite for the Project Itself HOT 1
- Render to DOM node failing on all tests requiring it HOT 4
- Redux challenge 7, potentially misleading text in test description HOT 1
- Redux Challenge 10, introductory text might be unclear HOT 1
- use deepFreeze to ensure immutability for redux challenges
- React Challenges Ready to Migrate
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fcc-react-tests-module.