GithubHelp home page GithubHelp logo

Comments (3)

bonham000 avatar bonham000 commented on September 24, 2024

Hmm interesting discovery @AdityaOli. The test for this case is:

assert.strictEqual(modifiedCode.includes('<h1>{name}</h1>'), true, error_3);

which presumably fails because there are new line / whitespace characters in the h1 tag. I think we could update the test to find the h1 element and verify that it's child includes "Free Code Camp", and separately verify that the code includes the string {name}. This would still not be a perfect solution, but with many of these challenges the tests cases are not unbreakable but about as good as we can get it. Let me know if you're interested in trying to PR a solution for this, otherwise I will do it later when I have a chance! Thanks.

from fcc-react-tests-module.

bonham000 avatar bonham000 commented on September 24, 2024

Cool I fixed it.

from fcc-react-tests-module.

nzineer avatar nzineer commented on September 24, 2024

Could not find a window to work on it! 😞 . Thanks @bonham000

from fcc-react-tests-module.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.