boshen / cargo-shear Goto Github PK

I only considered normal dependencies

biomejs/biome#2153 (comment)

The feature is used here:

https://github.com/biomejs/biome/blob/cd0bae103301b41f0d4d0ae171b3da443946a979/crates/biome_css_formatter/src/lib.rs#L379

From cargo-machette:

Analyzing dependencies of crates in this directory...
cargo-machete found the following unused dependencies in .:
rspack_binding_values -- ./crates/rspack_binding_values/Cargo.toml:
	rspack_identifier
Done!

If you believe cargo-machete has detected an unused dependency incorrectly,
you can add the dependency to the list of dependencies to ignore in the
`[package.metadata.cargo-machete]` section of the appropriate Cargo.toml.
For example:

[package.metadata.cargo-machete]
ignored = ["prost"]

Thanks for this nice project, we are using a dirty script for checking it:
https://github.com/nervosnetwork/ckb/blob/develop/devtools/ci/check-cargotoml.sh

I have a try on cargo-shear, seems there are 3 false positive warnings, here is how to reproduce it:

git clone https://github.com/nervosnetwork/ckb.git
cd ckb
cargo shear --fix
make check [here we will see the compiling error after fix]

Hi Boshen. I mean this library is so awesome!

I'm now working on removing unused dependencies using cargo-shear, and found a bug. I hope you'll check it.
Tisis the issue im working on: biomejs/biome#2136

What is the issue

cargo-shear removes quickcheck even if it is checked

log

error[E0433]: failed to resolve: could not find `quickcheck` in the list of imported crates
  --> crates/biome_json_parser/src/lexer/tests.rs:63:1
   |
63 | #[quickcheck]
   | ^^^^^^^^^^^^^ could not find `quickcheck` in the list of imported crates
   |
   = note: this error originates in the attribute macro `quickcheck` (in Nightly builds, run with -Z macro-backtrace for more info)

For more information about this error, try `rustc --explain E0433`.
error: could not compile `biome_json_parser` (lib test) due to 1 previous error
warning: build failed, waiting for other jobs to finish...

In the "Prior Arts" section you mention two alternatives, how they differ?

Some crates defines their module names in [lib] name.

e.g.

https://github.com/zonyitoo/rust-ini/blob/c901b45c3197a881e06b6934ce8a15a0404f0c43/Cargo.toml#L13-L14

Found in https://github.com/getsentry/sentry-cli

We need to extend the manifest to include the lib name https://docs.rs/cargo_toml/latest/cargo_toml/struct.Manifest.html#method.complete_from_path_and_workspace